From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 075AB4C62; Mon, 23 Jun 2025 21:15:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750713315; cv=none; b=DH/TeJy3mHNlk96GSUA3pl7sZG9B7Ict4yQO2yLiaNjeOfzhoKc0q7apBEitM27o4IXJb8RPL/tr8WIuHWX/4pdv42K73kLEhh53nLM+gREJRV2VhUel23zoWLxrajkIycMFckPo4GJyavWaz7xY5uHzdwdYcN+E4+GQ7e7GegI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750713315; c=relaxed/simple; bh=P7he+0IXfE0cBLLELaXKok9PTxDmtsq2YWRmi2ioYe4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=TLyYfuSy+KtvJtTydJISgdraBBBNdAuXOJROXmkmYQkTZ94LNK1NrmGQzeXWkZtLJsBWHrdHH3QPbd4ZB98SOGAIbQGgJdBMh86Fpnd0pbABjZJJqJGs7j4vrbiCxcNw2wCZfbW7w7MCEAFLNyCN0bbR5ALFRO8SCz/Z/7/aXyw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=cLjhHuAP; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="cLjhHuAP" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 44FA1C4CEEA; Mon, 23 Jun 2025 21:15:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1750713314; bh=P7he+0IXfE0cBLLELaXKok9PTxDmtsq2YWRmi2ioYe4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=cLjhHuAP6Dl5nao4K2+rJDmF3A/Z+qIK0fJj8j8b5tszzLCDbKV4BCBrbtnqMaiiX 88iyVNkr6+8prx2MYbhbCncXVkmbkKKGwd32u5oxSqID391EnaET1Sk/DTLRIRid88 eRC7CM6I41HKJWOxFUc1WWfUVizquirg6l7VvEC8= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Gerrard Tai , Cong Wang , Jamal Hadi Salim , Paolo Abeni , Sasha Levin Subject: [PATCH 5.10 137/355] sch_ets: make est_qlen_notify() idempotent Date: Mon, 23 Jun 2025 15:05:38 +0200 Message-ID: <20250623130630.844557176@linuxfoundation.org> X-Mailer: git-send-email 2.50.0 In-Reply-To: <20250623130626.716971725@linuxfoundation.org> References: <20250623130626.716971725@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Cong Wang [ Upstream commit a7a15f39c682ac4268624da2abdb9114bdde96d5 ] est_qlen_notify() deletes its class from its active list with list_del() when qlen is 0, therefore, it is not idempotent and not friendly to its callers, like fq_codel_dequeue(). Let's make it idempotent to ease qdisc_tree_reduce_backlog() callers' life. Also change other list_del()'s to list_del_init() just to be extra safe. Reported-by: Gerrard Tai Signed-off-by: Cong Wang Link: https://patch.msgid.link/20250403211033.166059-6-xiyou.wangcong@gmail.com Acked-by: Jamal Hadi Salim Signed-off-by: Paolo Abeni Stable-dep-of: d92adacdd8c2 ("net_sched: ets: fix a race in ets_qdisc_change()") Signed-off-by: Sasha Levin --- net/sched/sch_ets.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/net/sched/sch_ets.c b/net/sched/sch_ets.c index 35b8577aef7dc..55b3362d27106 100644 --- a/net/sched/sch_ets.c +++ b/net/sched/sch_ets.c @@ -298,7 +298,7 @@ static void ets_class_qlen_notify(struct Qdisc *sch, unsigned long arg) * to remove them. */ if (!ets_class_is_strict(q, cl) && sch->q.qlen) - list_del(&cl->alist); + list_del_init(&cl->alist); } static int ets_class_dump(struct Qdisc *sch, unsigned long arg, @@ -499,7 +499,7 @@ static struct sk_buff *ets_qdisc_dequeue(struct Qdisc *sch) if (unlikely(!skb)) goto out; if (cl->qdisc->q.qlen == 0) - list_del(&cl->alist); + list_del_init(&cl->alist); return ets_qdisc_dequeue_skb(sch, skb); } @@ -674,7 +674,7 @@ static int ets_qdisc_change(struct Qdisc *sch, struct nlattr *opt, } for (i = q->nbands; i < oldbands; i++) { if (i >= q->nstrict && q->classes[i].qdisc->q.qlen) - list_del(&q->classes[i].alist); + list_del_init(&q->classes[i].alist); qdisc_tree_flush_backlog(q->classes[i].qdisc); } q->nstrict = nstrict; @@ -723,7 +723,7 @@ static void ets_qdisc_reset(struct Qdisc *sch) for (band = q->nstrict; band < q->nbands; band++) { if (q->classes[band].qdisc->q.qlen) - list_del(&q->classes[band].alist); + list_del_init(&q->classes[band].alist); } for (band = 0; band < q->nbands; band++) qdisc_reset(q->classes[band].qdisc); -- 2.39.5