From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ECA173FB1B; Mon, 23 Jun 2025 21:47:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750715233; cv=none; b=VSlqGF1RLRx5hsivpUN30x7i9ikiwkWjUd6WwfaOn0AzLZPZKOyG9Lr8f7a8BAvgKXTvt+XTjXQagVju/j4/vU/oKTwOazBVjEyWZl0efhYZWq3Rcq6568s6nlXmhhrZ0wKCUBtoeKGpzjzcLz2HEXwkEGOkP5zgCL+bMleCnLM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750715233; c=relaxed/simple; bh=xLIQz4jWVbcav8f/VVkCqPsbQcdYzATvWmQ/fybU03k=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=WW3DECRE77g5d8TaQTTLASsHbM8mZCjgua/9rapNR/5apU1g7h26jRx5ZxWGIfqJaTqppEOk0P0LgngyyX3v0dNKIH8lseHAny7kBMekFop6ARghfAF/nDonsXPBmHiK9wOwxlKtn6Qj5/suK6Xkt3sWWrDG7muK4gsyXQuCghQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=uxaq7ta3; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="uxaq7ta3" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 85F39C4CEEA; Mon, 23 Jun 2025 21:47:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1750715232; bh=xLIQz4jWVbcav8f/VVkCqPsbQcdYzATvWmQ/fybU03k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=uxaq7ta3DjtSejNMxr4OaR+lQvtUoZ5WZC/pTRVFmoEJCIOGvz7UAX6MitqsLP6bf Pxe7gZK2kBr4XmZRzKg0uHFn/FRZzbkUG8V16EtrvjNsBvBL0UUUO353aWqOF6DRZu A6+KCJTNjGrd0GqnC5X4hbvdkW1NqodImUQeyYQA= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Imre Kaloz , Andrew Lunn , Gabor Juhos , Linus Walleij , Sasha Levin Subject: [PATCH 5.10 262/355] pinctrl: armada-37xx: propagate error from armada_37xx_pmx_gpio_set_direction() Date: Mon, 23 Jun 2025 15:07:43 +0200 Message-ID: <20250623130634.630624437@linuxfoundation.org> X-Mailer: git-send-email 2.50.0 In-Reply-To: <20250623130626.716971725@linuxfoundation.org> References: <20250623130626.716971725@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Gabor Juhos [ Upstream commit bfa0ff804ffa8b1246ade8be08de98c9eb19d16f ] The armada_37xx_gpio_direction_{in,out}put() functions can fail, so propagate their error values back to the stack instead of silently ignoring those. Signed-off-by: Imre Kaloz Reviewed-by: Andrew Lunn Signed-off-by: Gabor Juhos Link: https://lore.kernel.org/20250514-pinctrl-a37xx-fixes-v2-5-07e9ac1ab737@gmail.com Signed-off-by: Linus Walleij Signed-off-by: Sasha Levin --- drivers/pinctrl/mvebu/pinctrl-armada-37xx.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c index 1cb3bcb41684e..bd3eebf564236 100644 --- a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c +++ b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c @@ -468,16 +468,17 @@ static int armada_37xx_pmx_gpio_set_direction(struct pinctrl_dev *pctldev, { struct armada_37xx_pinctrl *info = pinctrl_dev_get_drvdata(pctldev); struct gpio_chip *chip = range->gc; + int ret; dev_dbg(info->dev, "gpio_direction for pin %u as %s-%d to %s\n", offset, range->name, offset, input ? "input" : "output"); if (input) - armada_37xx_gpio_direction_input(chip, offset); + ret = armada_37xx_gpio_direction_input(chip, offset); else - armada_37xx_gpio_direction_output(chip, offset, 0); + ret = armada_37xx_gpio_direction_output(chip, offset, 0); - return 0; + return ret; } static int armada_37xx_gpio_request_enable(struct pinctrl_dev *pctldev, -- 2.39.5