From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D96E4223335; Mon, 23 Jun 2025 21:18:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750713506; cv=none; b=J+U4rvB9bjoClEXqKDVwXG0IkKoxDuIvXXP5mdSKYBV4WpmMV5H0wbv0qs3QVoc0PIRRjMLNFeZyR358zmsompvqfgZ64rMdyPOOFCuR6PSqkv566D/kyGwTsd3e5ajl95U9lCEqNQ+RZt1eXH4AHjHcwFLbSBxSTEX1CoSIBVM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750713506; c=relaxed/simple; bh=6pEoo+EYYSNyMZJD0iLVfOtbQJf2KucKIaTSsK/gXg8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=BiJU6k4KTwoF0uScvBXgP72enTGIvK0h7l4rP5DCAYrW5nqmNAhUrH8vwUDoJ1Z3DBT2liQ+ei8cPMzmY+XpsybF6PomDjHsbjiGfjseGvsQAS4QxJ06AXNzNQmAygzBD0UmCREJ7qsJrlQzDFky1I7QIvMvBK0DEjToTdMlSXM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=KdaSZct4; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="KdaSZct4" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 72C3AC4CEEA; Mon, 23 Jun 2025 21:18:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1750713506; bh=6pEoo+EYYSNyMZJD0iLVfOtbQJf2KucKIaTSsK/gXg8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KdaSZct4YZDUDlx5OyDCQXPcFOGP8T7o0aqjCixSWQvx1teVwgqZdsfAw0gU21nPb sXHFxuEyelIRgKlmvZ+CS52lrib/Ab/OXPnXYPCSH65MRyyxiYqK3QxUMAT2zyxVaZ xVrJEG0nW66VPa+FKyX5ykdb3/QIWNa2R4Txf3NY= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Zeal Robot , zhang songyi , Dmitry Torokhov , Sasha Levin Subject: [PATCH 5.15 131/411] Input: synaptics-rmi4 - convert to use sysfs_emit() APIs Date: Mon, 23 Jun 2025 15:04:35 +0200 Message-ID: <20250623130636.868999039@linuxfoundation.org> X-Mailer: git-send-email 2.50.0 In-Reply-To: <20250623130632.993849527@linuxfoundation.org> References: <20250623130632.993849527@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: zhang songyi [ Upstream commit 9dedc915937c33302df7fcab01c45e7936d6195a ] Follow the advice of the Documentation/filesystems/sysfs.rst and show() should only use sysfs_emit() or sysfs_emit_at() when formatting the value to be returned to user space. Reported-by: Zeal Robot Signed-off-by: zhang songyi Link: https://lore.kernel.org/r/20220927070936.258300-1-zhang.songyi@zte.com.cn Signed-off-by: Dmitry Torokhov Stable-dep-of: ca39500f6af9 ("Input: synaptics-rmi - fix crash with unsupported versions of F34") Signed-off-by: Sasha Levin --- drivers/input/rmi4/rmi_f34.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/input/rmi4/rmi_f34.c b/drivers/input/rmi4/rmi_f34.c index e5dca9868f87f..c26808f10827a 100644 --- a/drivers/input/rmi4/rmi_f34.c +++ b/drivers/input/rmi4/rmi_f34.c @@ -321,13 +321,13 @@ static ssize_t rmi_driver_bootloader_id_show(struct device *dev, f34 = dev_get_drvdata(&fn->dev); if (f34->bl_version == 5) - return scnprintf(buf, PAGE_SIZE, "%c%c\n", - f34->bootloader_id[0], - f34->bootloader_id[1]); + return sysfs_emit(buf, "%c%c\n", + f34->bootloader_id[0], + f34->bootloader_id[1]); else - return scnprintf(buf, PAGE_SIZE, "V%d.%d\n", - f34->bootloader_id[1], - f34->bootloader_id[0]); + return sysfs_emit(buf, "V%d.%d\n", + f34->bootloader_id[1], + f34->bootloader_id[0]); } return 0; @@ -346,7 +346,7 @@ static ssize_t rmi_driver_configuration_id_show(struct device *dev, if (fn) { f34 = dev_get_drvdata(&fn->dev); - return scnprintf(buf, PAGE_SIZE, "%s\n", f34->configuration_id); + return sysfs_emit(buf, "%s\n", f34->configuration_id); } return 0; @@ -499,7 +499,7 @@ static ssize_t rmi_driver_update_fw_status_show(struct device *dev, if (data->f34_container) update_status = rmi_f34_status(data->f34_container); - return scnprintf(buf, PAGE_SIZE, "%d\n", update_status); + return sysfs_emit(buf, "%d\n", update_status); } static DEVICE_ATTR(update_fw_status, 0444, -- 2.39.5