From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 320B322257E; Mon, 23 Jun 2025 21:44:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750715095; cv=none; b=rgnfqhOKCPDUBaNPcBIBn+i1uTCgJVp8rFXD/Sb3ZrBGxu2Lm21HOW2YfOcVlZVniuAf7Z/MxGC4vcQro2b/NWDkJNzGcVHxmIMHHMJuu4zPO+8XHkzSQD/aux6/R69sUxnzpzUo5qgqVXZYBGsmrBtro3C86FJMYHF8WBL8p1k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750715095; c=relaxed/simple; bh=tn78LqaRIqVJkU4nF6YlMeHQwNysXNtJj68n+QXnQ18=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=m8zNavbpZdHUTZt7QWnW2o9vZIp2PZcVppUMebcMx0DbMEa+uWqThsiphYwQKZJqXpAMPPzqsEpPbhxWG9Z2KNZGBmjtJbzrIG0yctFSyrgAs3R0EyNxWz/ulz9XvJj3fanWFFJvj7N1J/bzVbZmfQRjeMPN4koKpVQE9w1zp5Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=IcW24UoJ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="IcW24UoJ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 52C58C4CEF5; Mon, 23 Jun 2025 21:44:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1750715094; bh=tn78LqaRIqVJkU4nF6YlMeHQwNysXNtJj68n+QXnQ18=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=IcW24UoJc8bF2IK7ooUW7usxiY5jX99R//zqgCc6L7stKqGrlqrRQD/VH0o9C9CJ2 4VQiNkCw0gJmeevS5cAXvt0mdlS+pvGdPfGdfu543uUUcocQ7C52Fwbckiduqmdpul jxGyywB0Aylp0UgsV3Al6DRRz2zVdJ3NfRxx25yU= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Diederik de Haas , Manivannan Sadhasivam , Niklas Cassel , Dragan Simic , Shawn Lin Subject: [PATCH 6.12 155/414] PCI: dw-rockchip: Fix PHY function call sequence in rockchip_pcie_phy_deinit() Date: Mon, 23 Jun 2025 15:04:52 +0200 Message-ID: <20250623130645.916390785@linuxfoundation.org> X-Mailer: git-send-email 2.50.0 In-Reply-To: <20250623130642.015559452@linuxfoundation.org> References: <20250623130642.015559452@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Diederik de Haas commit 286ed198b899739862456f451eda884558526a9d upstream. The documentation for the phy_power_off() function explicitly says that it must be called before phy_exit(). Hence, follow the same rule in rockchip_pcie_phy_deinit(). Fixes: 0e898eb8df4e ("PCI: rockchip-dwc: Add Rockchip RK356X host controller driver") Signed-off-by: Diederik de Haas [mani: commit message change] Signed-off-by: Manivannan Sadhasivam Reviewed-by: Niklas Cassel Reviewed-by: Dragan Simic Acked-by: Shawn Lin Cc: stable@vger.kernel.org # v5.15+ Link: https://patch.msgid.link/20250417142138.1377451-1-didi.debian@cknow.org Signed-off-by: Greg Kroah-Hartman --- drivers/pci/controller/dwc/pcie-dw-rockchip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/pci/controller/dwc/pcie-dw-rockchip.c +++ b/drivers/pci/controller/dwc/pcie-dw-rockchip.c @@ -377,8 +377,8 @@ static int rockchip_pcie_phy_init(struct static void rockchip_pcie_phy_deinit(struct rockchip_pcie *rockchip) { - phy_exit(rockchip->phy); phy_power_off(rockchip->phy); + phy_exit(rockchip->phy); } static const struct dw_pcie_ops dw_pcie_ops = {