From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 499211E5B71; Mon, 23 Jun 2025 21:27:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750714060; cv=none; b=YIrXZA3I2GQKQOgvMnM/7CplR8+L8vG9sDnA1enHvdG5OikLlrW5sLGGRPMPK9K/yNiyc2/L4e/u8VIUQyk7t1heSgHroU2izV4oKwt0uv81ySqwkUWB8+2k1RNsosYCHfXHYrWBAyRu8h/PrQ0EzcD5MzU0i4crvjil34nIqmE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750714060; c=relaxed/simple; bh=bidgK0pt7ywVO8fbZy+ZvMwP4NUns2OP4oD/BZLIeeI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=lCMWkErdkmBwtbZ0oZoF4276qwy8jis03pSI3WiHhR43Lr7DAMKhLvrlH+VjEWRvVYATAA7fG9tqp6YWf64sF62Hi4XaowFS2RHHt3qbF8eGTzygkBUDuvduZQfbuB4hhBOrqcdjG5fU83MuTzyach3z8z/wtQlaof2cE7NvVyM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=Zy1uQEWd; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Zy1uQEWd" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7C440C4CEEA; Mon, 23 Jun 2025 21:27:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1750714059; bh=bidgK0pt7ywVO8fbZy+ZvMwP4NUns2OP4oD/BZLIeeI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Zy1uQEWdePUFnDxDppgoQb8mQb6H1USPmOBp4pU07rcNiiicu9WyWTyZccGorl4CO B9IAo44xtF2qXisl7bJ0OCMNFL5S1DeR8D+IJOAyIjqvObDhYARv++axlgpFtn7iKq q0ZV22HBMzX9ZOJDzk/i0pUiiLYmxgI1MDwhTi6s= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Siddharth Vadapalli , Beleswar Padhi , Judith Mendez , Andrew Davis , Mathieu Poirier , Sasha Levin Subject: [PATCH 6.1 142/508] remoteproc: k3-r5: Drop check performed in k3_r5_rproc_{mbox_callback/kick} Date: Mon, 23 Jun 2025 15:03:07 +0200 Message-ID: <20250623130648.780928322@linuxfoundation.org> X-Mailer: git-send-email 2.50.0 In-Reply-To: <20250623130645.255320792@linuxfoundation.org> References: <20250623130645.255320792@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Siddharth Vadapalli [ Upstream commit 9995dbfc2235efabdb3759606d522e1a7ec3bdcb ] Commit f3f11cfe8907 ("remoteproc: k3-r5: Acquire mailbox handle during probe routine") introduced a check in the "k3_r5_rproc_mbox_callback()" and "k3_r5_rproc_kick()" callbacks, causing them to exit if the remote core's state is "RPROC_DETACHED". However, the "__rproc_attach()" function that is responsible for attaching to a remote core, updates the state of the remote core to "RPROC_ATTACHED" only after invoking "rproc_start_subdevices()". The "rproc_start_subdevices()" function triggers the probe of the Virtio RPMsg devices associated with the remote core, which require that the "k3_r5_rproc_kick()" and "k3_r5_rproc_mbox_callback()" callbacks are functional. Hence, drop the check in the callbacks. Fixes: f3f11cfe8907 ("remoteproc: k3-r5: Acquire mailbox handle during probe routine") Signed-off-by: Siddharth Vadapalli Signed-off-by: Beleswar Padhi Tested-by: Judith Mendez Reviewed-by: Andrew Davis Link: https://lore.kernel.org/r/20250513054510.3439842-2-b-padhi@ti.com Signed-off-by: Mathieu Poirier Signed-off-by: Sasha Levin --- drivers/remoteproc/ti_k3_r5_remoteproc.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/drivers/remoteproc/ti_k3_r5_remoteproc.c b/drivers/remoteproc/ti_k3_r5_remoteproc.c index 580f86de654f2..75f0b8c99e0b1 100644 --- a/drivers/remoteproc/ti_k3_r5_remoteproc.c +++ b/drivers/remoteproc/ti_k3_r5_remoteproc.c @@ -189,10 +189,6 @@ static void k3_r5_rproc_mbox_callback(struct mbox_client *client, void *data) const char *name = kproc->rproc->name; u32 msg = omap_mbox_message(data); - /* Do not forward message from a detached core */ - if (kproc->rproc->state == RPROC_DETACHED) - return; - dev_dbg(dev, "mbox msg: 0x%x\n", msg); switch (msg) { @@ -228,10 +224,6 @@ static void k3_r5_rproc_kick(struct rproc *rproc, int vqid) mbox_msg_t msg = (mbox_msg_t)vqid; int ret; - /* Do not forward message to a detached core */ - if (kproc->rproc->state == RPROC_DETACHED) - return; - /* send the index of the triggered virtqueue in the mailbox payload */ ret = mbox_send_message(kproc->mbox, (void *)msg); if (ret < 0) -- 2.39.5