From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DB900223708; Mon, 23 Jun 2025 21:33:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750714384; cv=none; b=AZc9euqnTDaspzyZ1NnEKDhhZwA15w4wElbgUXO7QoDq6Q225YJ6dEMYIij51ml7ShWdVqmKTuhD2CN1aSw2LSp0vttmBFhomHmUWTQslE1RGSvQgdkPLAeKTuVJVRb/ACTkksDj4vF6hc59AdQZzLVsovjLn0kBpVFWJ8Wi04g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750714384; c=relaxed/simple; bh=dljJvUXa4aC1LRyHwjCVcKc+KCk74oj1znmZcgUKyU8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=s93sTDSDuleQ6DN7CU9LtaU08h7ZehzupgVxFYUYiYgFbNjQ6tEp3O1sYp/VQ5iwmO4Xh8wPmMiJJSChIH1+wues0hF0ILi9jTo/KOQJuRY48gc54UMMEGmCZ9CM899C+9ey5Q+nP7p2wqjl8COd5km3MeyI4j9eSoW0gBshAjw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=VzDEjNJ9; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="VzDEjNJ9" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 71F2BC4CEEA; Mon, 23 Jun 2025 21:33:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1750714384; bh=dljJvUXa4aC1LRyHwjCVcKc+KCk74oj1znmZcgUKyU8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=VzDEjNJ9WNv0Ji9Wk857kgo22uAOiIGjWr8HATBUXjAM+JDNx9Q8EsGaYb5Bvvem+ Y9325oCpBxpwRizFkwoacjOl19HnMswKQ48BAdYV8ZwiTPXyTKnAAqLvacNJFOFo3H fX2AHMwRiR3r5R3GoIGER8/VukItHSLMpQB+R/AA= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, syzbot+f0c4a4aba757549ae26c@syzkaller.appspotmail.com, Charalampos Mitrodimas , Tung Nguyen , Paolo Abeni , Sasha Levin Subject: [PATCH 6.1 169/508] net: tipc: fix refcount warning in tipc_aead_encrypt Date: Mon, 23 Jun 2025 15:03:34 +0200 Message-ID: <20250623130649.434738005@linuxfoundation.org> X-Mailer: git-send-email 2.50.0 In-Reply-To: <20250623130645.255320792@linuxfoundation.org> References: <20250623130645.255320792@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Charalampos Mitrodimas [ Upstream commit f29ccaa07cf3d35990f4d25028cc55470d29372b ] syzbot reported a refcount warning [1] caused by calling get_net() on a network namespace that is being destroyed (refcount=0). This happens when a TIPC discovery timer fires during network namespace cleanup. The recently added get_net() call in commit e279024617134 ("net/tipc: fix slab-use-after-free Read in tipc_aead_encrypt_done") attempts to hold a reference to the network namespace. However, if the namespace is already being destroyed, its refcount might be zero, leading to the use-after-free warning. Replace get_net() with maybe_get_net(), which safely checks if the refcount is non-zero before incrementing it. If the namespace is being destroyed, return -ENODEV early, after releasing the bearer reference. [1]: https://lore.kernel.org/all/68342b55.a70a0220.253bc2.0091.GAE@google.com/T/#m12019cf9ae77e1954f666914640efa36d52704a2 Reported-by: syzbot+f0c4a4aba757549ae26c@syzkaller.appspotmail.com Closes: https://lore.kernel.org/all/68342b55.a70a0220.253bc2.0091.GAE@google.com/T/#m12019cf9ae77e1954f666914640efa36d52704a2 Fixes: e27902461713 ("net/tipc: fix slab-use-after-free Read in tipc_aead_encrypt_done") Signed-off-by: Charalampos Mitrodimas Reviewed-by: Tung Nguyen Link: https://patch.msgid.link/20250527-net-tipc-warning-v2-1-df3dc398a047@posteo.net Signed-off-by: Paolo Abeni Signed-off-by: Sasha Levin --- net/tipc/crypto.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/net/tipc/crypto.c b/net/tipc/crypto.c index a9c02fac039b5..17e2b09002853 100644 --- a/net/tipc/crypto.c +++ b/net/tipc/crypto.c @@ -818,7 +818,11 @@ static int tipc_aead_encrypt(struct tipc_aead *aead, struct sk_buff *skb, } /* Get net to avoid freed tipc_crypto when delete namespace */ - get_net(aead->crypto->net); + if (!maybe_get_net(aead->crypto->net)) { + tipc_bearer_put(b); + rc = -ENODEV; + goto exit; + } /* Now, do encrypt */ rc = crypto_aead_encrypt(req); -- 2.39.5