From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5CD5C221543; Mon, 23 Jun 2025 22:26:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750717575; cv=none; b=rJ5jPKwojrmrS1fTJNfrsWnczmNn0GEkzxLzvNh50EQlnQ+ZTxIXRiqVhJBwAJQA4p93fL0eTlyG50nlukSGfHayJmfJuUnCh204diA41OZb9AjXPEYmrTxgj8YlJmAOatHTZ+QrGDAA4xOcomxbX4bEgwB6QMtF06UjlKhojKQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750717575; c=relaxed/simple; bh=mQN1tauPCmBlEbyjuCT5LcTa2vZscAwl12UJE6dDnYQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=lDIQBhXYaX2MNVLooS/UKBFg8e8CEXnUXxOfaqCHOmQ2bxqpl+nY1HQtolFsJ6Z3tDdXu2VkZn/O0yytALxH3r7fNN8LP4QaOdj9KfFVyyyUkVlcS8PGYjii2YZsXxizzgpcQrjAQlLRfzMvhWssTCVVE3GehwT07vG4E0KPH2A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=fVzwOtZF; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="fVzwOtZF" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E8856C4CEEA; Mon, 23 Jun 2025 22:26:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1750717575; bh=mQN1tauPCmBlEbyjuCT5LcTa2vZscAwl12UJE6dDnYQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fVzwOtZF11jkFf/WqKSAggq+/KUN5RBUj1zky2dSPB1fIWA3Ri4A8PD1MhJW3lov3 Vwz/Xg4NgUyxjjInTnl0KScERAAGEIe9bAdVriXR5H2vKSu671SJopObcN0ehKoepo NjPy4CqjXUnhNb12N+1tS2n9rk2FXeAaB4cG7pRc= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, WangYuli , Dmitry Torokhov Subject: [PATCH 6.1 457/508] Input: sparcspkr - avoid unannotated fall-through Date: Mon, 23 Jun 2025 15:08:22 +0200 Message-ID: <20250623130656.377718412@linuxfoundation.org> X-Mailer: git-send-email 2.50.0 In-Reply-To: <20250623130645.255320792@linuxfoundation.org> References: <20250623130645.255320792@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: WangYuli commit 8b1d858cbd4e1800e9336404ba7892b5a721230d upstream. Fix follow warnings with clang-21i (and reformat for clarity): drivers/input/misc/sparcspkr.c:78:3: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough] 78 | case SND_TONE: break; | ^ drivers/input/misc/sparcspkr.c:78:3: note: insert 'break;' to avoid fall-through 78 | case SND_TONE: break; | ^ | break; drivers/input/misc/sparcspkr.c:113:3: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough] 113 | case SND_TONE: break; | ^ drivers/input/misc/sparcspkr.c:113:3: note: insert 'break;' to avoid fall-through 113 | case SND_TONE: break; | ^ | break; 2 warnings generated. Signed-off-by: WangYuli Link: https://lore.kernel.org/r/6730E40353C76908+20250415052439.155051-1-wangyuli@uniontech.com Signed-off-by: Dmitry Torokhov Signed-off-by: Greg Kroah-Hartman --- drivers/input/misc/sparcspkr.c | 22 ++++++++++++++++------ 1 file changed, 16 insertions(+), 6 deletions(-) --- a/drivers/input/misc/sparcspkr.c +++ b/drivers/input/misc/sparcspkr.c @@ -74,9 +74,14 @@ static int bbc_spkr_event(struct input_d return -1; switch (code) { - case SND_BELL: if (value) value = 1000; - case SND_TONE: break; - default: return -1; + case SND_BELL: + if (value) + value = 1000; + break; + case SND_TONE: + break; + default: + return -1; } if (value > 20 && value < 32767) @@ -112,9 +117,14 @@ static int grover_spkr_event(struct inpu return -1; switch (code) { - case SND_BELL: if (value) value = 1000; - case SND_TONE: break; - default: return -1; + case SND_BELL: + if (value) + value = 1000; + break; + case SND_TONE: + break; + default: + return -1; } if (value > 20 && value < 32767)