From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0B9214C7F; Mon, 23 Jun 2025 13:18:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750684690; cv=none; b=G5kgb42ntNqHGSSDfPfghmDs5ftcQJcpU+LPo985QVmAdI39scVW53sod47JLdG1z30U8tDueUfkU8bYuC9Fam5XKyUkLOZW7GFwPt5NiTanl/p4wmVUfuHA/lcmTKcL3cyGamyz6/awONtqc7Yo2GUp8vELT98XPO+cDIA6VAU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750684690; c=relaxed/simple; bh=wdSMNxUmgStaBVf+ZrR1o2xLhwgJoAr/plpufmrqUSk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Xq+JYWXs6//ATm4cyxi0XHfhQkPlBisoG4LCwTsw0jbUJTOPZtxy0xWfPz2XCquDZQM6sC/Bw/N75vldtaEANXTlGUJbILV9LQAlM/PH8K0bx0Ce32Si+wOSTF/+7NNrDWU1iwOYKt/vlXXtnUItb40a1eCznXHBji2QwYQv68E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=iWXWJrNB; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="iWXWJrNB" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 38726C4CEEA; Mon, 23 Jun 2025 13:18:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1750684689; bh=wdSMNxUmgStaBVf+ZrR1o2xLhwgJoAr/plpufmrqUSk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=iWXWJrNBfiBVkagrGnzOkv9Y/BrR1hjUPO3ptqFj6+TQhQggjk5tlCB2M2s3GonEy 3JAJK2P6dlcX6dam1jouG+c2SmK+14jvIwQrESEAOffxErE9BM33DHVyaUbo5qqdD2 IrfTv6BU681GPId8180qhHIxQbBdwcZ8Ylr2tbBM= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Manivannan Sadhasivam , Lakshmi Sowjanya D , Md Sadre Alam , Miquel Raynal Subject: [PATCH 6.15 154/592] mtd: rawnand: qcom: Fix last codeword read in qcom_param_page_type_exec() Date: Mon, 23 Jun 2025 15:01:52 +0200 Message-ID: <20250623130703.946851479@linuxfoundation.org> X-Mailer: git-send-email 2.50.0 In-Reply-To: <20250623130700.210182694@linuxfoundation.org> References: <20250623130700.210182694@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Md Sadre Alam commit 47bddabbf69da50999ec68be92b58356c687e1d6 upstream. For QPIC V2 onwards there is a separate register to read last code word "QPIC_NAND_READ_LOCATION_LAST_CW_n". qcom_param_page_type_exec() is used to read only one code word If it configures the number of code words to 1 in QPIC_NAND_DEV0_CFG0 register then QPIC controller thinks its reading the last code word, since we are having separate register to read the last code word, we have to configure "QPIC_NAND_READ_LOCATION_LAST_CW_n" register to fetch data from QPIC buffer to system memory. Without this change page read was failing with timeout error / # hexdump -C /dev/mtd1 [ 129.206113] qcom-nandc 1cc8000.nand-controller: failure to read page/oob hexdump: /dev/mtd1: Connection timed out This issue only seen on SDX targets since SDX target used QPICv2. But same working on IPQ targets since IPQ used QPICv1. Cc: stable@vger.kernel.org Fixes: 89550beb098e ("mtd: rawnand: qcom: Implement exec_op()") Reviewed-by: Manivannan Sadhasivam Tested-by: Lakshmi Sowjanya D Signed-off-by: Md Sadre Alam Signed-off-by: Miquel Raynal Signed-off-by: Greg Kroah-Hartman --- drivers/mtd/nand/raw/qcom_nandc.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) --- a/drivers/mtd/nand/raw/qcom_nandc.c +++ b/drivers/mtd/nand/raw/qcom_nandc.c @@ -1863,7 +1863,12 @@ static int qcom_param_page_type_exec(str const struct nand_op_instr *instr = NULL; unsigned int op_id = 0; unsigned int len = 0; - int ret; + int ret, reg_base; + + reg_base = NAND_READ_LOCATION_0; + + if (nandc->props->qpic_version2) + reg_base = NAND_READ_LOCATION_LAST_CW_0; ret = qcom_parse_instructions(chip, subop, &q_op); if (ret) @@ -1915,7 +1920,10 @@ static int qcom_param_page_type_exec(str op_id = q_op.data_instr_idx; len = nand_subop_get_data_len(subop, op_id); - nandc_set_read_loc(chip, 0, 0, 0, len, 1); + if (nandc->props->qpic_version2) + nandc_set_read_loc_last(chip, reg_base, 0, len, 1); + else + nandc_set_read_loc_first(chip, reg_base, 0, len, 1); if (!nandc->props->qpic_version2) { qcom_write_reg_dma(nandc, &nandc->regs->vld, NAND_DEV_CMD_VLD, 1, 0);