From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4C9F61EE7C6; Mon, 23 Jun 2025 21:30:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750714211; cv=none; b=b20MuAF1uybNXv4laYzx4v3QAfKZoNNwwLeRGou909EWPHyRIiJzus4P5cjgXgD7e1vF5jbZ+vKKaNzGrIbjrArj7Lu1bJsApbb8Eezfn6ecd29heQ7RAl3M5T8bWUNutuLFYvu8XjJWS0WwHjl2YhFdl/NGMqRwr80p6OgslRQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750714211; c=relaxed/simple; bh=R1gdINfvX4q0xlwtjdE0suaY9cJK/Hqb+lxAM59zk1k=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=HkaPIk6UYQVfKOc1Ys4cNuMePH1C0WCREffM73ZDC2BvMo+jLwXst8QV1ISEuu8usL/OXfJiu+hJ84XJH2WBG5eF57hvXyFCTq2XBVVpyrMc5jeAabLoiauSkNn32WdQh67XRp9/k3BLZvUe+06cZpBRrAWho7u0o/qoMRzzFyU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=xrwsQ25w; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="xrwsQ25w" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D5152C4CEEA; Mon, 23 Jun 2025 21:30:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1750714211; bh=R1gdINfvX4q0xlwtjdE0suaY9cJK/Hqb+lxAM59zk1k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=xrwsQ25wfDJ9hFVLj5ns3usBMltdkXTJ25pMopVXK1sgYioi8wW6J/qlImZU64fm8 xHn20Q1k3EoytYZ42UbyNBKzNYE6bFWNzlvEaxjSzDl7IG7sVSNc7hVxp/q6M0CCXo DJH0f6asAKDjtYlIzdHHodHnb/dRcsZhWOAaya4o= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Chao Yu , Jaegeuk Kim , Sasha Levin Subject: [PATCH 6.15 376/592] f2fs: fix to bail out in get_new_segment() Date: Mon, 23 Jun 2025 15:05:34 +0200 Message-ID: <20250623130709.383509522@linuxfoundation.org> X-Mailer: git-send-email 2.50.0 In-Reply-To: <20250623130700.210182694@linuxfoundation.org> References: <20250623130700.210182694@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Chao Yu [ Upstream commit bb5eb8a5b222fa5092f60d5555867a05ebc3bdf2 ] ------------[ cut here ]------------ WARNING: CPU: 3 PID: 579 at fs/f2fs/segment.c:2832 new_curseg+0x5e8/0x6dc pc : new_curseg+0x5e8/0x6dc Call trace: new_curseg+0x5e8/0x6dc f2fs_allocate_data_block+0xa54/0xe28 do_write_page+0x6c/0x194 f2fs_do_write_node_page+0x38/0x78 __write_node_page+0x248/0x6d4 f2fs_sync_node_pages+0x524/0x72c f2fs_write_checkpoint+0x4bc/0x9b0 __checkpoint_and_complete_reqs+0x80/0x244 issue_checkpoint_thread+0x8c/0xec kthread+0x114/0x1bc ret_from_fork+0x10/0x20 get_new_segment() detects inconsistent status in between free_segmap and free_secmap, let's record such error into super block, and bail out get_new_segment() instead of continue using the segment. Signed-off-by: Chao Yu Signed-off-by: Jaegeuk Kim Signed-off-by: Sasha Levin --- fs/f2fs/segment.c | 6 +++++- include/linux/f2fs_fs.h | 1 + 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c index 41ca73622c8d4..c5d29c58f3d3e 100644 --- a/fs/f2fs/segment.c +++ b/fs/f2fs/segment.c @@ -2836,7 +2836,11 @@ static int get_new_segment(struct f2fs_sb_info *sbi, } got_it: /* set it as dirty segment in free segmap */ - f2fs_bug_on(sbi, test_bit(segno, free_i->free_segmap)); + if (test_bit(segno, free_i->free_segmap)) { + ret = -EFSCORRUPTED; + f2fs_stop_checkpoint(sbi, false, STOP_CP_REASON_CORRUPTED_FREE_BITMAP); + goto out_unlock; + } /* no free section in conventional device or conventional zone */ if (new_sec && pinning && diff --git a/include/linux/f2fs_fs.h b/include/linux/f2fs_fs.h index c24f8bc01045d..5206d63b33860 100644 --- a/include/linux/f2fs_fs.h +++ b/include/linux/f2fs_fs.h @@ -78,6 +78,7 @@ enum stop_cp_reason { STOP_CP_REASON_UPDATE_INODE, STOP_CP_REASON_FLUSH_FAIL, STOP_CP_REASON_NO_SEGMENT, + STOP_CP_REASON_CORRUPTED_FREE_BITMAP, STOP_CP_REASON_MAX, }; -- 2.39.5