stable patch 42fac18 missing from linux-6.6

stable patch 42fac18 missing from linux-6.6

[Alex Lyakas]

Greetings,

The following patch [1]:
"42fac18 btrfs: check delayed refs when we're checking if a ref exists"
has been marked as
"CC: stable@vger.kernel.org # 5.4+"
but I do not see that it has been backported to linux-6.6.y branch.

Can this patch be picked up in the next version of linux-6.6 please?

Thanks,
Alex.

[1]
commit 42fac187b5c746227c92d024f1caf33bc1d337e4
Author: Josef Bacik <josef@toxicpanda.com>
Date:   Thu Apr 11 16:41:20 2024 -0400

    btrfs: check delayed refs when we're checking if a ref exists

    In the patch 78c52d9eb6b7 ("btrfs: check for refs on snapshot delete
    resume") I added some code to handle file systems that had been
    corrupted by a bug that incorrectly skipped updating the drop progress
    key while dropping a snapshot.  This code would check to see if we had
    already deleted our reference for a child block, and skip the deletion
    if we had already.
...
    Fixes: 78c52d9eb6b7 ("btrfs: check for refs on snapshot delete resume")
    CC: stable@vger.kernel.org # 5.4+
    Reviewed-by: Filipe Manana <fdmanana@suse.com>
    Signed-off-by: Josef Bacik <josef@toxicpanda.com>
    Signed-off-by: David Sterba <dsterba@suse.com>

Re: stable patch 42fac18 missing from linux-6.6

[Greg KH]

On Sun, Jun 15, 2025 at 06:36:44PM +0300, Alex Lyakas wrote:
> Greetings,
> 
> The following patch [1]:
> "42fac18 btrfs: check delayed refs when we're checking if a ref exists"
> has been marked as
> "CC: stable@vger.kernel.org # 5.4+"
> but I do not see that it has been backported to linux-6.6.y branch.
> 
> Can this patch be picked up in the next version of linux-6.6 please?

It does not apply cleanly there at all, which is why we did not apply it
already.  How did you test this change works in this tree?

If you want it here, great, can you provide a backported and tested
version?

thanks,

greg k-h

Re: stable patch 42fac18 missing from linux-6.6

[Alex Lyakas]

On Mon, Jun 23, 2025 at 9:35 AM Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Sun, Jun 15, 2025 at 06:36:44PM +0300, Alex Lyakas wrote:
> > Greetings,
> >
> > The following patch [1]:
> > "42fac18 btrfs: check delayed refs when we're checking if a ref exists"
> > has been marked as
> > "CC: stable@vger.kernel.org # 5.4+"
> > but I do not see that it has been backported to linux-6.6.y branch.
> >
> > Can this patch be picked up in the next version of linux-6.6 please?
>
> It does not apply cleanly there at all, which is why we did not apply it
> already.  How did you test this change works in this tree?
Hi Greg,
Thank you for your response.

>
> If you want it here, great, can you provide a backported and tested
> version?
I backported the patch and tested it to the best of my ability. I was
able to test the part where the reference exists in the extent tree,
which means the patch doesn't break existing functionality. However, I
was not able to test the case where we only have the delayed
reference.

Please let me know if this is still good enough, so that I can post
this patch for review here (or on linux-stable-commits?).

Thanks,
Alex.


>
> thanks,
>
> greg k-h

Re: stable patch 42fac18 missing from linux-6.6

[Greg KH]

On Mon, Jun 23, 2025 at 12:07:42PM +0300, Alex Lyakas wrote:
> On Mon, Jun 23, 2025 at 9:35 AM Greg KH <gregkh@linuxfoundation.org> wrote:
> >
> > On Sun, Jun 15, 2025 at 06:36:44PM +0300, Alex Lyakas wrote:
> > > Greetings,
> > >
> > > The following patch [1]:
> > > "42fac18 btrfs: check delayed refs when we're checking if a ref exists"
> > > has been marked as
> > > "CC: stable@vger.kernel.org # 5.4+"
> > > but I do not see that it has been backported to linux-6.6.y branch.
> > >
> > > Can this patch be picked up in the next version of linux-6.6 please?
> >
> > It does not apply cleanly there at all, which is why we did not apply it
> > already.  How did you test this change works in this tree?
> Hi Greg,
> Thank you for your response.
> 
> >
> > If you want it here, great, can you provide a backported and tested
> > version?
> I backported the patch and tested it to the best of my ability. I was
> able to test the part where the reference exists in the extent tree,
> which means the patch doesn't break existing functionality. However, I
> was not able to test the case where we only have the delayed
> reference.

Then it's hard to know if it works :(

> Please let me know if this is still good enough, so that I can post
> this patch for review here (or on linux-stable-commits?).

linux-stable-commits is just for when we apply stuff to the tree,
stable@vger.kernel.org is for submitting new stuff.

If you think your backport is correct, sure, submit it, it's your call.

thanks,

greg k-h