[PATCH 6.6] Revert "cpufreq: tegra186: Share policy per cluster"

[PATCH 6.6] Revert "cpufreq: tegra186: Share policy per cluster"

[Jon Hunter]

This reverts commit ac64f0e893ff370c4d3426c83c1bd0acae75bcf4 which is
upstream commit be4ae8c19492cd6d5de61ccb34ffb3f5ede5eec8.

This commit is causing a suspend regression on Tegra186 Jetson TX2 with
Linux v6.12.y kernels. This is not seen with Linux v6.15 that includes
this change but indicates that there are there changes missing.
Therefore, revert this change.

Fixes: ac64f0e893ff ("cpufreq: tegra186: Share policy per cluster")
Link: https://lore.kernel.org/linux-tegra/bf1dabf7-0337-40e9-8b8e-4e93a0ffd4cc@nvidia.com/
Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
---
 drivers/cpufreq/tegra186-cpufreq.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/drivers/cpufreq/tegra186-cpufreq.c b/drivers/cpufreq/tegra186-cpufreq.c
index 4e5b6f9a56d1..7b8fcfa55038 100644
--- a/drivers/cpufreq/tegra186-cpufreq.c
+++ b/drivers/cpufreq/tegra186-cpufreq.c
@@ -73,18 +73,11 @@ static int tegra186_cpufreq_init(struct cpufreq_policy *policy)
 {
 	struct tegra186_cpufreq_data *data = cpufreq_get_driver_data();
 	unsigned int cluster = data->cpus[policy->cpu].bpmp_cluster_id;
-	u32 cpu;
 
 	policy->freq_table = data->clusters[cluster].table;
 	policy->cpuinfo.transition_latency = 300 * 1000;
 	policy->driver_data = NULL;
 
-	/* set same policy for all cpus in a cluster */
-	for (cpu = 0; cpu < ARRAY_SIZE(tegra186_cpus); cpu++) {
-		if (data->cpus[cpu].bpmp_cluster_id == cluster)
-			cpumask_set_cpu(cpu, policy->cpus);
-	}
-
 	return 0;
 }
 
-- 
2.43.0

Re: [PATCH 6.6] Revert "cpufreq: tegra186: Share policy per cluster"

[Greg Kroah-Hartman]

On Thu, Jun 05, 2025 at 01:53:41PM +0100, Jon Hunter wrote:
> This reverts commit ac64f0e893ff370c4d3426c83c1bd0acae75bcf4 which is
> upstream commit be4ae8c19492cd6d5de61ccb34ffb3f5ede5eec8.
> 
> This commit is causing a suspend regression on Tegra186 Jetson TX2 with
> Linux v6.12.y kernels. This is not seen with Linux v6.15 that includes
> this change but indicates that there are there changes missing.
> Therefore, revert this change.

But this is the 6.6.y tree, not 6.12.y tree.  So is this still a
regression in 6.6.y?

thanks,

greg k-h

Re: [PATCH 6.6] Revert "cpufreq: tegra186: Share policy per cluster"

[Greg Kroah-Hartman]

On Mon, Jun 23, 2025 at 08:36:15AM +0200, Greg Kroah-Hartman wrote:
> On Thu, Jun 05, 2025 at 01:53:41PM +0100, Jon Hunter wrote:
> > This reverts commit ac64f0e893ff370c4d3426c83c1bd0acae75bcf4 which is
> > upstream commit be4ae8c19492cd6d5de61ccb34ffb3f5ede5eec8.
> > 
> > This commit is causing a suspend regression on Tegra186 Jetson TX2 with
> > Linux v6.12.y kernels. This is not seen with Linux v6.15 that includes
> > this change but indicates that there are there changes missing.
> > Therefore, revert this change.
> 
> But this is the 6.6.y tree, not 6.12.y tree.  So is this still a
> regression in 6.6.y?

Ah, nevermind, I'll just edit this by hand :)

Re: [PATCH 6.6] Revert "cpufreq: tegra186: Share policy per cluster"

[Jon Hunter]

On 23/06/2025 09:06, Greg Kroah-Hartman wrote:
> On Mon, Jun 23, 2025 at 08:36:15AM +0200, Greg Kroah-Hartman wrote:
>> On Thu, Jun 05, 2025 at 01:53:41PM +0100, Jon Hunter wrote:
>>> This reverts commit ac64f0e893ff370c4d3426c83c1bd0acae75bcf4 which is
>>> upstream commit be4ae8c19492cd6d5de61ccb34ffb3f5ede5eec8.
>>>
>>> This commit is causing a suspend regression on Tegra186 Jetson TX2 with
>>> Linux v6.12.y kernels. This is not seen with Linux v6.15 that includes
>>> this change but indicates that there are there changes missing.
>>> Therefore, revert this change.
>>
>> But this is the 6.6.y tree, not 6.12.y tree.  So is this still a
>> regression in 6.6.y?
> 
> Ah, nevermind, I'll just edit this by hand :)


I should have been clearer in the commit message. The regression was 
only seen for v6.12.y, but we decided to revert for older versions too 
for consistency [0].

Jon

[0] 
https://lore.kernel.org/linux-tegra/2025060413-entrust-unsold-7bfd@gregkh/

-- 
nvpublic