From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E9B3823BCF2 for ; Mon, 30 Jun 2025 11:23:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751282631; cv=none; b=FcgfDYwRjfsM67BdjS/qWXA6m/CAjhjQmTT+1kWY1cVcp61j8QrObeV6/F6p0eCtc+1ru503Z9jEkmuS1coJVBQyzRXfoJ/lPdcpI8b5JqetSquoyNYlQVctjwLgp4ocvEY25d8b0V1pxOxTr2QozUIHJZ2AEh/t8kN1jtgevQs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751282631; c=relaxed/simple; bh=ccqPzB0ZYUu1anuTWY/uSCIzidSTqI3JaFEy4Va5QHM=; h=Subject:To:Cc:From:Date:Message-ID:MIME-Version:Content-Type; b=e3bDL7CuEgf6d7DWwnQImMX7VjkOuwzVez4UHS5HOIvf0VSwCESNvT0b0rXAn+2oCDRc3UUOEQob/bIwuYAPP6XN5o9lmx08c0hLOhNOcb54dECY/WmdgJaigQ33Y67Bz3H8Y9Gnyi9oMemX8OKJZQxUTEbFa0dvlKZqGHbe7IA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=bRGu6vqf; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="bRGu6vqf" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 48488C4CEF3; Mon, 30 Jun 2025 11:23:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1751282630; bh=ccqPzB0ZYUu1anuTWY/uSCIzidSTqI3JaFEy4Va5QHM=; h=Subject:To:Cc:From:Date:From; b=bRGu6vqf/F65QIGeq6dR673+hn5TfVmQ4pvVPD7ipP8+WTA3248XJz3q3SShoSxRh Idqg34TvKEWmEhdeJEHVDJs2Dkodkw8WnBiqsTAOzFKu/SQfQNngWTVYXk1SIMGlhd 8rSOJ8Y+/5sSNR+rjLsUk9gr7ftJku+PWzIp3JAs= Subject: FAILED: patch "[PATCH] drm/bridge: cdns-dsi: Fix phy de-init and flag it so" failed to apply to 5.10-stable tree To: a-bhatia1@ti.com,aradhya.bhatia@linux.dev,dmitry.baryshkov@linaro.org,dmitry.baryshkov@oss.qualcomm.com,tomi.valkeinen@ideasonboard.com Cc: From: Date: Mon, 30 Jun 2025 13:23:39 +0200 Message-ID: <2025063039-bladder-suitor-bfad@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit The patch below does not apply to the 5.10-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-5.10.y git checkout FETCH_HEAD git cherry-pick -x fd2611c13f69cbbc6b81d9fc7502abf4f7031d21 # git commit -s git send-email --to '' --in-reply-to '2025063039-bladder-suitor-bfad@gregkh' --subject-prefix 'PATCH 5.10.y' HEAD^.. Possible dependencies: thanks, greg k-h ------------------ original commit in Linus's tree ------------------ >From fd2611c13f69cbbc6b81d9fc7502abf4f7031d21 Mon Sep 17 00:00:00 2001 From: Aradhya Bhatia Date: Sat, 29 Mar 2025 17:09:13 +0530 Subject: [PATCH] drm/bridge: cdns-dsi: Fix phy de-init and flag it so The driver code doesn't have a Phy de-initialization path as yet, and so it does not clear the phy_initialized flag while suspending. This is a problem because after resume the driver looks at this flag to determine if a Phy re-initialization is required or not. It is in fact required because the hardware is resuming from a suspend, but the driver does not carry out any re-initialization causing the D-Phy to not work at all. Call the counterparts of phy_init() and phy_power_on(), that are phy_exit() and phy_power_off(), from _bridge_post_disable(), and clear the flags so that the Phy can be initialized again when required. Fixes: fced5a364dee ("drm/bridge: cdns: Convert to phy framework") Cc: stable@vger.kernel.org Reviewed-by: Dmitry Baryshkov Reviewed-by: Tomi Valkeinen Tested-by: Tomi Valkeinen Signed-off-by: Aradhya Bhatia Signed-off-by: Aradhya Bhatia Link: https://lore.kernel.org/r/20250329113925.68204-3-aradhya.bhatia@linux.dev Signed-off-by: Dmitry Baryshkov diff --git a/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c b/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c index 1cfe17865b06..3b15528713fe 100644 --- a/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c +++ b/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c @@ -683,6 +683,11 @@ static void cdns_dsi_bridge_atomic_post_disable(struct drm_bridge *bridge, struct cdns_dsi_input *input = bridge_to_cdns_dsi_input(bridge); struct cdns_dsi *dsi = input_to_dsi(input); + dsi->phy_initialized = false; + dsi->link_initialized = false; + phy_power_off(dsi->dphy); + phy_exit(dsi->dphy); + pm_runtime_put(dsi->base.dev); } @@ -1166,7 +1171,6 @@ static int __maybe_unused cdns_dsi_suspend(struct device *dev) clk_disable_unprepare(dsi->dsi_sys_clk); clk_disable_unprepare(dsi->dsi_p_clk); reset_control_assert(dsi->dsi_p_rst); - dsi->link_initialized = false; return 0; }