From: Greg KH <gregkh@linuxfoundation.org>
To: Brendan Jackman <jackmanb@google.com>
Cc: stable@vger.kernel.org, Corey Minyard <minyard@acm.org>,
Corey Minyard <cminyard@mvista.com>,
openipmi-developer@lists.sourceforge.net,
linux-kernel@vger.kernel.org,
Dan Carpenter <dan.carpenter@linaro.org>,
Corey Minyard <corey@minyard.net>
Subject: Re: [PATCH stable] ipmi:msghandler: Fix potential memory corruption in ipmi_create_user()
Date: Mon, 30 Jun 2025 20:10:13 +0200 [thread overview]
Message-ID: <2025063054-abridge-conclude-3dad@gregkh> (raw)
In-Reply-To: <20250630-ipmi-fix-v1-1-2d496de3c856@google.com>
On Mon, Jun 30, 2025 at 05:09:02PM +0000, Brendan Jackman wrote:
> From: Dan Carpenter <dan.carpenter@linaro.org>
>
> commit fa332f5dc6fc662ad7d3200048772c96b861cf6b upstream
>
> The "intf" list iterator is an invalid pointer if the correct
> "intf->intf_num" is not found. Calling atomic_dec(&intf->nr_users) on
> and invalid pointer will lead to memory corruption.
>
> We don't really need to call atomic_dec() if we haven't called
> atomic_add_return() so update the if (intf->in_shutdown) path as well.
>
> Fixes: 8e76741c3d8b ("ipmi: Add a limit on the number of users that may use IPMI")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> Message-ID: <aBjMZ8RYrOt6NOgi@stanley.mountain>
> Signed-off-by: Corey Minyard <corey@minyard.net>
> Signed-off-by: Brendan Jackman <jackmanb@google.com>
> ---
> I have tested this in 6.12 with Google's platform drivers added to
> reproduce the bug. The bug causes the panic notifier chain to get
> corrupted leading to a crash. With the fix this goes away.
>
> Applies to 6.6 too but I haven't tested it there.
So what kernels are you wanting this to be applied to?
thanks,
greg k-h
next prev parent reply other threads:[~2025-06-30 18:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-30 17:09 [PATCH stable] ipmi:msghandler: Fix potential memory corruption in ipmi_create_user() Brendan Jackman
2025-06-30 18:10 ` Greg KH [this message]
2025-07-01 9:52 ` Brendan Jackman
2025-07-01 10:14 ` Greg KH
2025-07-01 11:29 ` Brendan Jackman
2025-07-01 1:15 ` Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025063054-abridge-conclude-3dad@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=cminyard@mvista.com \
--cc=corey@minyard.net \
--cc=dan.carpenter@linaro.org \
--cc=jackmanb@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=minyard@acm.org \
--cc=openipmi-developer@lists.sourceforge.net \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox