From: Sasha Levin <sashal@kernel.org>
To: stable@vger.kernel.org
Cc: Jeongjun Park <aha310510@gmail.com>, Sasha Levin <sashal@kernel.org>
Subject: Re: [PATCH 6.15.y] mm/vmalloc: fix data race in show_numa_info()
Date: Thu, 3 Jul 2025 14:35:03 -0400 [thread overview]
Message-ID: <20250703111959-3ad2d7e72d03f7be@stable.kernel.org> (raw)
In-Reply-To: <20250702153312.351080-1-aha310510@gmail.com>
[ Sasha's backport helper bot ]
Hi,
✅ All tests passed successfully. No issues detected.
No action required from the submitter.
The upstream commit SHA1 provided is correct: 5c5f0468d172ddec2e333d738d2a1f85402cf0bc
Note: The patch differs from the upstream commit:
---
1: 5c5f0468d172d ! 1: 99ac6d1cf98b4 mm/vmalloc: fix data race in show_numa_info()
@@ Metadata
## Commit message ##
mm/vmalloc: fix data race in show_numa_info()
+ commit 5c5f0468d172ddec2e333d738d2a1f85402cf0bc upstream.
+
The following data-race was found in show_numa_info():
==================================================================
@@ Commit message
m->private, vmalloc_info_show() should allocate the heap.
Link: https://lkml.kernel.org/r/20250508165620.15321-1-aha310510@gmail.com
- Fixes: 8e1d743f2c26 ("mm: vmalloc: support multiple nodes in vmallocinfo")
+ Fixes: 8e1d743 ("mm: vmalloc: support multiple nodes in vmallocinfo")
Signed-off-by: Jeongjun Park <aha310510@gmail.com>
Suggested-by: Eric Dumazet <edumazet@google.com>
Suggested-by: Andrew Morton <akpm@linux-foundation.org>
@@ mm/vmalloc.c: bool vmalloc_dump_obj(void *object)
static void show_purge_info(struct seq_file *m)
@@ mm/vmalloc.c: static int vmalloc_info_show(struct seq_file *m, void *p)
- struct vmap_node *vn;
struct vmap_area *va;
struct vm_struct *v;
+ int i;
+ unsigned int *counters;
+
+ if (IS_ENABLED(CONFIG_NUMA))
+ counters = kmalloc(nr_node_ids * sizeof(unsigned int), GFP_KERNEL);
- for_each_vmap_node(vn) {
- spin_lock(&vn->busy.lock);
+ for (i = 0; i < nr_vmap_nodes; i++) {
+ vn = &vmap_nodes[i];
@@ mm/vmalloc.c: static int vmalloc_info_show(struct seq_file *m, void *p)
}
---
Results of testing on various branches:
| Branch | Patch Apply | Build Test |
|---------------------------|-------------|------------|
| stable/linux-6.15.y | Success | Success |
prev parent reply other threads:[~2025-07-03 18:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-02 15:33 [PATCH 6.15.y] mm/vmalloc: fix data race in show_numa_info() Jeongjun Park
2025-07-03 10:06 ` Greg KH
2025-07-03 12:49 ` Jeongjun Park
2025-07-03 18:35 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250703111959-3ad2d7e72d03f7be@stable.kernel.org \
--to=sashal@kernel.org \
--cc=aha310510@gmail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox