From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CE0F02C3262; Thu, 3 Jul 2025 15:13:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751555616; cv=none; b=RmyUPBk0hho36gCSaPh4HBDqqaYDulYwlJ+ApN7mBYpsz+GcjDqyc/UB+hn3AJGkvpM/rdi2tJLQ/8B38sxH7TZnZAwcePqdqhbMt5dLXWFlZAsiKUiKcneQxv3xEQcSpYKeWOTvTNfTYMVr01Lk5c6pPYgksW9jYP3hKeLgo0U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751555616; c=relaxed/simple; bh=2VjsJ8BbFxv/ilqGsPWLFvPAnwHhnfaIok9U4r5Vdrc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=cmJmc2SVZmVuuFOrdvsQj82C0ro+xp5SgrPSDoeE3nIX8ZCn3ZHvSW4D3Xg3GA44uzXj1mm2nfWMtqDVVblvhjQWQ+Fy3h+05ks22UZo7QUf+v87fuHSjpdYJqHrLyah6XWTRtR31gCnHY9Xo4Y1jxW3z6QZtTiXJkCp6O0bkD4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=d+DwA537; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="d+DwA537" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3F1F0C4CEE3; Thu, 3 Jul 2025 15:13:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1751555616; bh=2VjsJ8BbFxv/ilqGsPWLFvPAnwHhnfaIok9U4r5Vdrc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=d+DwA537WZAtCc0uZ3SPCBUpj6k9pU8kpWMDR3zDHpfZUQunm02D5dn4B4kK0+R0M 3sUoxANOakgxD20eB2iFdshzxKTLMsnSh1G+1susTMpxd2K7hSc1l+eXxHZggh4t/B phvK2Tmo3pJr5vJ5zV2vdLURyvBjoC3YfEApoAs4= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, =?UTF-8?q?Amadeusz=20S=C5=82awi=C5=84ski?= , Cezary Rojewski , Takashi Iwai , Sasha Levin Subject: [PATCH 6.6 040/139] ALSA: hda: Ignore unsol events for cards being shut down Date: Thu, 3 Jul 2025 16:41:43 +0200 Message-ID: <20250703143942.746360522@linuxfoundation.org> X-Mailer: git-send-email 2.50.0 In-Reply-To: <20250703143941.182414597@linuxfoundation.org> References: <20250703143941.182414597@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Cezary Rojewski [ Upstream commit 3f100f524e75586537e337b34d18c8d604b398e7 ] For the classic snd_hda_intel driver, codec->card and bus->card point to the exact same thing. When snd_card_diconnect() fires, bus->shutdown is set thanks to azx_dev_disconnect(). card->shutdown is already set when that happens but both provide basically the same functionality. For the DSP snd_soc_avs driver where multiple codecs are located on multiple cards, bus->shutdown 'shortcut' is not sufficient. One codec card may be unregistered while other codecs are still operational. Proper check in form of card->shutdown must be used to verify whether the codec's card is being shut down. Reviewed-by: Amadeusz Sławiński Signed-off-by: Cezary Rojewski Link: https://patch.msgid.link/20250530141309.2943404-1-cezary.rojewski@intel.com Signed-off-by: Takashi Iwai Signed-off-by: Sasha Levin --- sound/pci/hda/hda_bind.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/pci/hda/hda_bind.c b/sound/pci/hda/hda_bind.c index b7ca2a83fbb08..95786bdadfe6a 100644 --- a/sound/pci/hda/hda_bind.c +++ b/sound/pci/hda/hda_bind.c @@ -44,7 +44,7 @@ static void hda_codec_unsol_event(struct hdac_device *dev, unsigned int ev) struct hda_codec *codec = container_of(dev, struct hda_codec, core); /* ignore unsol events during shutdown */ - if (codec->bus->shutdown) + if (codec->card->shutdown || codec->bus->shutdown) return; /* ignore unsol events during system suspend/resume */ -- 2.39.5