From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E26BB2E54BF; Thu, 3 Jul 2025 15:17:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751555839; cv=none; b=jsOSwqwWZ3sfl8WvrG6mGy+dwTsHruJdCdxQUmMOuCXsKz9vl9kzK77Oe/oPNpphXlIJkQ+ayw9KU1tT3kCYVbhZrGFwf2qcZXd22DpKjj8OjUuNopllBuoeD2Sh+nu34MEXrRvKjApGTeDVUXXm7rrP7D/UBkgS25m2yqKfkfw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751555839; c=relaxed/simple; bh=X/433jfgped8gGnnfhmuPwN7IBymV7Cspat2RVCAHHc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=sWFEEgwnrrP7479h9b/laGTtwF/t5GmeUSkZ8rAl2kNVoN0rByWS4UQb4pwV8dyxVHZXmIviwcJO2Wh9cWWA3pUI8z3R6tHxzywn5ESUMuMRLg5EBPhWrGsCimLAn8/8xaXhGSKcQh0rBtSwW54s0gqdouJyPOi60ttBgJAVM7M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=2mTxwt+Z; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="2mTxwt+Z" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0F798C4CEE3; Thu, 3 Jul 2025 15:17:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1751555837; bh=X/433jfgped8gGnnfhmuPwN7IBymV7Cspat2RVCAHHc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=2mTxwt+ZCRSie9kjpw5vLmOHZymS5fys2az8NjdYRTEYUvlwzjYQqpN8i1Yd0ADQ4 cqfBQ3D2hvsLYd1iluWzN6jMqVbgI4RblwKfCXx9k8cr7hx9ZlVfz8UVE2JhFlB4JF poErOM5J94Ob1wmmyYaiGxqCLnOI2YzFETiIvC4Y= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Ping Cheng , Qasim Ijaz , Jiri Kosina Subject: [PATCH 6.6 105/139] HID: wacom: fix memory leak on kobject creation failure Date: Thu, 3 Jul 2025 16:42:48 +0200 Message-ID: <20250703143945.283601381@linuxfoundation.org> X-Mailer: git-send-email 2.50.0 In-Reply-To: <20250703143941.182414597@linuxfoundation.org> References: <20250703143941.182414597@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Qasim Ijaz commit 5ae416c5b1e2e816aee7b3fc8347adf70afabb4c upstream. During wacom_initialize_remotes() a fifo buffer is allocated with kfifo_alloc() and later a cleanup action is registered during devm_add_action_or_reset() to clean it up. However if the code fails to create a kobject and register it with sysfs the code simply returns -ENOMEM before the cleanup action is registered leading to a memory leak. Fix this by ensuring the fifo is freed when the kobject creation and registration process fails. Fixes: 83e6b40e2de6 ("HID: wacom: EKR: have the wacom resources dynamically allocated") Reviewed-by: Ping Cheng Cc: stable@vger.kernel.org Signed-off-by: Qasim Ijaz Signed-off-by: Jiri Kosina Signed-off-by: Greg Kroah-Hartman --- drivers/hid/wacom_sys.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) --- a/drivers/hid/wacom_sys.c +++ b/drivers/hid/wacom_sys.c @@ -2012,8 +2012,10 @@ static int wacom_initialize_remotes(stru remote->remote_dir = kobject_create_and_add("wacom_remote", &wacom->hdev->dev.kobj); - if (!remote->remote_dir) + if (!remote->remote_dir) { + kfifo_free(&remote->remote_fifo); return -ENOMEM; + } error = sysfs_create_files(remote->remote_dir, remote_unpair_attrs);