From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D7E1C176ADB; Tue, 8 Jul 2025 16:29:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751992189; cv=none; b=nDrecwY9g5CmgRTIF9r9qhMg72sdA7YXqxy+ROFIQAfN15wgBrior3X08u1RhFXceyjHYhZf+RYrTChYgqRd64KBY6ITMriW4XgokZcvutWHy52AdbtidxSvpVGsryeGvIdNC06iiWoiSO0cEZaIitHn45cMGxVl6eeXn2FCHzI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751992189; c=relaxed/simple; bh=YGxdjoUDduBmdgQgDUhDUIZzayRL/g2vyl3tUZucp9I=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=hMIXnTLnbsnwqzwtSF4CrwYisSJy5n7xEuLQotGW1olTN60yeFcm7ClcLCVI4qomAf7lI2nEq+6SMmgi24g8EshoOQhBW21phCLV6jAGmRZVr2kB14Cg8VoCZd9RcZy7+hE4kXm0r4T4TJnuG/lohz2ZH/p3lqXsiGU2BADHKiA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=TjuRVH8r; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="TjuRVH8r" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1E753C4CEED; Tue, 8 Jul 2025 16:29:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1751992189; bh=YGxdjoUDduBmdgQgDUhDUIZzayRL/g2vyl3tUZucp9I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=TjuRVH8rGZwyL9mxyHSRYr5W9IyqwJctrmvBHHG0FiuaeSw9/2G9SP2DsEpwRKk25 IzxMAWkH9G7wbwO6AUi4l1tMGm7082QzWMGs5mrUWAH2IhHOXpjWvUEBZBnkeIjh1F GY2ViDwDeDA5LqTGTFNbtJk+zt5iHM5gQGxNjqes= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Pablo Martin-Gomez , Miquel Raynal , Sasha Levin Subject: [PATCH 6.1 57/81] mtd: spinand: fix memory leak of ECC engine conf Date: Tue, 8 Jul 2025 18:23:49 +0200 Message-ID: <20250708162226.807834472@linuxfoundation.org> X-Mailer: git-send-email 2.50.0 In-Reply-To: <20250708162224.795155912@linuxfoundation.org> References: <20250708162224.795155912@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Pablo Martin-Gomez [ Upstream commit 6463cbe08b0cbf9bba8763306764f5fd643023e1 ] Memory allocated for the ECC engine conf is not released during spinand cleanup. Below kmemleak trace is seen for this memory leak: unreferenced object 0xffffff80064f00e0 (size 8): comm "swapper/0", pid 1, jiffies 4294937458 hex dump (first 8 bytes): 00 00 00 00 00 00 00 00 ........ backtrace (crc 0): kmemleak_alloc+0x30/0x40 __kmalloc_cache_noprof+0x208/0x3c0 spinand_ondie_ecc_init_ctx+0x114/0x200 nand_ecc_init_ctx+0x70/0xa8 nanddev_ecc_engine_init+0xec/0x27c spinand_probe+0xa2c/0x1620 spi_mem_probe+0x130/0x21c spi_probe+0xf0/0x170 really_probe+0x17c/0x6e8 __driver_probe_device+0x17c/0x21c driver_probe_device+0x58/0x180 __device_attach_driver+0x15c/0x1f8 bus_for_each_drv+0xec/0x150 __device_attach+0x188/0x24c device_initial_probe+0x10/0x20 bus_probe_device+0x11c/0x160 Fix the leak by calling nanddev_ecc_engine_cleanup() inside spinand_cleanup(). Signed-off-by: Pablo Martin-Gomez Signed-off-by: Miquel Raynal Signed-off-by: Sasha Levin --- drivers/mtd/nand/spi/core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mtd/nand/spi/core.c b/drivers/mtd/nand/spi/core.c index dacd9c0e8b202..80e9646d20503 100644 --- a/drivers/mtd/nand/spi/core.c +++ b/drivers/mtd/nand/spi/core.c @@ -1314,6 +1314,7 @@ static void spinand_cleanup(struct spinand_device *spinand) { struct nand_device *nand = spinand_to_nand(spinand); + nanddev_ecc_engine_cleanup(nand); nanddev_cleanup(nand); spinand_manufacturer_cleanup(spinand); kfree(spinand->databuf); -- 2.39.5