From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9307D881E; Tue, 8 Jul 2025 16:30:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751992234; cv=none; b=A83qOEzRfab8VTRKpbub2R1NVW5EQ8nIIsRTPXRLDv10qjCRz0loeX4RM+cYAExUjrNaKrVoed2X3sPOIgF9XH2fBbGhyZiopIyQf94rg14naPIwoqgBh2P0opEh7axLRryRnkcOfpn6A42bTmMmnh6Wya5BUFwjj/5keiJQtAU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751992234; c=relaxed/simple; bh=R6DvkwU3qTUFBwjnAB83upTpYpW1/7GWKupjpXigh14=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=AaMMcu7dLGc1x2Zl/rvzEFkoWMr8a8c04eZ/PaAIB1osJWfzVPLKOK68yL0cIQv1LXX4ns0uEhPHkqiJxpPzBQsmBZ4qM4ls45y38Y5Aq6IfWIMxxcZ+LFzLq1X81BHdBhLsxhUGN+T+s6MZpW9G09Ny2SnRRqLPJyE6Mxd9lh8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=UOuLYBh7; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="UOuLYBh7" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1A8BBC4CEED; Tue, 8 Jul 2025 16:30:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1751992234; bh=R6DvkwU3qTUFBwjnAB83upTpYpW1/7GWKupjpXigh14=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UOuLYBh7EVRIDn4Ji0uqanqq9LVGObg9mg3dKzUhYb63VmJIKqNXYK7Kt6Lf9Y1Mw sQDqmnRl/gVeG+kx5gmbAgbl1Po45Fg832Clb2SpyMi0NqruT67NIievs+o9EhEtdC 2GlyXgR6JERs9zRxRwDoMQ4d6e5aKci0XMCpQ1GM= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Thomas Fourier , "Martin K. Petersen" , Sasha Levin Subject: [PATCH 6.6 024/132] scsi: qla4xxx: Fix missing DMA mapping error in qla4xxx_alloc_pdu() Date: Tue, 8 Jul 2025 18:22:15 +0200 Message-ID: <20250708162231.427969861@linuxfoundation.org> X-Mailer: git-send-email 2.50.0 In-Reply-To: <20250708162230.765762963@linuxfoundation.org> References: <20250708162230.765762963@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Thomas Fourier [ Upstream commit 00f452a1b084efbe8dcb60a29860527944a002a1 ] dma_map_XXX() can fail and should be tested for errors with dma_mapping_error(). Fixes: b3a271a94d00 ("[SCSI] qla4xxx: support iscsiadm session mgmt") Signed-off-by: Thomas Fourier Link: https://lore.kernel.org/r/20250618071742.21822-2-fourier.thomas@gmail.com Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/qla4xxx/ql4_os.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/scsi/qla4xxx/ql4_os.c b/drivers/scsi/qla4xxx/ql4_os.c index 675332e49a7b0..77c28d2ebf013 100644 --- a/drivers/scsi/qla4xxx/ql4_os.c +++ b/drivers/scsi/qla4xxx/ql4_os.c @@ -3420,6 +3420,8 @@ static int qla4xxx_alloc_pdu(struct iscsi_task *task, uint8_t opcode) task_data->data_dma = dma_map_single(&ha->pdev->dev, task->data, task->data_count, DMA_TO_DEVICE); + if (dma_mapping_error(&ha->pdev->dev, task_data->data_dma)) + return -ENOMEM; } DEBUG2(ql4_printk(KERN_INFO, ha, "%s: MaxRecvLen %u, iscsi hrd %d\n", -- 2.39.5