From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 283D32045B5; Tue, 8 Jul 2025 16:55:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751993733; cv=none; b=bry7yU2MTPNOhfNC7QTZlCNqArbqaMpmNdRITYLdgSC3iesR7WS2Y99H8HPhi4vkSW9OFMsZqcDF4PSH8S4HpYi89zNLQ1VL5lleQjYuWARGe3H78Fbn1EvBcD2JYAShuyWegYHC8U3Q8Ce7X5GBPJyw3kGvbIJTuCjAZ6+pyys= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751993733; c=relaxed/simple; bh=yelTn73FbOGsyS+nZhk376o2/FDkzC4BhvP/y5rr1sk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=YV9DH3nQPHpeKYMCSTFpcut2vlY6moB5QwLDj+IoaQJtwG5+deW5RnykN/WaaYE18Di8ktsqXqsbe5ApurNu0CWAXLSGsI+QeR64Dtjm35jIMfMlKjtIT2IFiRkr4ZqeFM2omz0cjjXqPSSm2uBH3QuI+WH1LYgTEQx4jVcl/Zw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=z6x5XdUf; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="z6x5XdUf" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A237DC4CEED; Tue, 8 Jul 2025 16:55:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1751993733; bh=yelTn73FbOGsyS+nZhk376o2/FDkzC4BhvP/y5rr1sk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=z6x5XdUfuGB3jD4cPN5qzw5mf0cVwtisleUxDs0MhvtrS3VGGfM9RXod+UwLJ207+ MaxLmVbGImUKAq8HdcSNP4/WaPEPAKqYLqkEKKn3WqmMZTCTCm1qFSALn5BdwVQnTx 1fKr10fm7rrx+37LDb8vwwG6rGhfbJaBp3kV7D80= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, stable , =?UTF-8?q?=C5=81ukasz=20Bartosik?= , Mathias Nyman Subject: [PATCH 6.15 144/178] xhci: dbctty: disable ECHO flag by default Date: Tue, 8 Jul 2025 18:23:01 +0200 Message-ID: <20250708162240.293055970@linuxfoundation.org> X-Mailer: git-send-email 2.50.0 In-Reply-To: <20250708162236.549307806@linuxfoundation.org> References: <20250708162236.549307806@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 6.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Łukasz Bartosik commit 2b857d69a5e116150639a0c6c39c86cc329939ee upstream. When /dev/ttyDBC0 device is created then by default ECHO flag is set for the terminal device. However if data arrives from a peer before application using /dev/ttyDBC0 applies its set of terminal flags then the arriving data will be echoed which might not be desired behavior. Fixes: 4521f1613940 ("xhci: dbctty: split dbc tty driver registration and unregistration functions.") Cc: stable Signed-off-by: Łukasz Bartosik Signed-off-by: Mathias Nyman Link: https://lore.kernel.org/stable/20250610111802.18742-1-ukaszb%40chromium.org Link: https://lore.kernel.org/r/20250627144127.3889714-4-mathias.nyman@linux.intel.com Signed-off-by: Greg Kroah-Hartman --- drivers/usb/host/xhci-dbgtty.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/usb/host/xhci-dbgtty.c +++ b/drivers/usb/host/xhci-dbgtty.c @@ -617,6 +617,7 @@ int dbc_tty_init(void) dbc_tty_driver->type = TTY_DRIVER_TYPE_SERIAL; dbc_tty_driver->subtype = SERIAL_TYPE_NORMAL; dbc_tty_driver->init_termios = tty_std_termios; + dbc_tty_driver->init_termios.c_lflag &= ~ECHO; dbc_tty_driver->init_termios.c_cflag = B9600 | CS8 | CREAD | HUPCL | CLOCAL; dbc_tty_driver->init_termios.c_ispeed = 9600;