From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6C7012E0411; Tue, 8 Jul 2025 16:37:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751992647; cv=none; b=kXCsIk6rIizxdXUUbeS+kI0yF8BEMMb4Bm10qjACzO7qHFpB95VrLTjz+a2Vabx597eM3UyMF7aU8vcejIb0X1APAbf7H9E5dzVokQDyTpgEn5npyEQXncP74Hev/nO6zu94Uodz6QVKSTxvIo5ml6xHvPb/qyYH7Z40r7Kjoqc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751992647; c=relaxed/simple; bh=ey2gRT+nNqNh6DaJHBCCJnjpGjMJ4gvEsOCzNO8okFM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=IcAmlFRzVRS+2iUMXrJ6sZP6eN++wOdbW/y2U1vhMTi8CKwCDJEUo9SSXlXl0V70Y9FPQAFKWTsZRjlQPMTIfPjWx5kPJVBxHjXcsgRISXplqDs6YQ5U9VoLUjTapjCNsZJUAmLOSy7TZaPQZAIwGWxUfAT2yXXKCnoba6pOk6Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=iKq5Fng5; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="iKq5Fng5" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B88F6C4CEED; Tue, 8 Jul 2025 16:37:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1751992647; bh=ey2gRT+nNqNh6DaJHBCCJnjpGjMJ4gvEsOCzNO8okFM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=iKq5Fng5thLk290JYAJ+gkkp/23mF6PP04cHfA0+DcL8yJNYs1f1KsigVYut+7uth UPgPxHs82VHI9ulo+S6W2M1To8/9R8+lmc3xaUv83DZ8PrG3nzT1h73cv9FQvEPMMa IgQs/muatbIR0KnWeQRdi/FF+ThzQxFJMTjoBkSs= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Bryan Tan , Vishnu Dasa , Stefano Garzarella , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , virtualization@lists.linux.dev, netdev@vger.kernel.org, stable , HarshaVardhana S A Subject: [PATCH 6.12 009/232] vsock/vmci: Clear the vmci transport packet properly when initializing it Date: Tue, 8 Jul 2025 18:20:05 +0200 Message-ID: <20250708162241.675908657@linuxfoundation.org> X-Mailer: git-send-email 2.50.0 In-Reply-To: <20250708162241.426806072@linuxfoundation.org> References: <20250708162241.426806072@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: HarshaVardhana S A commit 223e2288f4b8c262a864e2c03964ffac91744cd5 upstream. In vmci_transport_packet_init memset the vmci_transport_packet before populating the fields to avoid any uninitialised data being left in the structure. Cc: Bryan Tan Cc: Vishnu Dasa Cc: Broadcom internal kernel review list Cc: Stefano Garzarella Cc: "David S. Miller" Cc: Eric Dumazet Cc: Jakub Kicinski Cc: Paolo Abeni Cc: Simon Horman Cc: virtualization@lists.linux.dev Cc: netdev@vger.kernel.org Cc: stable Signed-off-by: HarshaVardhana S A Signed-off-by: Greg Kroah-Hartman Fixes: d021c344051a ("VSOCK: Introduce VM Sockets") Acked-by: Stefano Garzarella Link: https://patch.msgid.link/20250701122254.2397440-1-gregkh@linuxfoundation.org Signed-off-by: Paolo Abeni Signed-off-by: Greg Kroah-Hartman --- net/vmw_vsock/vmci_transport.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/net/vmw_vsock/vmci_transport.c +++ b/net/vmw_vsock/vmci_transport.c @@ -119,6 +119,8 @@ vmci_transport_packet_init(struct vmci_t u16 proto, struct vmci_handle handle) { + memset(pkt, 0, sizeof(*pkt)); + /* We register the stream control handler as an any cid handle so we * must always send from a source address of VMADDR_CID_ANY */ @@ -131,8 +133,6 @@ vmci_transport_packet_init(struct vmci_t pkt->type = type; pkt->src_port = src->svm_port; pkt->dst_port = dst->svm_port; - memset(&pkt->proto, 0, sizeof(pkt->proto)); - memset(&pkt->_reserved2, 0, sizeof(pkt->_reserved2)); switch (pkt->type) { case VMCI_TRANSPORT_PACKET_TYPE_INVALID: