From: Greg KH <gregkh@linuxfoundation.org>
To: "Heyne, Maximilian" <mheyne@amazon.de>
Cc: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>,
Oleg Nesterov <oleg@redhat.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Andrew Morton <akpm@linux-foundation.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
"Sauerwein, David" <dssauerw@amazon.de>,
Sasha Levin <sashal@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>
Subject: Re: [RESEND PATCH 5.15] fs/proc: do_task_stat: use __for_each_thread()
Date: Thu, 10 Jul 2025 15:09:47 +0200 [thread overview]
Message-ID: <2025071032-june-ecosystem-7767@gregkh> (raw)
In-Reply-To: <20250710-yams-adolf-9eb7e4b2@mheyne-amazon>
On Thu, Jul 10, 2025 at 12:43:18PM +0000, Heyne, Maximilian wrote:
> From: Oleg Nesterov <oleg@redhat.com>
>
> [ Upstream commit 7904e53ed5a20fc678c01d5d1b07ec486425bb6a ]
>
> do/while_each_thread should be avoided when possible.
>
> Link: https://lkml.kernel.org/r/20230909164501.GA11581@redhat.com
> Signed-off-by: Oleg Nesterov <oleg@redhat.com>
> Cc: Eric W. Biederman <ebiederm@xmission.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> Stable-dep-of: 7601df8031fd ("fs/proc: do_task_stat: use sig->stats_lock to gather the threads/children stats")
> Cc: stable@vger.kernel.org
> [mheyne: adjusted context]
> Signed-off-by: Maximilian Heyne <mheyne@amazon.de>
> ---
>
> Compile-tested only.
> We're seeing soft lock-ups with 5.10.237 because of the backport of
> commit 4fe85bdaabd6 ("fs/proc: do_task_stat: use sig->stats_lock to
> gather the threads/children stats"). I'm assuming this is broken on 5.15
> too.
Same here, how does this change anything?
greg k-h
prev parent reply other threads:[~2025-07-10 13:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-10 12:43 [RESEND PATCH 5.15] fs/proc: do_task_stat: use __for_each_thread() Heyne, Maximilian
2025-07-10 13:09 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025071032-june-ecosystem-7767@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=akpm@linux-foundation.org \
--cc=dssauerw@amazon.de \
--cc=ebiederm@xmission.com \
--cc=harshit.m.mogalapalli@oracle.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mheyne@amazon.de \
--cc=oleg@redhat.com \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox