From: Sasha Levin <sashal@kernel.org>
To: stable@vger.kernel.org
Cc: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>,
"Sasha Levin" <sashal@kernel.org>
Subject: Re: [PATCH 5.15.y] pwm: mediatek: Ensure to disable clocks in error path
Date: Sun, 13 Jul 2025 09:30:19 -0400 [thread overview]
Message-ID: <20250712204829-fc0f4c74bb537235@stable.kernel.org> (raw)
In-Reply-To: <20250712205600.2182944-2-u.kleine-koenig@baylibre.com>
[ Sasha's backport helper bot ]
Hi,
✅ All tests passed successfully. No issues detected.
No action required from the submitter.
The upstream commit SHA1 provided is correct: 505b730ede7f5c4083ff212aa955155b5b92e574
Status in newer kernel trees:
6.15.y | Present (different SHA1: c4ffbbd8e366)
6.12.y | Present (different SHA1: dd878f5a5d0d)
6.6.y | Not found
6.1.y | Not found
Note: The patch differs from the upstream commit:
---
1: 505b730ede7f5 ! 1: 06f8584381eb0 pwm: mediatek: Ensure to disable clocks in error path
@@ Metadata
## Commit message ##
pwm: mediatek: Ensure to disable clocks in error path
+ commit 505b730ede7f5c4083ff212aa955155b5b92e574 upstream.
+
After enabling the clocks each error path must disable the clocks again.
One of them failed to do so. Unify the error paths to use goto to make it
harder for future changes to add a similar bug.
@@ Commit message
Link: https://lore.kernel.org/r/20250704172728.626815-2-u.kleine-koenig@baylibre.com
Cc: stable@vger.kernel.org
Signed-off-by: Uwe Kleine-König <ukleinek@kernel.org>
+ [ukleinek: backported to 5.15.y]
+ Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
## drivers/pwm/pwm-mediatek.c ##
@@ drivers/pwm/pwm-mediatek.c: static int pwm_mediatek_config(struct pwm_chip *chip, struct pwm_device *pwm,
@@ drivers/pwm/pwm-mediatek.c: static int pwm_mediatek_config(struct pwm_chip *chip
if (clkdiv > PWM_CLK_DIV_MAX) {
- pwm_mediatek_clk_disable(chip, pwm);
- dev_err(pwmchip_parent(chip), "period of %d ns not supported\n", period_ns);
+- dev_err(chip->dev, "period %d not supported\n", period_ns);
- return -EINVAL;
++ dev_err(chip->dev, "period of %d ns not supported\n", period_ns);
+ ret = -EINVAL;
+ goto out;
}
---
Results of testing on various branches:
| Branch | Patch Apply | Build Test |
|---------------------------|-------------|------------|
| stable/linux-5.15.y | Success | Success |
prev parent reply other threads:[~2025-07-13 13:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-12 14:00 FAILED: patch "[PATCH] pwm: mediatek: Ensure to disable clocks in error path" failed to apply to 5.15-stable tree gregkh
2025-07-12 20:56 ` [PATCH 5.15.y] pwm: mediatek: Ensure to disable clocks in error path Uwe Kleine-König
2025-07-13 13:30 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250712204829-fc0f4c74bb537235@stable.kernel.org \
--to=sashal@kernel.org \
--cc=stable@vger.kernel.org \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).