From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 37F962E3AF6; Tue, 15 Jul 2025 13:58:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752587913; cv=none; b=YYRshyjixh9iZFKbTMScheJji7a4C4dUMUHQrFCtXFtjXGSPTNpfJuV0JID9UfpgoOTryoT8cjFtpG5F3DaHz2xWvrlv6N/Wn2sTGsBNwaXYJYk1m12MK6VFPOj6SZWMlVTvVpLE9P/HmcyECW/C6N2vk0hCPAU5nTif38w/EYU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752587913; c=relaxed/simple; bh=oSA7ksryMzP7Hij9MPknDjIBlbgG41TKJIUIUieAbMc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=hdXhe9UcoM5G9f8kJPunUGpvON+91ThQQM3PdZ7/trqTNbn5K2oljKDxAMfS82u0BopG4P+UYQiAuRkahr4sHqIWayOYhKptV2pP2pnRauqLHL09YsIS3Gw9No5AzZVe366gbYbVuzOvlVKw0AusMJbOzi3Tw6uHlDMryuH9dk8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=UCTYvwNA; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="UCTYvwNA" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BFA02C4CEF1; Tue, 15 Jul 2025 13:58:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1752587913; bh=oSA7ksryMzP7Hij9MPknDjIBlbgG41TKJIUIUieAbMc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UCTYvwNAF7HB5oSrm9JqlnUl7yJdfkkcPrM/xEoi/ESNwKyhUgILrFXoLySUuzrjW BqOlxDkgawz01KRlEGOVdHOFs+SLv087K19Dalz7juLOgqxxoDNT1xkQBSU+gAtw3u aTVe1dDzraU2IUIsPpZzZc2bIQ/+BYyPpGawpuMg= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Kito Xu , Jakub Kicinski , Sasha Levin Subject: [PATCH 5.10 189/208] net: appletalk: Fix device refcount leak in atrtr_create() Date: Tue, 15 Jul 2025 15:14:58 +0200 Message-ID: <20250715130818.519682422@linuxfoundation.org> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250715130810.830580412@linuxfoundation.org> References: <20250715130810.830580412@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Kito Xu [ Upstream commit 711c80f7d8b163d3ecd463cd96f07230f488e750 ] When updating an existing route entry in atrtr_create(), the old device reference was not being released before assigning the new device, leading to a device refcount leak. Fix this by calling dev_put() to release the old device reference before holding the new one. Fixes: c7f905f0f6d4 ("[ATALK]: Add missing dev_hold() to atrtr_create().") Signed-off-by: Kito Xu Link: https://patch.msgid.link/tencent_E1A26771CDAB389A0396D1681A90A49E5D09@qq.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- net/appletalk/ddp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/appletalk/ddp.c b/net/appletalk/ddp.c index 46adb8cefccf2..c9edfca153c99 100644 --- a/net/appletalk/ddp.c +++ b/net/appletalk/ddp.c @@ -563,6 +563,7 @@ static int atrtr_create(struct rtentry *r, struct net_device *devhint) /* Fill in the routing entry */ rt->target = ta->sat_addr; + dev_put(rt->dev); /* Release old device */ dev_hold(devhint); rt->dev = devhint; rt->flags = r->rt_flags; -- 2.39.5