From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Muhammad Usama Anjum <usama.anjum@collabora.com>
Cc: Manivannan Sadhasivam <mani@kernel.org>,
Jeff Hugo <jeff.hugo@oss.qualcomm.com>,
Youssef Samir <quic_yabdulra@quicinc.com>,
Matthew Leung <quic_mattleun@quicinc.com>,
Alexander Wilhelm <alexander.wilhelm@westermo.com>,
Kunwu Chan <chentao@kylinos.cn>,
Krishna Chaitanya Chundru <krishna.chundru@oss.qualcomm.com>,
Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com>,
Yan Zhen <yanzhen@vivo.com>, Sujeev Dias <sdias@codeaurora.org>,
Siddartha Mohanadoss <smohanad@codeaurora.org>,
mhi@lists.linux.dev, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel@collabora.com,
stable@vger.kernel.org
Subject: Re: [PATCH v2 1/3] bus: mhi: host: keep bhi buffer through suspend cycle
Date: Wed, 16 Jul 2025 11:34:37 +0200 [thread overview]
Message-ID: <2025071604-scandal-outpost-eb22@gregkh> (raw)
In-Reply-To: <20250715132509.2643305-2-usama.anjum@collabora.com>
On Tue, Jul 15, 2025 at 06:25:07PM +0500, Muhammad Usama Anjum wrote:
> When there is memory pressure, at resume time dma_alloc_coherent()
> returns error which in turn fails the loading of firmware and hence
> the driver crashes:
>
> kernel: kworker/u33:5: page allocation failure: order:7,
> mode:0xc04(GFP_NOIO|GFP_DMA32), nodemask=(null),cpuset=/,mems_allowed=0
> kernel: CPU: 1 UID: 0 PID: 7693 Comm: kworker/u33:5 Not tainted 6.11.11-valve17-1-neptune-611-g027868a0ac03 #1 3843143b92e9da0fa2d3d5f21f51beaed15c7d59
> kernel: Hardware name: Valve Galileo/Galileo, BIOS F7G0112 08/01/2024
> kernel: Workqueue: mhi_hiprio_wq mhi_pm_st_worker [mhi]
> kernel: Call Trace:
> kernel: <TASK>
> kernel: dump_stack_lvl+0x4e/0x70
> kernel: warn_alloc+0x164/0x190
> kernel: ? srso_return_thunk+0x5/0x5f
> kernel: ? __alloc_pages_direct_compact+0xaf/0x360
> kernel: __alloc_pages_slowpath.constprop.0+0xc75/0xd70
> kernel: __alloc_pages_noprof+0x321/0x350
> kernel: __dma_direct_alloc_pages.isra.0+0x14a/0x290
> kernel: dma_direct_alloc+0x70/0x270
> kernel: mhi_fw_load_handler+0x126/0x340 [mhi a96cb91daba500cc77f86bad60c1f332dc3babdf]
> kernel: mhi_pm_st_worker+0x5e8/0xac0 [mhi a96cb91daba500cc77f86bad60c1f332dc3babdf]
> kernel: ? srso_return_thunk+0x5/0x5f
> kernel: process_one_work+0x17e/0x330
> kernel: worker_thread+0x2ce/0x3f0
> kernel: ? __pfx_worker_thread+0x10/0x10
> kernel: kthread+0xd2/0x100
> kernel: ? __pfx_kthread+0x10/0x10
> kernel: ret_from_fork+0x34/0x50
> kernel: ? __pfx_kthread+0x10/0x10
> kernel: ret_from_fork_asm+0x1a/0x30
> kernel: </TASK>
> kernel: Mem-Info:
> kernel: active_anon:513809 inactive_anon:152 isolated_anon:0
> active_file:359315 inactive_file:2487001 isolated_file:0
> unevictable:637 dirty:19 writeback:0
> slab_reclaimable:160391 slab_unreclaimable:39729
> mapped:175836 shmem:51039 pagetables:4415
> sec_pagetables:0 bounce:0
> kernel_misc_reclaimable:0
> free:125666 free_pcp:0 free_cma:0
This is not a "crash", it is a warning that your huge memory allocation
did not succeed. Properly handle this issue (and if you know it's going
to happen, turn the warning off in your allocation), and you should be
fine.
> In above example, if we sum all the consumed memory, it comes out
> to be 15.5GB and free memory is ~ 500MB from a total of 16GB RAM.
> Even though memory is present. But all of the dma memory has been
> exhausted or fragmented.
What caused that to happen?
> Fix it by allocating it only once and then reuse the same allocated
> memory. As we'll allocate this memory only once, this memory will stay
> allocated.
As others said, no, don't consume memory for no good reason, that just
means that other devices will fail more frequently. If all
devices/drivers did this, you wouldn't have memory to work either.
thanks,
greg k-h
next prev parent reply other threads:[~2025-07-16 9:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20250715132509.2643305-1-usama.anjum@collabora.com>
2025-07-15 13:25 ` [PATCH v2 1/3] bus: mhi: host: keep bhi buffer through suspend cycle Muhammad Usama Anjum
2025-07-16 3:41 ` Baochen Qiang
2025-07-16 9:34 ` Greg Kroah-Hartman [this message]
2025-07-17 10:00 ` Muhammad Usama Anjum
2025-07-17 11:50 ` Greg Kroah-Hartman
2025-07-15 13:25 ` [PATCH v2 2/3] bus: mhi: host: keep bhie " Muhammad Usama Anjum
2025-07-16 9:35 ` Greg Kroah-Hartman
2025-07-15 13:25 ` [PATCH v2 3/3] bus: mhi: keep device context through suspend cycles Muhammad Usama Anjum
2025-07-16 9:35 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025071604-scandal-outpost-eb22@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=alexander.wilhelm@westermo.com \
--cc=chentao@kylinos.cn \
--cc=jacek.lawrynowicz@linux.intel.com \
--cc=jeff.hugo@oss.qualcomm.com \
--cc=kernel@collabora.com \
--cc=krishna.chundru@oss.qualcomm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mani@kernel.org \
--cc=mhi@lists.linux.dev \
--cc=quic_mattleun@quicinc.com \
--cc=quic_yabdulra@quicinc.com \
--cc=sdias@codeaurora.org \
--cc=smohanad@codeaurora.org \
--cc=stable@vger.kernel.org \
--cc=usama.anjum@collabora.com \
--cc=yanzhen@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox