Linux kernel -stable discussions
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
Cc: stable@vger.kernel.org, qat-linux@intel.com,
	Damian Muszynski <damian.muszynski@intel.com>,
	Tero Kristo <tero.kristo@linux.intel.com>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	Ahsan Atta <ahsan.atta@intel.com>
Subject: Re: [PATCH 6.1] crypto: qat - fix ring to service map for QAT GEN4
Date: Tue, 22 Jul 2025 11:42:37 +0200	[thread overview]
Message-ID: <2025072202-partridge-utilize-9db7@gregkh> (raw)
In-Reply-To: <20250717170835.25211-1-giovanni.cabiddu@intel.com>

On Thu, Jul 17, 2025 at 06:06:38PM +0100, Giovanni Cabiddu wrote:
> [ Upstream commit a238487f7965d102794ed9f8aff0b667cd2ae886 ]
> 
> The 4xxx drivers hardcode the ring to service mapping. However, when
> additional configurations where added to the driver, the mappings were
> not updated. This implies that an incorrect mapping might be reported
> through pfvf for certain configurations.
> 
> This is a backport of the upstream commit with modifications, as the
> original patch does not apply cleanly to kernel v6.1.x. The logic has
> been simplified to reflect the limited configurations of the QAT driver
> in this version: crypto-only and compression.
> 
> Instead of dynamically computing the ring to service mappings, these are
> now hardcoded to simplify the backport.
> 
> Fixes: 0cec19c761e5 ("crypto: qat - add support for compression for 4xxx")
> Signed-off-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
> Reviewed-by: Damian Muszynski <damian.muszynski@intel.com>
> Reviewed-by: Tero Kristo <tero.kristo@linux.intel.com>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
> Cc: <stable@vger.kernel.org> # 6.1.x
> Reviewed-by: Ahsan Atta <ahsan.atta@intel.com>
> Tested-by: Ahsan Atta <ahsan.atta@intel.com>

You did not mention anywhere what changed from the original commit (and
it changed a lot...)  So this looks to me like an incorrect backport, so
I have to just delete it :(

Please fix up and send it again.

thanks,

greg k-h

  parent reply	other threads:[~2025-07-22  9:42 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-17 17:06 [PATCH 6.1] crypto: qat - fix ring to service map for QAT GEN4 Giovanni Cabiddu
2025-07-18  1:34 ` Sasha Levin
2025-07-18  6:54   ` Giovanni Cabiddu
2025-07-18 12:11     ` Sasha Levin
2025-07-22  9:42 ` Greg KH [this message]
2025-07-22 13:29   ` Giovanni Cabiddu
2025-07-22 13:39     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2025072202-partridge-utilize-9db7@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=ahsan.atta@intel.com \
    --cc=damian.muszynski@intel.com \
    --cc=giovanni.cabiddu@intel.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=qat-linux@intel.com \
    --cc=stable@vger.kernel.org \
    --cc=tero.kristo@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox