public inbox for stable@vger.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: chalianis1@gmail.com
Cc: andrew@lunn.ch, hkallweit1@gmail.com, edumazet@google.com,
	pabeni@redhat.com, linux@armlinux.org.uk, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH net] phy: dp83869: fix interrupts issue when using with an optical fiber sfp. to correctly clear the interrupts both status registers must be read.
Date: Fri, 25 Jul 2025 17:14:46 -0700	[thread overview]
Message-ID: <20250725171446.73bb3f8c@kernel.org> (raw)
In-Reply-To: <20250726001034.28885-1-chalianis1@gmail.com>

First of all, please read:
https://www.kernel.org/doc/html/next/process/maintainer-netdev.html

> Subject: [PATCH net] phy: dp83869: fix interrupts issue when using with an optical fiber sfp. to correctly clear the interrupts both status registers must be read.

The first line of the commit message becomes the subject, it should
be a very short summary of the patch (100 chars max)

On Fri, 25 Jul 2025 20:10:34 -0400 chalianis1@gmail.com wrote:
> From: Anis Chali <chalianis1@gmail.com>
> 
> from datasheet of dp83869hm
> 7.3.6 Interrupt
> The DP83869HM can be configured to generate an interrupt when changes of internal status occur. The interrupt
> allows a MAC to act upon the status in the PHY without polling the PHY registers. The interrupt source can be
> selected through the interrupt registers, MICR (12h) and FIBER_INT_EN (C18h). The interrupt status can be
> read from ISR (13h) and FIBER_INT_STTS (C19h) registers. Some interrupts are enabled by default and can
> be disabled through register access. Both the interrupt status registers must be read in order to clear pending
> interrupts. Until the pending interrupts are cleared, new interrupts may not be routed to the interrupt pin.

This needs to be line wrapped at 70-ish characters.

> Fixes: 01db923e8377 ("net: phy: dp83869: Add TI dp83869 phy")
> 

no empty lines between tags, please

> Cc: stable@vger.kernel.org
> Signed-off-by: Anis Chali <chalianis1@gmail.com>
-- 
pw-bot: cr

  reply	other threads:[~2025-07-26  0:14 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-26  0:10 [PATCH net] phy: dp83869: fix interrupts issue when using with an optical fiber sfp. to correctly clear the interrupts both status registers must be read chalianis1
2025-07-26  0:14 ` Jakub Kicinski [this message]
2025-07-26 15:14 ` Andrew Lunn
2025-07-26 20:05 ` Simon Horman
  -- strict thread matches above, loose matches on Subject: below --
2025-07-26  0:09 chalianis1
2025-05-19 14:47 chalianis1
2025-05-19 14:49 ` kernel test robot
2025-05-19 15:01 ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250725171446.73bb3f8c@kernel.org \
    --to=kuba@kernel.org \
    --cc=andrew@lunn.ch \
    --cc=chalianis1@gmail.com \
    --cc=edumazet@google.com \
    --cc=hkallweit1@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox