From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 42290279910 for ; Mon, 28 Jul 2025 13:55:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753710908; cv=none; b=Ad8UJRUwWE8BwEcz/RPVsj5Tzb7W0U7Z+9xbGl1E16rF2i8t5e75dUht8RsAi8WLCjNjibTV3E9ZM7c5U9b2pz3OAmISI/yhvC6CZW930E2g1r/uc4NRb6dm9XZPJZazxlY0fUkbix2YdSTiD3UTRR1LINn+kyDGbzzFIKHauXM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753710908; c=relaxed/simple; bh=Z+xqE6niw11196UAMBCd1CY+dCaUlVP7kxYSi+ZQ2gY=; h=Subject:To:Cc:From:Date:Message-ID:MIME-Version:Content-Type; b=u+jQyavU8pMG1FgE925L7QcuIvI2IEePVwwfkT4Xn5esLcAPkr62608bQbQlL/OnlVOBKz0sSgPgvCLDkC/d3l4Iem5sOxq9gIhr6yBKDAuVs2LpP4aig/+Fnfk0JT6SKkozI9VAVjY0M4fM8bs8hEGoxsABy8imUR8WvsgFCVM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=FPs7RjP9; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="FPs7RjP9" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C2B7EC4CEEF; Mon, 28 Jul 2025 13:55:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1753710908; bh=Z+xqE6niw11196UAMBCd1CY+dCaUlVP7kxYSi+ZQ2gY=; h=Subject:To:Cc:From:Date:From; b=FPs7RjP9Hfr6jNbvOoL8wkNr4zn0pu82z1eABH7aqK1OHUVswSl1WQ3RN/ZA04x7k OsNIXg8ltJ53qe9FBbXixTRNKDS/ii500X+vYfEOpZTvWQciWELgjaqzc3NXKnl+ce jsN2/e+wLifLhbQsgS4xu6m2C2WDTkj5Sf8Wylf4= Subject: FAILED: patch "[PATCH] ice: Fix a null pointer dereference in" failed to apply to 5.10-stable tree To: haoxiang_li2024@163.com,aleksandr.loktionov@intel.com,anthony.l.nguyen@intel.com,horms@kernel.org,michal.swiatkowski@linux.intel.com,sx.rinitha@intel.com Cc: From: Date: Mon, 28 Jul 2025 15:53:01 +0200 Message-ID: <2025072801-groove-marauding-e4a9@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit The patch below does not apply to the 5.10-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-5.10.y git checkout FETCH_HEAD git cherry-pick -x 4ff12d82dac119b4b99b5a78b5af3bf2474c0a36 # git commit -s git send-email --to '' --in-reply-to '2025072801-groove-marauding-e4a9@gregkh' --subject-prefix 'PATCH 5.10.y' HEAD^.. Possible dependencies: thanks, greg k-h ------------------ original commit in Linus's tree ------------------ >From 4ff12d82dac119b4b99b5a78b5af3bf2474c0a36 Mon Sep 17 00:00:00 2001 From: Haoxiang Li Date: Thu, 3 Jul 2025 17:52:32 +0800 Subject: [PATCH] ice: Fix a null pointer dereference in ice_copy_and_init_pkg() Add check for the return value of devm_kmemdup() to prevent potential null pointer dereference. Fixes: c76488109616 ("ice: Implement Dynamic Device Personalization (DDP) download") Cc: stable@vger.kernel.org Signed-off-by: Haoxiang Li Reviewed-by: Michal Swiatkowski Reviewed-by: Aleksandr Loktionov Reviewed-by: Simon Horman Tested-by: Rinitha S (A Contingent worker at Intel) Signed-off-by: Tony Nguyen diff --git a/drivers/net/ethernet/intel/ice/ice_ddp.c b/drivers/net/ethernet/intel/ice/ice_ddp.c index 59323c019544..351824dc3c62 100644 --- a/drivers/net/ethernet/intel/ice/ice_ddp.c +++ b/drivers/net/ethernet/intel/ice/ice_ddp.c @@ -2301,6 +2301,8 @@ enum ice_ddp_state ice_copy_and_init_pkg(struct ice_hw *hw, const u8 *buf, return ICE_DDP_PKG_ERR; buf_copy = devm_kmemdup(ice_hw_to_dev(hw), buf, len, GFP_KERNEL); + if (!buf_copy) + return ICE_DDP_PKG_ERR; state = ice_init_pkg(hw, buf_copy, len); if (!ice_is_init_pkg_successful(state)) {