From: Sasha Levin <sashal@kernel.org>
To: patches@lists.linux.dev, stable@vger.kernel.org
Cc: "Thomas Weißschuh" <thomas.weissschuh@linutronix.de>,
"Thomas Weißschuh" <linux@weissschuh.net>,
"Sasha Levin" <sashal@kernel.org>,
nathan@kernel.org, tglozar@redhat.com, rostedt@goodmis.org,
jolsa@kernel.org, charlie@rivosinc.com, llvm@lists.linux.dev
Subject: [PATCH AUTOSEL 6.15 35/80] tools/build: Fix s390(x) cross-compilation with clang
Date: Sun, 3 Aug 2025 20:27:02 -0400 [thread overview]
Message-ID: <20250804002747.3617039-35-sashal@kernel.org> (raw)
In-Reply-To: <20250804002747.3617039-1-sashal@kernel.org>
From: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
[ Upstream commit a40f0cdce78be8a559ee8a85c908049c65a410b2 ]
The heuristic to derive a clang target triple from a GCC one does not work
for s390. GCC uses "s390-linux" while clang expects "s390x-linux" or
"powerz-linux".
Add an explicit override.
Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
Link: https://lore.kernel.org/r/20250620-tools-cross-s390-v2-1-ecda886e00e5@linutronix.de
Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
LLM Generated explanations, may be completely bogus:
Now let me understand better what the issue is. Based on my analysis:
**Backport Status: YES**
This commit fixes a critical cross-compilation issue where the heuristic
to derive a clang target triple from a GCC one fails for s390
architecture. Here's my detailed analysis:
## Analysis of Code Changes:
The patch modifies `tools/scripts/Makefile.include` by adding two lines
after line 104:
```makefile
CLANG_CROSS_FLAGS := --target=$(notdir $(CROSS_COMPILE:%-=%))
+CLANG_TARGET := $(notdir $(CROSS_COMPILE:%-=%))
+CLANG_TARGET := $(subst s390-linux,s390x-linux,$(CLANG_TARGET))
+CLANG_CROSS_FLAGS := --target=$(CLANG_TARGET)
```
## Key Findings:
1. **Bug Type**: This fixes a build failure when cross-compiling kernel
tools for s390 architecture using clang.
2. **Root Cause**: GCC uses "s390-linux" as the target triple while
clang expects "s390x-linux" or "systemz-linux". The existing
heuristic that derives the clang target from the GCC cross-compiler
prefix fails for s390.
3. **Similar Fixes Already Present**: I found that other parts of the
kernel already handle this incompatibility:
- `tools/testing/selftests/nolibc/Makefile:` converts s390-linux to
systemz-linux
- `tools/include/nolibc/Makefile:` converts s390-linux to systemz-
linux
- `scripts/Makefile.clang:` directly uses s390x-linux-gnu
4. **Impact**: Without this fix, cross-compilation of kernel tools for
s390 using clang will fail, affecting:
- Developers building tools for s390 systems
- CI/CD pipelines that cross-compile for multiple architectures
- Distribution builders who need to build kernel tools
5. **Risk Assessment**:
- The change is minimal and isolated to the build system
- It only affects the clang target selection logic
- No runtime behavior changes
- Similar transformations are already proven in other makefiles
6. **Stable Tree Criteria**:
- ✓ Fixes a real bug that affects users (build failure)
- ✓ Small and contained fix (2 lines)
- ✓ No side effects beyond fixing the issue
- ✓ No architectural changes
- ✓ Only touches build infrastructure
- ✓ Minimal risk of regression
This is a clear candidate for stable backporting as it fixes a concrete
build failure with minimal risk.
tools/scripts/Makefile.include | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/tools/scripts/Makefile.include b/tools/scripts/Makefile.include
index 5158250988ce..ded48263dd5e 100644
--- a/tools/scripts/Makefile.include
+++ b/tools/scripts/Makefile.include
@@ -101,7 +101,9 @@ else ifneq ($(CROSS_COMPILE),)
# Allow userspace to override CLANG_CROSS_FLAGS to specify their own
# sysroots and flags or to avoid the GCC call in pure Clang builds.
ifeq ($(CLANG_CROSS_FLAGS),)
-CLANG_CROSS_FLAGS := --target=$(notdir $(CROSS_COMPILE:%-=%))
+CLANG_TARGET := $(notdir $(CROSS_COMPILE:%-=%))
+CLANG_TARGET := $(subst s390-linux,s390x-linux,$(CLANG_TARGET))
+CLANG_CROSS_FLAGS := --target=$(CLANG_TARGET)
GCC_TOOLCHAIN_DIR := $(dir $(shell which $(CROSS_COMPILE)gcc 2>/dev/null))
ifneq ($(GCC_TOOLCHAIN_DIR),)
CLANG_CROSS_FLAGS += --prefix=$(GCC_TOOLCHAIN_DIR)$(notdir $(CROSS_COMPILE))
--
2.39.5
next prev parent reply other threads:[~2025-08-04 0:29 UTC|newest]
Thread overview: 82+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-04 0:26 [PATCH AUTOSEL 6.15 01/80] usb: xhci: print xhci->xhc_state when queue_command failed Sasha Levin
2025-08-04 0:26 ` [PATCH AUTOSEL 6.15 02/80] staging: gpib: Add init response codes for new ni-usb-hs+ Sasha Levin
2025-08-04 0:26 ` [PATCH AUTOSEL 6.15 03/80] platform/x86/amd: pmc: Add Lenovo Yoga 6 13ALC6 to pmc quirk list Sasha Levin
2025-08-04 0:26 ` [PATCH AUTOSEL 6.15 04/80] cpufreq: CPPC: Mark driver with NEED_UPDATE_LIMITS flag Sasha Levin
2025-08-04 0:26 ` [PATCH AUTOSEL 6.15 05/80] selftests/futex: Define SYS_futex on 32-bit architectures with 64-bit time_t Sasha Levin
2025-08-04 0:26 ` [PATCH AUTOSEL 6.15 06/80] usb: typec: ucsi: psy: Set current max to 100mA for BC 1.2 and Default Sasha Levin
2025-08-04 0:26 ` [PATCH AUTOSEL 6.15 07/80] bus: mhi: host: pci_generic: Add Telit FN990B40 modem support Sasha Levin
2025-08-04 0:26 ` [PATCH AUTOSEL 6.15 08/80] regulator: core: repeat voltage setting request for stepped regulators Sasha Levin
2025-08-04 0:26 ` [PATCH AUTOSEL 6.15 09/80] bus: mhi: host: pci_generic: Disable runtime PM for QDU100 Sasha Levin
2025-08-04 0:26 ` [PATCH AUTOSEL 6.15 10/80] usb: xhci: Avoid showing warnings for dying controller Sasha Levin
2025-08-04 0:26 ` [PATCH AUTOSEL 6.15 11/80] usb: xhci: Set avg_trb_len = 8 for EP0 during Address Device Command Sasha Levin
2025-08-04 0:26 ` [PATCH AUTOSEL 6.15 12/80] usb: xhci: Avoid showing errors during surprise removal Sasha Levin
2025-08-04 0:26 ` [PATCH AUTOSEL 6.15 13/80] firmware: qcom: scm: initialize tzmem before marking SCM as available Sasha Levin
2025-08-04 0:26 ` [PATCH AUTOSEL 6.15 14/80] soc: qcom: rpmh-rsc: Add RSC version 4 support Sasha Levin
2025-08-04 0:26 ` [PATCH AUTOSEL 6.15 15/80] ACPI: APEI: send SIGBUS to current task if synchronous memory error not recovered Sasha Levin
2025-08-04 0:26 ` [PATCH AUTOSEL 6.15 16/80] remoteproc: imx_rproc: skip clock enable when M-core is managed by the SCU Sasha Levin
2025-08-04 0:26 ` [PATCH AUTOSEL 6.15 17/80] binder: Fix selftest page indexing Sasha Levin
2025-08-04 0:26 ` [PATCH AUTOSEL 6.15 18/80] gpio: loongson-64bit: Extend GPIO irq support Sasha Levin
2025-08-04 0:26 ` [PATCH AUTOSEL 6.15 19/80] usb: typec: ucsi: Add poll_cci operation to cros_ec_ucsi Sasha Levin
2025-08-04 0:26 ` [PATCH AUTOSEL 6.15 20/80] usb: typec: tcpm/tcpci_maxim: fix irq wake usage Sasha Levin
2025-08-04 0:26 ` [PATCH AUTOSEL 6.15 21/80] pmdomain: ti: Select PM_GENERIC_DOMAINS Sasha Levin
2025-08-04 0:26 ` [PATCH AUTOSEL 6.15 22/80] gpio: wcd934x: check the return value of regmap_update_bits() Sasha Levin
2025-08-04 0:26 ` [PATCH AUTOSEL 6.15 23/80] cpufreq: Exit governor when failed to start old governor Sasha Levin
2025-08-04 0:26 ` [PATCH AUTOSEL 6.15 24/80] cpufreq: intel_pstate: Add Granite Rapids support in no-HWP mode Sasha Levin
2025-08-04 0:26 ` [PATCH AUTOSEL 6.15 25/80] ARM: rockchip: fix kernel hang during smp initialization Sasha Levin
2025-08-04 0:26 ` [PATCH AUTOSEL 6.15 26/80] PM / devfreq: governor: Replace sscanf() with kstrtoul() in set_freq_store() Sasha Levin
2025-08-04 0:26 ` [PATCH AUTOSEL 6.15 27/80] EDAC/synopsys: Clear the ECC counters on init Sasha Levin
2025-08-04 0:26 ` [PATCH AUTOSEL 6.15 28/80] ASoC: soc-dapm: set bias_level if snd_soc_dapm_set_bias_level() was successed Sasha Levin
2025-08-04 0:26 ` [PATCH AUTOSEL 6.15 29/80] thermal/drivers/qcom-spmi-temp-alarm: Enable stage 2 shutdown when required Sasha Levin
2025-08-04 0:26 ` [PATCH AUTOSEL 6.15 30/80] tools/nolibc: define time_t in terms of __kernel_old_time_t Sasha Levin
2025-08-04 0:26 ` [PATCH AUTOSEL 6.15 31/80] iio: adc: ad_sigma_delta: don't overallocate scan buffer Sasha Levin
2025-08-04 0:26 ` [PATCH AUTOSEL 6.15 32/80] gpio: tps65912: check the return value of regmap_update_bits() Sasha Levin
2025-08-04 0:27 ` [PATCH AUTOSEL 6.15 33/80] mfd: tps6594: Add TI TPS652G1 support Sasha Levin
2025-08-04 0:27 ` [PATCH AUTOSEL 6.15 34/80] ARM: tegra: Use I/O memcpy to write to IRAM Sasha Levin
2025-08-04 0:27 ` Sasha Levin [this message]
2025-08-04 0:27 ` [PATCH AUTOSEL 6.15 36/80] selftests: tracing: Use mutex_unlock for testing glob filter Sasha Levin
2025-08-04 0:27 ` [PATCH AUTOSEL 6.15 37/80] ACPI: PRM: Reduce unnecessary printing to avoid user confusion Sasha Levin
2025-08-04 0:27 ` [PATCH AUTOSEL 6.15 38/80] firmware: arm_scmi: power_control: Ensure SCMI_SYSPOWER_IDLE is set early during resume Sasha Levin
2025-08-04 0:27 ` [PATCH AUTOSEL 6.15 39/80] firmware: tegra: Fix IVC dependency problems Sasha Levin
2025-08-04 0:27 ` [PATCH AUTOSEL 6.15 40/80] pwm: sifive: Fix PWM algorithm and clarify inverted compare behavior Sasha Levin
2025-08-04 10:40 ` Uwe Kleine-König
2025-08-04 0:27 ` [PATCH AUTOSEL 6.15 41/80] ALSA: hda: add MODULE_FIRMWARE for cs35l41/cs35l56 Sasha Levin
2025-08-04 0:27 ` [PATCH AUTOSEL 6.15 42/80] PM: runtime: Clear power.needs_force_resume in pm_runtime_reinit() Sasha Levin
2025-08-04 0:27 ` [PATCH AUTOSEL 6.15 43/80] thermal: sysfs: Return ENODATA instead of EAGAIN for reads Sasha Levin
2025-08-04 0:27 ` [PATCH AUTOSEL 6.15 44/80] PM: sleep: console: Fix the black screen issue Sasha Levin
2025-08-04 0:27 ` [PATCH AUTOSEL 6.15 45/80] ACPI: processor: fix acpi_object initialization Sasha Levin
2025-08-04 0:27 ` [PATCH AUTOSEL 6.15 46/80] mmc: sdhci-msm: Ensure SD card power isn't ON when card removed Sasha Levin
2025-08-04 0:27 ` [PATCH AUTOSEL 6.15 47/80] ACPI: APEI: GHES: add TAINT_MACHINE_CHECK on GHES panic path Sasha Levin
2025-08-04 0:27 ` [PATCH AUTOSEL 6.15 48/80] irqchip/renesas-rzv2h: Enable SKIP_SET_WAKE and MASK_ON_SUSPEND Sasha Levin
2025-08-04 0:27 ` [PATCH AUTOSEL 6.15 49/80] selftests: vDSO: vdso_test_getrandom: Always print TAP header Sasha Levin
2025-08-04 0:27 ` [PATCH AUTOSEL 6.15 50/80] pps: clients: gpio: fix interrupt handling order in remove path Sasha Levin
2025-08-04 6:55 ` Rodolfo Giometti
2025-08-04 0:27 ` [PATCH AUTOSEL 6.15 51/80] reset: brcmstb: Enable reset drivers for ARCH_BCM2835 Sasha Levin
2025-08-04 0:27 ` [PATCH AUTOSEL 6.15 52/80] ASoC: SDCA: Add flag for unused IRQs Sasha Levin
2025-08-04 0:27 ` [PATCH AUTOSEL 6.15 53/80] char: misc: Fix improper and inaccurate error code returned by misc_init() Sasha Levin
2025-08-04 0:27 ` [PATCH AUTOSEL 6.15 54/80] mei: bus: Check for still connected devices in mei_cl_bus_dev_release() Sasha Levin
2025-08-04 0:27 ` [PATCH AUTOSEL 6.15 55/80] mmc: rtsx_usb_sdmmc: Fix error-path in sd_set_power_mode() Sasha Levin
2025-08-04 0:27 ` [PATCH AUTOSEL 6.15 56/80] platform/chrome: cros_ec_sensorhub: Retries when a sensor is not ready Sasha Levin
2025-08-04 0:27 ` [PATCH AUTOSEL 6.15 57/80] ALSA: hda: Handle the jack polling always via a work Sasha Levin
2025-08-04 0:27 ` [PATCH AUTOSEL 6.15 58/80] ALSA: hda: Disable jack polling at shutdown Sasha Levin
2025-08-04 0:27 ` [PATCH AUTOSEL 6.15 59/80] x86/bugs: Avoid warning when overriding return thunk Sasha Levin
2025-08-04 0:27 ` [PATCH AUTOSEL 6.15 60/80] ASoC: hdac_hdmi: Rate limit logging on connection and disconnection Sasha Levin
2025-08-04 0:27 ` [PATCH AUTOSEL 6.15 61/80] ALSA: intel8x0: Fix incorrect codec index usage in mixer for ICH4 Sasha Levin
2025-08-04 0:27 ` [PATCH AUTOSEL 6.15 62/80] irqchip/mips-gic: Allow forced affinity Sasha Levin
2025-08-04 0:27 ` [PATCH AUTOSEL 6.15 63/80] ASoC: SOF: topology: Parse the dapm_widget_tokens in case of DSPless mode Sasha Levin
2025-08-04 0:27 ` [PATCH AUTOSEL 6.15 64/80] tty: serial: fix print format specifiers Sasha Levin
2025-08-04 0:27 ` [PATCH AUTOSEL 6.15 65/80] ASoC: core: Check for rtd == NULL in snd_soc_remove_pcm_runtime() Sasha Levin
2025-08-04 0:27 ` [PATCH AUTOSEL 6.15 66/80] usb: typec: intel_pmc_mux: Defer probe if SCU IPC isn't present Sasha Levin
2025-08-04 0:27 ` [PATCH AUTOSEL 6.15 67/80] usb: core: usb_submit_urb: downgrade type check Sasha Levin
2025-08-04 0:27 ` [PATCH AUTOSEL 6.15 68/80] usb: typec: fusb302: fix scheduling while atomic when using virtio-gpio Sasha Levin
2025-08-04 0:27 ` [PATCH AUTOSEL 6.15 69/80] usb: dwc3: xilinx: add shutdown callback Sasha Levin
2025-08-04 0:27 ` [PATCH AUTOSEL 6.15 70/80] pm: cpupower: Fix the snapshot-order of tsc,mperf, clock in mperf_stop() Sasha Levin
2025-08-04 0:27 ` [PATCH AUTOSEL 6.15 71/80] imx8m-blk-ctrl: set ISI panic write hurry level Sasha Levin
2025-08-04 0:27 ` [PATCH AUTOSEL 6.15 72/80] soc: qcom: mdt_loader: Actually use the e_phoff Sasha Levin
2025-08-04 0:27 ` [PATCH AUTOSEL 6.15 73/80] platform/x86: thinkpad_acpi: Handle KCOV __init vs inline mismatches Sasha Levin
2025-08-04 0:27 ` [PATCH AUTOSEL 6.15 74/80] platform/chrome: cros_ec_typec: Defer probe on missing EC parent Sasha Levin
2025-08-04 0:27 ` [PATCH AUTOSEL 6.15 75/80] ALSA: hda/ca0132: Fix buffer overflow in add_tuning_control Sasha Levin
2025-08-04 0:27 ` [PATCH AUTOSEL 6.15 76/80] ALSA: pcm: Rewrite recalculate_boundary() to avoid costly loop Sasha Levin
2025-08-04 0:27 ` [PATCH AUTOSEL 6.15 77/80] ALSA: usb-audio: Avoid precedence issues in mixer_quirks macros Sasha Levin
2025-08-04 0:27 ` [PATCH AUTOSEL 6.15 78/80] iio: adc: ad7768-1: Ensure SYNC_IN pulse minimum timing requirement Sasha Levin
2025-08-04 0:27 ` [PATCH AUTOSEL 6.15 79/80] ASoC: codecs: rt5640: Retry DEVICE_ID verification Sasha Levin
2025-08-04 0:27 ` [PATCH AUTOSEL 6.15 80/80] ASoC: qcom: use drvdata instead of component to keep id Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250804002747.3617039-35-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=charlie@rivosinc.com \
--cc=jolsa@kernel.org \
--cc=linux@weissschuh.net \
--cc=llvm@lists.linux.dev \
--cc=nathan@kernel.org \
--cc=patches@lists.linux.dev \
--cc=rostedt@goodmis.org \
--cc=stable@vger.kernel.org \
--cc=tglozar@redhat.com \
--cc=thomas.weissschuh@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox