From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4C804A48; Mon, 4 Aug 2025 00:35:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754267716; cv=none; b=syTdeYlcre7tOrtlnsCkfkOA2stGs9lkrkP51rLjZ2VbgaKW+Z8H05gkeFQAbo/f8MQtioh7G1SM/LoLm/lW6cGP/EwYl/yk32yYCTPF/4oN93Qg9AMUBV/8FODpn/7qaK/3xkZMRLb20FZWGK09O4U4gffoVW2GynYpNM0/Ub8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754267716; c=relaxed/simple; bh=W+PRbtbPnTzXG7tuyl6D0vdO7SIw853bgOwQRTxjMYQ=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=fa9tuNfe8pRQ79OH0d2IbkIvNSOuUkInqP8nWRTo6JM+fusgbcncoKREB6SeluQXCquFU2ZZqYm5Qarin1gVQo5UXg0SmnUb7elep8MUEamxDs06K0XpTOy1ETvccUHzUQq7xKcN+I7erue0FWEO24DAuK/TSrx5nNcc8pvZODY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=SpxvGdch; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="SpxvGdch" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DB954C4CEEB; Mon, 4 Aug 2025 00:35:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1754267715; bh=W+PRbtbPnTzXG7tuyl6D0vdO7SIw853bgOwQRTxjMYQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=SpxvGdch5MHhFx3jwooUg9rLIprot2L+qb8/Z4zOOgk8umbRW8RoPXu1fcienOdUK GdStkiot9Ri/oJ61n+A/k67PaLAj7BZmiUWhMFIyFZVFUp3N7NEvZIn5+aUvk67nfI IRzwnYPtiVu1Br14gsTwO9I3PD/ETEaJyXeOtfWKeStf/xqyH11c3imprrtLo4TAov mQQgfERawKwDJIK7oVQ0N/kET+K51Hdf6ae7pyLWLLK4rNmETZ8d94tHzD9ta4F8YR kdsjxoQ8D0Kxes/N1E42ouCDL5/4RPpM7TRc8AyOABGIeQduBpm96SeO06ZWOuSG8i le2IVcrKGtpXw== From: Sasha Levin To: patches@lists.linux.dev, stable@vger.kernel.org Cc: "Masami Hiramatsu (Google)" , Steven Rostedt , Shuah Khan , Sasha Levin Subject: [PATCH AUTOSEL 6.6 25/59] selftests: tracing: Use mutex_unlock for testing glob filter Date: Sun, 3 Aug 2025 20:33:39 -0400 Message-Id: <20250804003413.3622950-25-sashal@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250804003413.3622950-1-sashal@kernel.org> References: <20250804003413.3622950-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.6.101 Content-Transfer-Encoding: 8bit From: "Masami Hiramatsu (Google)" [ Upstream commit a089bb2822a49b0c5777a8936f82c1f8629231fb ] Since commit c5b6ababd21a ("locking/mutex: implement mutex_trylock_nested") makes mutex_trylock() as an inlined function if CONFIG_DEBUG_LOCK_ALLOC=y, we can not use mutex_trylock() for testing the glob filter of ftrace. Use mutex_unlock instead. Link: https://lore.kernel.org/r/175151680309.2149615.9795104805153538717.stgit@mhiramat.tok.corp.google.com Signed-off-by: Masami Hiramatsu (Google) Acked-by: Steven Rostedt (Google) Signed-off-by: Shuah Khan Signed-off-by: Sasha Levin --- LLM Generated explanations, may be completely bogus: ## Backport Status: YES This commit should be backported to stable kernel trees for the following reasons: 1. **It fixes a test regression**: The commit c5b6ababd21a changed mutex_trylock() from being a regular function to an inline macro when CONFIG_DEBUG_LOCK_ALLOC=y. This broke the ftrace glob filter selftest that was trying to match functions with the pattern `mutex*try*`. Since mutex_trylock is no longer a regular function symbol in certain configurations, the test would fail. 2. **Simple and contained fix**: The change is minimal - it simply replaces the test pattern from `mutex*try*` to `mutex*unl*` on line 32. This is a one-line change that: - Changes the glob pattern from matching mutex_trylock functions to mutex_unlock functions - Maintains the same test logic and purpose (testing glob pattern matching) - mutex_unlock remains a regular function symbol regardless of CONFIG_DEBUG_LOCK_ALLOC 3. **No functional changes to kernel code**: This only affects a selftest, not any kernel functionality. The risk of regression is zero for normal kernel operation. 4. **Test reliability**: Without this fix, the ftrace selftest suite would fail on kernels built with CONFIG_DEBUG_LOCK_ALLOC=y after commit c5b6ababd21a is applied. This could: - Cause false test failures in CI/CD pipelines - Make it harder to detect real ftrace issues - Confuse developers running the test suite 5. **Clear dependency**: The commit message explicitly states this is needed "Since commit c5b6ababd21a" which indicates this is a direct fix for a known regression introduced by that specific commit. The change is exactly the type that stable rules recommend: it fixes a clear bug (test regression), is minimal in scope, has no risk of breaking functionality, and maintains test coverage for an important kernel feature (ftrace glob filtering). .../testing/selftests/ftrace/test.d/ftrace/func-filter-glob.tc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/ftrace/test.d/ftrace/func-filter-glob.tc b/tools/testing/selftests/ftrace/test.d/ftrace/func-filter-glob.tc index 4b994b6df5ac..ed81eaf2afd6 100644 --- a/tools/testing/selftests/ftrace/test.d/ftrace/func-filter-glob.tc +++ b/tools/testing/selftests/ftrace/test.d/ftrace/func-filter-glob.tc @@ -29,7 +29,7 @@ ftrace_filter_check 'schedule*' '^schedule.*$' ftrace_filter_check '*pin*lock' '.*pin.*lock$' # filter by start*mid* -ftrace_filter_check 'mutex*try*' '^mutex.*try.*' +ftrace_filter_check 'mutex*unl*' '^mutex.*unl.*' # Advanced full-glob matching feature is recently supported. # Skip the tests if we are sure the kernel does not support it. -- 2.39.5