From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 27B2923D7E5; Tue, 12 Aug 2025 17:49:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755020962; cv=none; b=nJ2inmc/jHM+4vt9Jbl4yWLOh6fAE5SWccwWrG8V68TFgFps3RYMYzMSCit05Rdc/TuStHCO9oQF/R5iWwss7hBtVXu4QY3i09fWmAZnPRsCMvDIZaqrxZwSpCVErqKnng0xBmQx48l5SayiIT5oaurEXbgqd2Pn+gmwWt6CtbE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755020962; c=relaxed/simple; bh=Z0aDafmPDBqfmTfW+BKoYxCQ3sphpo7mInnYbYFCyiY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=I26fFnS/8kgPB+h1MjZKKRD1YvaQgwNPmOOF/qWTOpF5nQ81eBQK0jsZ2vKCMyRXukcnH1y/HtqsgiMu3zYURA9M/e69loin6Cn+jWQyROF0dBn8PYwHEMJuC0qA8z0b6+9He4VVQ2r2LV63CfZ7GWvHKHtfRwrIxuwZJb+D93E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=zjqCllIW; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="zjqCllIW" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 81F6AC4CEF0; Tue, 12 Aug 2025 17:49:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1755020962; bh=Z0aDafmPDBqfmTfW+BKoYxCQ3sphpo7mInnYbYFCyiY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=zjqCllIWjagvhL8ElX4EOsEqjIB1GbTUyEg12HbhP6Uhf18ukFVuDzFQb9Z1yzVD1 d6vc8/4lYbXHivVSJhYmm/E08ld4HEXj9DszUv7GYqHFzCy/nMfEKCPYcFn/KsnrPj 8d+yJ4ISV+xuMV8UPVwV6d2W5n9V/equmLSx6DE4= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Bjorn Andersson , Johan Hovold , Konrad Dybcio , Bjorn Andersson , Sasha Levin Subject: [PATCH 6.6 043/262] soc: qcom: pmic_glink: fix OF node leak Date: Tue, 12 Aug 2025 19:27:11 +0200 Message-ID: <20250812172954.796225813@linuxfoundation.org> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250812172952.959106058@linuxfoundation.org> References: <20250812172952.959106058@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Johan Hovold [ Upstream commit 65702c3d293e45d3cac5e4e175296a9c90404326 ] Make sure to drop the OF node reference taken when registering the auxiliary devices when the devices are later released. Fixes: 58ef4ece1e41 ("soc: qcom: pmic_glink: Introduce base PMIC GLINK driver") Cc: Bjorn Andersson Signed-off-by: Johan Hovold Reviewed-by: Konrad Dybcio Link: https://lore.kernel.org/r/20250708085717.15922-1-johan@kernel.org Signed-off-by: Bjorn Andersson Signed-off-by: Sasha Levin --- drivers/soc/qcom/pmic_glink.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/soc/qcom/pmic_glink.c b/drivers/soc/qcom/pmic_glink.c index 7e50eeb4cc6f..2222ca4fa6e2 100644 --- a/drivers/soc/qcom/pmic_glink.c +++ b/drivers/soc/qcom/pmic_glink.c @@ -145,7 +145,10 @@ static int pmic_glink_rpmsg_callback(struct rpmsg_device *rpdev, void *data, return 0; } -static void pmic_glink_aux_release(struct device *dev) {} +static void pmic_glink_aux_release(struct device *dev) +{ + of_node_put(dev->of_node); +} static int pmic_glink_add_aux_device(struct pmic_glink *pg, struct auxiliary_device *aux, @@ -159,8 +162,10 @@ static int pmic_glink_add_aux_device(struct pmic_glink *pg, aux->dev.release = pmic_glink_aux_release; device_set_of_node_from_dev(&aux->dev, parent); ret = auxiliary_device_init(aux); - if (ret) + if (ret) { + of_node_put(aux->dev.of_node); return ret; + } ret = auxiliary_device_add(aux); if (ret) -- 2.39.5