From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BAFF33D994; Tue, 12 Aug 2025 19:21:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755026498; cv=none; b=oaKF+E9gYOM4gP0qtWY7dKnMR2s/MlNa5S5gwnDHdEIUPwzxcdVYpsj/XqVQtsSCGcp//+HjwH1Wfh7z/pgScH77qNlXudkxeNrNGDOrOj2Bdk/i2J7xf6bhzXVeS+cxUAZXn+tj7EogrMCPy1TKY96vxQVi7zHFP5opCOeXaUs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755026498; c=relaxed/simple; bh=laqwzQhNzDUvkmz1/Ms+tA4BVXIqJFkGbTchTMk5bPw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=FZU5NjI7boIWsvzH5f8J6uXu4LIpFh0x0jkaNo7+U50XlsoJ/zt5S9cq2X0PY1tPnMaophdSjusPZ3q9b/AfA9aFUlOaeNVrHquub+ovMeaqwmYLgAwDxg2oZsu7dtTlfPatWIoZvaDdXBVzVuVUBmOkEDs0mQIKIMa9bdbgCNs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=hq2gqgQ4; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="hq2gqgQ4" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 28144C4CEF0; Tue, 12 Aug 2025 19:21:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1755026498; bh=laqwzQhNzDUvkmz1/Ms+tA4BVXIqJFkGbTchTMk5bPw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hq2gqgQ45iQ19QEBhz7HSQEeWMhivEKZ08U9pa3v5mgDTH6imv4+biLgn9i1GyWQN KRxk5OpH3zulXam85HhspF30S6UdNu4k5C/naSYcgYPQ45xm4UNXxJh6F5M2mNkg6i nsCEpWfkL6/GPlwpYdKfBYMqd+NdrCjP0GyNaX/Q= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Chao Yu , Jaegeuk Kim , Sasha Levin Subject: [PATCH 6.15 355/480] f2fs: fix to avoid out-of-boundary access in devs.path Date: Tue, 12 Aug 2025 19:49:23 +0200 Message-ID: <20250812174412.077666896@linuxfoundation.org> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250812174357.281828096@linuxfoundation.org> References: <20250812174357.281828096@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Chao Yu [ Upstream commit 5661998536af52848cc4d52a377e90368196edea ] - touch /mnt/f2fs/012345678901234567890123456789012345678901234567890123 - truncate -s $((1024*1024*1024)) \ /mnt/f2fs/012345678901234567890123456789012345678901234567890123 - touch /mnt/f2fs/file - truncate -s $((1024*1024*1024)) /mnt/f2fs/file - mkfs.f2fs /mnt/f2fs/012345678901234567890123456789012345678901234567890123 \ -c /mnt/f2fs/file - mount /mnt/f2fs/012345678901234567890123456789012345678901234567890123 \ /mnt/f2fs/loop [16937.192225] F2FS-fs (loop0): Mount Device [ 0]: /mnt/f2fs/012345678901234567890123456789012345678901234567890123\xff\x01, 511, 0 - 3ffff [16937.192268] F2FS-fs (loop0): Failed to find devices If device path length equals to MAX_PATH_LEN, sbi->devs.path[] may not end up w/ null character due to path array is fully filled, So accidently, fields locate after path[] may be treated as part of device path, result in parsing wrong device path. struct f2fs_dev_info { ... char path[MAX_PATH_LEN]; ... }; Let's add one byte space for sbi->devs.path[] to store null character of device path string. Fixes: 3c62be17d4f5 ("f2fs: support multiple devices") Signed-off-by: Chao Yu Signed-off-by: Jaegeuk Kim Signed-off-by: Sasha Levin --- fs/f2fs/f2fs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h index 34e4ae2a5f5b..8a8d15c219dc 100644 --- a/fs/f2fs/f2fs.h +++ b/fs/f2fs/f2fs.h @@ -1273,7 +1273,7 @@ struct f2fs_bio_info { struct f2fs_dev_info { struct file *bdev_file; struct block_device *bdev; - char path[MAX_PATH_LEN]; + char path[MAX_PATH_LEN + 1]; unsigned int total_segments; block_t start_blk; block_t end_blk; -- 2.39.5