From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 11E432FE07B for ; Thu, 14 Aug 2025 13:24:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755177878; cv=none; b=XNZ360eH3XqcTNrv7GDJabAu87JWdVPzcU7+KfA4nsUtit+xAu5Ra3VGewGJQjB1g9JKpeVN8hrlA/so+EF+sX7TxzzUAkPg0HoSh9Nyw3raIfZQPfvp6wWpFgLiClSpomJSlvn4/KwUgdSEDCrn24rFhOBG858q0cxlSREn+Qc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755177878; c=relaxed/simple; bh=/2fk9X8cEhy8PxV0TGP9egxx8lwArN8MoEBAzd5Cgpo=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=OZV2SxV8KIHlkHfI7f3H1c2iiJF5DsRFvTUaQ0rlnTUKDBM32f3xNbAiD4QSMQiLfobnWp2gZA0ARxfzsIhvD+H2Q2jaGsIBHYu1JCOQbFwqtor1Teiq+PTY7I6rvoj2DvBC5NV2rA7CmZ7b1fM0Gay2+iuaLW0DcujsKK+yRpg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=gBZO1+2b; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="gBZO1+2b" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 06053C4CEEF; Thu, 14 Aug 2025 13:24:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1755177877; bh=/2fk9X8cEhy8PxV0TGP9egxx8lwArN8MoEBAzd5Cgpo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gBZO1+2bEDkh9WsQWvHq9ScRazHqp49yrZuEDdPO8UgnLmnOu2Ln9OIlm2xrt7dBJ WokLBYdPjtuFjE5sJe3UCVEz7WvvaRKoiWgjSUYWebuHdCYapj681PPioWIeqACrif J6hHa52A2tS0L61kxi/GlKcNP3eWouIK99mBxjGnv19ZiK5dMRHh+964yj3y8XirW6 nEbpP7uvScv/yIkxO0dk0ZmUnlsJeWpiiMd+k4mjBQQKNGUw6zz1TOXSe5PSGun6Xs UnDbfsNUIbKgisFA35lQQrs+2guzuAQVB5c5oyrdR+RgzapCVVtrJxaU3zBDMCcVsP bMyTwQpBLkr1A== From: Sasha Levin To: stable@vger.kernel.org Cc: Sean Christopherson , Dapeng Mi , Sasha Levin Subject: [PATCH 6.1.y 2/4] KVM: VMX: Extract checking of guest's DEBUGCTL into helper Date: Thu, 14 Aug 2025 09:24:32 -0400 Message-Id: <20250814132434.2096873-2-sashal@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250814132434.2096873-1-sashal@kernel.org> References: <2025081215-variable-implicit-aa4c@gregkh> <20250814132434.2096873-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Sean Christopherson [ Upstream commit 8a4351ac302cd8c19729ba2636acfd0467c22ae8 ] Move VMX's logic to check DEBUGCTL values into a standalone helper so that the code can be used by nested VM-Enter to apply the same logic to the value being loaded from vmcs12. KVM needs to explicitly check vmcs12->guest_ia32_debugctl on nested VM-Enter, as hardware may support features that KVM does not, i.e. relying on hardware to detect invalid guest state will result in false negatives. Unfortunately, that means applying KVM's funky suppression of BTF and LBR to vmcs12 so as not to break existing guests. No functional change intended. Reviewed-by: Dapeng Mi Link: https://lore.kernel.org/r/20250610232010.162191-6-seanjc@google.com Signed-off-by: Sean Christopherson Stable-dep-of: 7d0cce6cbe71 ("KVM: VMX: Wrap all accesses to IA32_DEBUGCTL with getter/setter APIs") Signed-off-by: Sasha Levin --- arch/x86/kvm/vmx/vmx.c | 29 +++++++++++++++++------------ 1 file changed, 17 insertions(+), 12 deletions(-) diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c index dac7883acdd2..164bbf7959be 100644 --- a/arch/x86/kvm/vmx/vmx.c +++ b/arch/x86/kvm/vmx/vmx.c @@ -2071,6 +2071,19 @@ static u64 vmx_get_supported_debugctl(struct kvm_vcpu *vcpu, bool host_initiated return debugctl; } +static bool vmx_is_valid_debugctl(struct kvm_vcpu *vcpu, u64 data, + bool host_initiated) +{ + u64 invalid; + + invalid = data & ~vmx_get_supported_debugctl(vcpu, host_initiated); + if (invalid & (DEBUGCTLMSR_BTF | DEBUGCTLMSR_LBR)) { + kvm_pr_unimpl_wrmsr(vcpu, MSR_IA32_DEBUGCTLMSR, data); + invalid &= ~(DEBUGCTLMSR_BTF | DEBUGCTLMSR_LBR); + } + return !invalid; +} + /* * Writes msr value into the appropriate "register". * Returns 0 on success, non-0 otherwise. @@ -2139,19 +2152,12 @@ static int vmx_set_msr(struct kvm_vcpu *vcpu, struct msr_data *msr_info) } vmcs_writel(GUEST_SYSENTER_ESP, data); break; - case MSR_IA32_DEBUGCTLMSR: { - u64 invalid; - - invalid = data & ~vmx_get_supported_debugctl(vcpu, msr_info->host_initiated); - if (invalid & (DEBUGCTLMSR_BTF|DEBUGCTLMSR_LBR)) { - kvm_pr_unimpl_wrmsr(vcpu, msr_index, data); - data &= ~(DEBUGCTLMSR_BTF|DEBUGCTLMSR_LBR); - invalid &= ~(DEBUGCTLMSR_BTF|DEBUGCTLMSR_LBR); - } - - if (invalid) + case MSR_IA32_DEBUGCTLMSR: + if (!vmx_is_valid_debugctl(vcpu, data, msr_info->host_initiated)) return 1; + data &= vmx_get_supported_debugctl(vcpu, msr_info->host_initiated); + if (is_guest_mode(vcpu) && get_vmcs12(vcpu)->vm_exit_controls & VM_EXIT_SAVE_DEBUG_CONTROLS) get_vmcs12(vcpu)->guest_ia32_debugctl = data; @@ -2161,7 +2167,6 @@ static int vmx_set_msr(struct kvm_vcpu *vcpu, struct msr_data *msr_info) (data & DEBUGCTLMSR_LBR)) intel_pmu_create_guest_lbr_event(vcpu); return 0; - } case MSR_IA32_BNDCFGS: if (!kvm_mpx_supported() || (!msr_info->host_initiated && -- 2.39.5