From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0E8D53002DA; Mon, 18 Aug 2025 09:39:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755509980; cv=none; b=DERORHuh9Pr6J+JGquGfw5Wt+jRh6Ag6ukiEFYIDI1O0tzwwWxMW09IB+8ISoXhuQGZc6HMGUT4ah8Zwql5Jum8stSVwoIdKAsR9Si1MRgsSd/u/x5GPgOox8j4Q5rVexA/egYOP/nSeGXuy7xcqxDvjfFvmb3o2xlXdSvdtaII= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755509980; c=relaxed/simple; bh=BrsZnAK67rffn+0XZgLh7UfzDYZXTZliO65sGTnWNVU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=WP8JQbEU0u0PN/Q8uwzTrqsc/SfaPr8DQtgUqqkBKjgZ9mWOKg/2kYoPZpVLFRGk4BsDAOktWdCymuvzmj3+8meVcv1IMJT+0ddL3MJVkM2018e1B93w4LGKKAeslWZXvJne+zB8+2eat35CEVZKlsozeXnoiSaZD+ocWIhRPbY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=ppxd1uu3; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="ppxd1uu3" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B8966C4CEEB; Mon, 18 Aug 2025 09:39:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1755509975; bh=BrsZnAK67rffn+0XZgLh7UfzDYZXTZliO65sGTnWNVU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ppxd1uu3hU2RkoqBy/Y4LqUSfdw5bgCMaBlz5xxpF/UqJDZxHfs7bEFCGShAn9vAw jSVq9IHtWyXprU9PU33BhFh+HYBE4UiDFCmvmaJ8pkC7uCCK3kwMv9bI12MDtuAtk4 czSc5Hry3VnUc5yA7XowYXT3xRpQZEJ5qeFoXCKg= Date: Mon, 18 Aug 2025 11:39:32 +0200 From: Greg KH To: Yu Kuai Cc: stable@vger.kernel.org, stable-commits@vger.kernel.org, xni@redhat.com, Song Liu , "yukuai (C)" Subject: Re: Patch "md: call del_gendisk in control path" has been added to the 6.6-stable tree Message-ID: <2025081812-stalemate-hug-a179@gregkh> References: <20250817141818.2370452-1-sashal@kernel.org> <7748b907-8279-c222-d4e4-b94c3216408b@huaweicloud.com> <2025081846-veneering-radish-498d@gregkh> <0c083639-eb30-2830-0938-20684db3914a@huaweicloud.com> <2025081804-gloater-brought-c097@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Mon, Aug 18, 2025 at 03:13:11PM +0800, Yu Kuai wrote: > Hi, > > 在 2025/08/18 14:38, Greg KH 写道: > > On Mon, Aug 18, 2025 at 02:26:23PM +0800, Yu Kuai wrote: > > > Hi, > > > > > > 在 2025/08/18 13:55, Greg KH 写道: > > > > On Mon, Aug 18, 2025 at 09:03:39AM +0800, Yu Kuai wrote: > > > > > Hi, > > > > > > > > > > 在 2025/08/17 22:18, Sasha Levin 写道: > > > > > > This is a note to let you know that I've just added the patch titled > > > > > > > > > > > > md: call del_gendisk in control path > > > > > > > > > > > > to the 6.6-stable tree which can be found at: > > > > > > http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary > > > > > > > > > > > > The filename of the patch is: > > > > > > md-call-del_gendisk-in-control-path.patch > > > > > > and it can be found in the queue-6.6 subdirectory. > > > > > > > > > > > > If you, or anyone else, feels it should not be added to the stable tree, > > > > > > please let know about it. > > > > > > > > > > > > > > > > > This patch should be be backported to any stable kernel, this change > > > > > will break user tools mdadm: > > > > > > > > > > https://lore.kernel.org/all/f654db67-a5a5-114b-09b8-00db303daab7@redhat.com/ > > > > > > > > Is it reverted in Linus's tree? > > > > > > > > > > No, we'll not revert it, this is an improvement. In order to keep user > > > tools compatibility, we added a switch in the kernel. As discussed in > > > the thread, for old tools + new kernel, functionality is the same, > > > however, there will be kernel warning about deprecated behaviour to > > > inform user upgrading user tools. > > > > > > However, I feel this new warning messages is not acceptable for > > > stable kernels. > > > > Why? What is so special about stable kernels that taking the same > > functionality in newer kernels is not ok? > > > > Why not just "warn" the same here if you want to fix an issue where > > userspace should be also updating some tools. As long as you aren't > > breaking anything, it should be fine, right? > > Yes, it's fine, just in downstream kernels, people won't be happy about > new warnings. People are NEVER happy about new warnings. So why are you warning them at all in newer kernels? > > Or are you breaking existing workflows? You should be able to take a > > new kernel without any userspace changes and all should work the same. > > Why make new kernel users change userspace tools at all? > > There is a pending fix in mdraid that will be pushed soon, with this > nothing will be broken. Great, what is the git id? > And because user tools have problems in this case as well, both kernel > and user tools have to be fixed to make things better. So Linus's tree right now doesn't work without the pending fix as well? thanks, greg k-h