From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E2263469ED; Mon, 18 Aug 2025 17:28:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755538094; cv=none; b=bgrqVOc2eK33B241WQ8GqdRnsP6lww5lv2kAqdVB0rHz5+nHH3Nx8JXlt9xZ65LxXu7s69+ojMPln7Ou4bMPpFdlAYlfBlTUZwufhiQQ6WHN7EBE7beYHBZUu/24veBrO719SfGjPaaVv7jfaqTb2RWMJOYgPB2ZK6xK97b+ns0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755538094; c=relaxed/simple; bh=HWzA4+Gih2cDfc63knODOHQaSPBHO6bpOvS3OtgIgYw=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=V1ETglXUoJjmbbafEznIeTv9qOJRVyRAbd795lBfPuQwvSLeTseBgAqdUiYjcg280RSELPMJg1SDHUZ+9L62241kO7yVunBpt57ip9GEINbD6R7jpKNUswiMDwiYmqrDkslRv1BtyUdwpcEz1Kp2TPZhZKLOj2SxoIayRwOi5KE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=kINGL4l0; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="kINGL4l0" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 09FBEC4CEEB; Mon, 18 Aug 2025 17:28:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1755538094; bh=HWzA4+Gih2cDfc63knODOHQaSPBHO6bpOvS3OtgIgYw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kINGL4l04xoFYnb/j3hSFXN0AjBJwUWc2u4Dlw5FVyV6FSurXmIlNBZh05KXgAFwo ynXdsDxg2Z/MB6wDTZH5I8fdLC3xXTTgvUhoWavYf0n7kMzf5B8g2qXQ1O9X+1MWIS dmAlijGio0uuEsySysBP5DgV19iUE79AEQrqhD5FAF5UWsnLIzs0woeimRpkApLBGr BjubKINXn4V8rl9/6HnQItyIgxA+NCs4yXREaaAltz5k3dTNku3wFrx6o+4pF8vl7U uIZ3TdkAj5BCxjifG8p/yLQIxLS+oP6zmdzz7f4nnoJ+rWJUxtmGHMkXXYdwm34RmA wikfr1mEBDd9Q== From: SeongJae Park To: stable@vger.kernel.org Cc: damon@lists.linux.dev, SeongJae Park , Joshua Hahn , Honggyu Kim , Hyeongtak Ji , Andrew Morton Subject: [PATCH 6.16.y] mm/damon/ops-common: ignore migration request to invalid nodes Date: Mon, 18 Aug 2025 10:28:07 -0700 Message-Id: <20250818172807.54991-1-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <2025081831-singular-geologist-93a6@gregkh> References: <2025081831-singular-geologist-93a6@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit damon_migrate_pages() tries migration even if the target node is invalid. If users mistakenly make such invalid requests via DAMOS_MIGRATE_{HOT,COLD} action, the below kernel BUG can happen. [ 7831.883495] BUG: unable to handle page fault for address: 0000000000001f48 [ 7831.884160] #PF: supervisor read access in kernel mode [ 7831.884681] #PF: error_code(0x0000) - not-present page [ 7831.885203] PGD 0 P4D 0 [ 7831.885468] Oops: Oops: 0000 [#1] SMP PTI [ 7831.885852] CPU: 31 UID: 0 PID: 94202 Comm: kdamond.0 Not tainted 6.16.0-rc5-mm-new-damon+ #93 PREEMPT(voluntary) [ 7831.886913] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.16.3-4.el9 04/01/2014 [ 7831.887777] RIP: 0010:__alloc_frozen_pages_noprof (include/linux/mmzone.h:1724 include/linux/mmzone.h:1750 mm/page_alloc.c:4936 mm/page_alloc.c:5137) [...] [ 7831.895953] Call Trace: [ 7831.896195] [ 7831.896397] __folio_alloc_noprof (mm/page_alloc.c:5183 mm/page_alloc.c:5192) [ 7831.896787] migrate_pages_batch (mm/migrate.c:1189 mm/migrate.c:1851) [ 7831.897228] ? __pfx_alloc_migration_target (mm/migrate.c:2137) [ 7831.897735] migrate_pages (mm/migrate.c:2078) [ 7831.898141] ? __pfx_alloc_migration_target (mm/migrate.c:2137) [ 7831.898664] damon_migrate_folio_list (mm/damon/ops-common.c:321 mm/damon/ops-common.c:354) [ 7831.899140] damon_migrate_pages (mm/damon/ops-common.c:405) [...] Add a target node validity check in damon_migrate_pages(). The validity check is stolen from that of do_pages_move(), which is being used for the move_pages() system call. Link: https://lkml.kernel.org/r/20250720185822.1451-1-sj@kernel.org Fixes: b51820ebea65 ("mm/damon/paddr: introduce DAMOS_MIGRATE_COLD action for demotion") [6.11.x] Signed-off-by: SeongJae Park Reviewed-by: Joshua Hahn Cc: Honggyu Kim Cc: Hyeongtak Ji Cc: Signed-off-by: Andrew Morton (cherry picked from commit 7e6c3130690a01076efdf45aa02ba5d5c16849a0) Signed-off-by: SeongJae Park --- mm/damon/paddr.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/mm/damon/paddr.c b/mm/damon/paddr.c index 4102a8c5f992..578546ef74a0 100644 --- a/mm/damon/paddr.c +++ b/mm/damon/paddr.c @@ -476,6 +476,10 @@ static unsigned long damon_pa_migrate_pages(struct list_head *folio_list, if (list_empty(folio_list)) return nr_migrated; + if (target_nid < 0 || target_nid >= MAX_NUMNODES || + !node_state(target_nid, N_MEMORY)) + return nr_migrated; + noreclaim_flag = memalloc_noreclaim_save(); nid = folio_nid(lru_to_folio(folio_list)); -- 2.39.5