From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A8D491AAE17 for ; Mon, 18 Aug 2025 19:32:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755545565; cv=none; b=eJaSY5coDQfiGVQs9TERMYW842TiwtalrCzRxwF5kP8/Xh9bc4XN2/Xu6jJazRwAsrKN0o3K9MJFMFjvKCIXlghg61huFQgeyibz8/L6z3Y5c3rVWXrY+jbJWKOUyAvmZGbd3ky6yyOG8FT2cGR673PdQTKrFAEIjaXC+IKLxEU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755545565; c=relaxed/simple; bh=UIj0IjUJ9CunTqlOeE2E8hT1Aa3SCPU+AuQeIweRqz4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=d2ztqQH+xp70BtJFnKjY7jFsayyeC72h67hNVxoRDerk+aDNKMmVyuRybl+VIV7HUr6D8ZKh4yJqO+0zT2pgScQSS8LuJ72LffZJk2lYV3j2H+hXXad1rpFM0+xTQw33jyz8JXMeQSyvoaidk6GZJvddJzXWjzxQ4cvq5BDyUlA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=njWlX692; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="njWlX692" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9C1D1C4CEED; Mon, 18 Aug 2025 19:32:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1755545564; bh=UIj0IjUJ9CunTqlOeE2E8hT1Aa3SCPU+AuQeIweRqz4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=njWlX692UhnloLSBxrc6puWqTMtk0MUZSu03krpu64sdOx1Gf/byCfI9kEixD8TLi ZfCvtbdX/WIrs396iUcEBK25f8/otgYlwfQohBJrL1/HyLfJwW4gxK/XrrDVP0sGE0 v5fQbZF//i4xAPldd5OgIWlB5j3C5n3ihGQGu97gdKbdDj/jtDjcug8rd3CJX1Kh53 I5gBLVikTDzEYkjPN/RWGCcoA4BTNihIv6O6cLve8x7ouX9gxjstX5c0K8KnHdRlFR VW+k1oym7t8W9/kXQts9FK1NJlbbf668oMyYYvHN5VK83rhcPa0PvK1kH27iXWNgEj 9az8tzwyaPxJw== From: Sasha Levin To: stable@vger.kernel.org Cc: Sebastian Reichel , stable , Heikki Krogerus , Greg Kroah-Hartman , Sasha Levin Subject: [PATCH 6.12.y 2/2] usb: typec: fusb302: cache PD RX state Date: Mon, 18 Aug 2025 15:32:40 -0400 Message-ID: <20250818193240.50566-2-sashal@kernel.org> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250818193240.50566-1-sashal@kernel.org> References: <2025081830-selected-dandelion-46ec@gregkh> <20250818193240.50566-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Sebastian Reichel [ Upstream commit 1e61f6ab08786d66a11cfc51e13d6f08a6b06c56 ] This patch fixes a race condition communication error, which ends up in PD hard resets when losing the race. Some systems, like the Radxa ROCK 5B are powered through USB-C without any backup power source and use a FUSB302 chip to do the PD negotiation. This means it is quite important to avoid hard resets, since that effectively kills the system's power-supply. I've found the following race condition while debugging unplanned power loss during booting the board every now and then: 1. lots of TCPM/FUSB302/PD initialization stuff 2. TCPM ends up in SNK_WAIT_CAPABILITIES (tcpm_set_pd_rx is enabled here) 3. the remote PD source does not send anything, so TCPM does a SOFT RESET 4. TCPM ends up in SNK_WAIT_CAPABILITIES for the second time (tcpm_set_pd_rx is enabled again, even though it is still on) At this point I've seen broken CRC good messages being send by the FUSB302 with a logic analyzer sniffing the CC lines. Also it looks like messages are being lost and things generally going haywire with one of the two sides doing a hard reset once a broken CRC good message was send to the bus. I think the system is running into a race condition, that the FIFOs are being cleared and/or the automatic good CRC message generation flag is being updated while a message is already arriving. Let's avoid this by caching the PD RX enabled state, as we have already processed anything in the FIFOs and are in a good state. As a side effect that this also optimizes I2C bus usage :) As far as I can tell the problem theoretically also exists when TCPM enters SNK_WAIT_CAPABILITIES the first time, but I believe this is less critical for the following reason: On devices like the ROCK 5B, which are powered through a TCPM backed USB-C port, the bootloader must have done some prior PD communication (initial communication must happen within 5 seconds after plugging the USB-C plug). This means the first time the kernel TCPM state machine reaches SNK_WAIT_CAPABILITIES, the remote side is not sending messages actively. On other devices a hard reset simply adds some extra delay and things should be good afterwards. Fixes: c034a43e72dda ("staging: typec: Fairchild FUSB302 Type-c chip driver") Cc: stable Signed-off-by: Sebastian Reichel Reviewed-by: Heikki Krogerus Link: https://lore.kernel.org/r/20250704-fusb302-race-condition-fix-v1-1-239012c0e27a@kernel.org Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/usb/typec/tcpm/fusb302.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/usb/typec/tcpm/fusb302.c b/drivers/usb/typec/tcpm/fusb302.c index f15c63d3a8f4..870a71f953f6 100644 --- a/drivers/usb/typec/tcpm/fusb302.c +++ b/drivers/usb/typec/tcpm/fusb302.c @@ -104,6 +104,7 @@ struct fusb302_chip { bool vconn_on; bool vbus_on; bool charge_on; + bool pd_rx_on; bool vbus_present; enum typec_cc_polarity cc_polarity; enum typec_cc_status cc1; @@ -841,6 +842,11 @@ static int tcpm_set_pd_rx(struct tcpc_dev *dev, bool on) int ret = 0; mutex_lock(&chip->lock); + if (chip->pd_rx_on == on) { + fusb302_log(chip, "pd is already %s", str_on_off(on)); + goto done; + } + ret = fusb302_pd_rx_flush(chip); if (ret < 0) { fusb302_log(chip, "cannot flush pd rx buffer, ret=%d", ret); @@ -863,6 +869,8 @@ static int tcpm_set_pd_rx(struct tcpc_dev *dev, bool on) str_on_off(on), ret); goto done; } + + chip->pd_rx_on = on; fusb302_log(chip, "pd := %s", str_on_off(on)); done: mutex_unlock(&chip->lock); -- 2.50.1