From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 760891C4A20; Mon, 18 Aug 2025 11:32:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755516755; cv=none; b=jXeFSb5AMHXz1Ag57BCn7dr4ZmBcpy+dz7g46wREocO/MtGPFPW9xBcza+ngVdsrNbUPtqQWqsTGjrs5OoOs5D3KZe7BNkoC5Y2jPRVtT5EMgablj+SmFncxMB9/epXcWeq6kc31mUat4UDi2ammyut3rPrdMxOTg4VTABTRiVE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755516755; c=relaxed/simple; bh=OEyi5yHREVDomYliCb+RiP5YrndamhvCmhCRx40LSP4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Ub7qiQv9fzVBPeuk63d5FOTzXOi0S8tNDq82xGx9ePYIhjHRPLn+0XfDlfVdzj6iPz76A2XYc9om17kJk4sulr3u/64KeRjsA3Zrpm3Rpf5DuajXtIhlr9WK5SV4lcg4ZnHSdbtKB26DrmC6iBdPnG0aDs56S8JMVtKeoWNYtEo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=u9sd1N9O; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="u9sd1N9O" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5340FC4CEEB; Mon, 18 Aug 2025 11:32:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1755516755; bh=OEyi5yHREVDomYliCb+RiP5YrndamhvCmhCRx40LSP4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=u9sd1N9OkQ4EfKniJMRHqKpeFy+xxWE/m1rcGVex96M+ssNTEUrZVgTlSd3u9oUQI ewchyMlP4xFtzbLdA3WcfO6pOb9BIDER7hfWjszyUVE4rPND83vFOHSHz+iXqwfPu1 drBMjAyMvDEH/7ZNwVkzWEdvTeV2KQfG6PfjLeSs= Date: Mon, 18 Aug 2025 13:32:31 +0200 From: Greg Kroah-Hartman To: Naman Jain Cc: stable@vger.kernel.org, patches@lists.linux.dev, Saurabh Sengar , Long Li , Wei Liu Subject: Re: [PATCH 6.12 020/158] tools/hv: fcopy: Fix irregularities with size of ring buffer Message-ID: <2025081825-freezing-feisty-9978@gregkh> References: <20250722134340.596340262@linuxfoundation.org> <20250722134341.490321531@linuxfoundation.org> <2025072316-mop-manhood-b63e@gregkh> <08158da3-82a0-4eb0-a805-87afe34e288a@linux.microsoft.com> <2025081834-bullfrog-elixir-6a96@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Aug 18, 2025 at 12:17:56PM +0530, Naman Jain wrote: > > > On 8/18/2025 11:22 AM, Greg Kroah-Hartman wrote: > > On Mon, Aug 18, 2025 at 10:54:10AM +0530, Naman Jain wrote: > > > > > > > > > On 7/23/2025 12:12 PM, Greg Kroah-Hartman wrote: > > > > On Tue, Jul 22, 2025 at 08:29:07PM +0530, Naman Jain wrote: > > > > > > > > > > > > > > > On 7/22/2025 7:13 PM, Greg Kroah-Hartman wrote: > > > > > > 6.12-stable review patch. If anyone has any objections, please let me know. > > > > > > > > > > > > ------------------ > > > > > > > > > > > > From: Naman Jain > > > > > > > > > > > > commit a4131a50d072b369bfed0b41e741c41fd8048641 upstream. > > > > > > > > > > > > Size of ring buffer, as defined in uio_hv_generic driver, is no longer > > > > > > fixed to 16 KB. This creates a problem in fcopy, since this size was > > > > > > hardcoded. With the change in place to make ring sysfs node actually > > > > > > reflect the size of underlying ring buffer, it is safe to get the size > > > > > > of ring sysfs file and use it for ring buffer size in fcopy daemon. > > > > > > Fix the issue of disparity in ring buffer size, by making it dynamic > > > > > > in fcopy uio daemon. > > > > > > > > > > > > Cc: stable@vger.kernel.org > > > > > > Fixes: 0315fef2aff9 ("uio_hv_generic: Align ring size to system page") > > > > > > Signed-off-by: Naman Jain > > > > > > Reviewed-by: Saurabh Sengar > > > > > > Reviewed-by: Long Li > > > > > > Link: https://lore.kernel.org/r/20250711060846.9168-1-namjain@linux.microsoft.com > > > > > > Signed-off-by: Wei Liu > > > > > > Message-ID: <20250711060846.9168-1-namjain@linux.microsoft.com> > > > > > > Signed-off-by: Greg Kroah-Hartman > > > > > > --- > > > > > > > > > > > > > > > Hello Greg, > > > > > Please don't pick this change yet. I have shared the reason in the other > > > > > thread: > > > > > "Re: Patch "tools/hv: fcopy: Fix irregularities with size of ring buffer" > > > > > has been added to the 6.12-stable tree" > > > > > > > > Ok, I have dropped this from the 6.12.y tree now. > > > > > > > > thanks, > > > > > > > > greg k-h > > > > > > Hello Greg, > > > Can you please consider picking this change for next release of 6.12 kernel. > > > The dependent change [1] is now part of 6.12 kernel, so we need this change > > > to fix fcopy in 6.12 kernel. > > > > > > [1]: Drivers: hv: Make the sysfs node size for the ring buffer dynamic > > > > What are the exact git commit ids you want to have applied here? [1] > > does not reference much to me :) > > > > thanks, > > > > greg k-h > > My bad :) > > Please pick the commit a4131a50d072 ("tools/hv: fcopy: Fix irregularities > with size of ring buffer") in next 6.12 release, which is supposed to fix > fcopy. > > > The commit which added the missing dependency is now already part of > v6.12.42 kernel > c7f864d34529 ("Drivers: hv: Make the sysfs node size for the ring buffer > dynamic") Now queued up, thanks. greg k-h