From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1DA8B3451D0 for ; Tue, 19 Aug 2025 00:57:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755565071; cv=none; b=SOA9QHqOVBJZ3cRMFNbpSxSPTOGOR7j9zmU4pgvYylxLFR1Hof8mqtvnyy+mxdtGR54qoEmd9//mkBAauPR/Li5LNE0gdNzyWasG9jCP9LkkONUO7LNWeqOCv+jFeUN8YecUXA47p3k0mn/q8heTlpbwpGFBdLTC5P3vZtul5GE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755565071; c=relaxed/simple; bh=1e0CbNRQYt6uL6D39abTaM1QnClAvTmFRDSodArb3Yg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=byOdKV1H7jv56ZLOmCqFKHnrpyqMUSqKDjLHZ20uSvQVeq8sZfbQn2HCc5SRZtHfh4jfaDEIilIxY3CcMMzMdyk8S+Dt7nFmTfMK08BQr40WKjsym5/WyjWoSmJncsC7SKFeJtRlIjW16MuIbagLPdEC0kQIw5OyvfDshvCDH1o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=JWleU2mL; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="JWleU2mL" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 07604C4CEEB; Tue, 19 Aug 2025 00:57:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1755565070; bh=1e0CbNRQYt6uL6D39abTaM1QnClAvTmFRDSodArb3Yg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JWleU2mLyYLxOziBZb6rsBUTmimHdiw2nmJTMV2bW3hivHwNV5j8C/APTPEg1Lolm We0YxY7Tn/VInHnLfq/C6VqPAjMLzo6R6r6Bm74vIOpRedKJtJCnIa0YEsAQhAP2HW hRyLaYeH1j+35uya4vkfzGZnAJ68j0ySOf7IqrhhTiHO4HioVQ0aobEDzsFBG9TezH YGlcp+sWLPee8FDPucLAp1g6Vc3ubJt/frURw1RBE0DiNTcGkMsgVJ1/B6Chd7DQRX rNUzoVVbX17tZFxMAZT6VuPUu1XCDLZPg5Y0NWJTLVFurzaPHlOioBFa0NJ6OfKLhh WjIUepUBMTKrQ== From: Sasha Levin To: stable@vger.kernel.org Cc: Filipe Manana , Daniel Vacek , Qu Wenruo , David Sterba , Sasha Levin Subject: [PATCH 6.15.y] btrfs: abort transaction on unexpected eb generation at btrfs_copy_root() Date: Mon, 18 Aug 2025 20:57:48 -0400 Message-ID: <20250819005748.234482-1-sashal@kernel.org> X-Mailer: git-send-email 2.50.1 In-Reply-To: <2025081815-mothproof-embody-49e3@gregkh> References: <2025081815-mothproof-embody-49e3@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Filipe Manana [ Upstream commit 33e8f24b52d2796b8cfb28c19a1a7dd6476323a8 ] If we find an unexpected generation for the extent buffer we are cloning at btrfs_copy_root(), we just WARN_ON() and don't error out and abort the transaction, meaning we allow to persist metadata with an unexpected generation. Instead of warning only, abort the transaction and return -EUCLEAN. CC: stable@vger.kernel.org # 6.1+ Reviewed-by: Daniel Vacek Reviewed-by: Qu Wenruo Signed-off-by: Filipe Manana Reviewed-by: David Sterba Signed-off-by: David Sterba Signed-off-by: Sasha Levin --- fs/btrfs/ctree.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/fs/btrfs/ctree.c b/fs/btrfs/ctree.c index 648531fe0900..df06c9c3d406 100644 --- a/fs/btrfs/ctree.c +++ b/fs/btrfs/ctree.c @@ -283,7 +283,14 @@ int btrfs_copy_root(struct btrfs_trans_handle *trans, write_extent_buffer_fsid(cow, fs_info->fs_devices->metadata_uuid); - WARN_ON(btrfs_header_generation(buf) > trans->transid); + if (unlikely(btrfs_header_generation(buf) > trans->transid)) { + btrfs_tree_unlock(cow); + free_extent_buffer(cow); + ret = -EUCLEAN; + btrfs_abort_transaction(trans, ret); + return ret; + } + if (new_root_objectid == BTRFS_TREE_RELOC_OBJECTID) ret = btrfs_inc_ref(trans, root, cow, 1); else -- 2.50.1