From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 72B384A35 for ; Tue, 19 Aug 2025 02:18:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755569926; cv=none; b=VVMZZjp9uYdRx/1O6KKxZrgEKK0+pThONMou+7Sm/BqdigIbc/23BKOPmNqvTjbwGApJ7LQEtE/B5ffvyZgZ7UY9szFcl8P7W5jdI0xtSeas+KXXFEHkvGn6TmNRFQXb25NWyI/weyyjcj3YsVXW+tzyzzF6+znWisFVVNIkJiY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755569926; c=relaxed/simple; bh=EaueBH7i7n8PUNBQ8jZOxBS0xErf5iYZirSzP0Y3Q5A=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=nNvhOJPMHZFEW06HRGpo4j1w8xuAlwo4m/Lg4lQqgWgtrLy899anDDIYN9HUJalzoKYemTp5NDUkzz7m5mBecWuVpwkAtFFbN4zTHUMDrujovDWesAVLlCdcYkaltZLDcHgWEPjIQ3xo6bycgGmkBdxcWYauHEkMvUBvcxVWIYY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=d8bAjiHj; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="d8bAjiHj" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 94A0DC4CEEB; Tue, 19 Aug 2025 02:18:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1755569926; bh=EaueBH7i7n8PUNBQ8jZOxBS0xErf5iYZirSzP0Y3Q5A=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=d8bAjiHjc6e0sDZeP6cik1PSPCq2RxTCdKW/dlGjLaXJ+6ZZ9LVJMI88QZiNCAZD6 MtdukqfN9pv4l3+CzIWdtgnNSz5kumKgnoYbMO9luwoGLtInOkTT8Q67iSoZ3+5ai3 5Cjv0H0RRC5vthfEYIhiNEeWyB25KWl+bLWwV4yreFvRmQXTDV/pzZECGVy+Ztv69K frCcih0M3QDZ3XtF9pM/uDQevi8F8zPSR5Q+QVTptP6KNyuFv0c2OwandJdIJDkfuN 41nZONut5Sxc9++HxTK3+/gaQfG1yLZwKaM7pUE+vNl7UjW9Mwym/BVeArTa9Vi4U2 eXPb81XvbN2lQ== From: Sasha Levin To: stable@vger.kernel.org Cc: Christoph Hellwig , cen zhang , "Darrick J. Wong" , Carlos Maiolino , Sasha Levin Subject: [PATCH 6.12.y] xfs: fully decouple XFS_IBULK* flags from XFS_IWALK* flags Date: Mon, 18 Aug 2025 22:18:43 -0400 Message-ID: <20250819021843.277367-1-sashal@kernel.org> X-Mailer: git-send-email 2.50.1 In-Reply-To: <2025081858-issuing-conclude-4ff3@gregkh> References: <2025081858-issuing-conclude-4ff3@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Christoph Hellwig [ Upstream commit d2845519b0723c5d5a0266cbf410495f9b8fd65c ] Fix up xfs_inumbers to now pass in the XFS_IBULK* flags into the flags argument to xfs_inobt_walk, which expects the XFS_IWALK* flags. Currently passing the wrong flags works for non-debug builds because the only XFS_IWALK* flag has the same encoding as the corresponding XFS_IBULK* flag, but in debug builds it can trigger an assert that no incorrect flag is passed. Instead just extra the relevant flag. Fixes: 5b35d922c52798 ("xfs: Decouple XFS_IBULK flags from XFS_IWALK flags") Cc: # v5.19 Reported-by: cen zhang Signed-off-by: Christoph Hellwig Reviewed-by: Darrick J. Wong Signed-off-by: Carlos Maiolino Signed-off-by: Sasha Levin --- fs/xfs/xfs_itable.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/fs/xfs/xfs_itable.c b/fs/xfs/xfs_itable.c index c0757ab99495..dc395cd2f33b 100644 --- a/fs/xfs/xfs_itable.c +++ b/fs/xfs/xfs_itable.c @@ -430,11 +430,15 @@ xfs_inumbers( .breq = breq, }; struct xfs_trans *tp; + unsigned int iwalk_flags = 0; int error = 0; if (xfs_bulkstat_already_done(breq->mp, breq->startino)) return 0; + if (breq->flags & XFS_IBULK_SAME_AG) + iwalk_flags |= XFS_IWALK_SAME_AG; + /* * Grab an empty transaction so that we can use its recursive buffer * locking abilities to detect cycles in the inobt without deadlocking. @@ -443,7 +447,7 @@ xfs_inumbers( if (error) goto out; - error = xfs_inobt_walk(breq->mp, tp, breq->startino, breq->flags, + error = xfs_inobt_walk(breq->mp, tp, breq->startino, iwalk_flags, xfs_inumbers_walk, breq->icount, &ic); xfs_trans_cancel(tp); out: -- 2.50.1