From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C3444275869 for ; Tue, 19 Aug 2025 15:09:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755616165; cv=none; b=G24m9I9mzl21xWJ2NFNVKu6EyBJvAowU5jy5u6JX11DEa4g5Idxis+Xc8rCJSzkZb8Oa2uZVXBcl10CzLNHJWBqv1J5ZfqFxVSvjoOheF0Tpk4/TUf3EsUhEdgYheVG3pVT6SRD13Fi/0b9hEOn6jxjb7akNN+YpeGErhsvwBx4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755616165; c=relaxed/simple; bh=F0Cazv/nUneVxg/OX2mXmQxiiVPn9I+OHR6NG4tW2to=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=DAxulsMT8d/DMMJAQBwnU3kzGJ59H7tVGf0m/SH0Od0BvitnoSB+ghWTx4NC9OH5MkpJQvz8aukOwRoe4dYu0maml1oFmtD1J02C865Yp5odivtTFm+IEmWOd0is2+jp/U/mmPMSml30aNGim3K561mAapEPWjLakjQJ7tzKMJs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=QOUCYKwq; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="QOUCYKwq" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B77E7C4CEF1; Tue, 19 Aug 2025 15:09:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1755616165; bh=F0Cazv/nUneVxg/OX2mXmQxiiVPn9I+OHR6NG4tW2to=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=QOUCYKwqyjDEkHbkP6Ge2MS3PivWImupnWkl5rBBFVk0Cw5RauVG1jMf9emvV4G2Y cekxnx3ILLHmVXi2WdyrKn96LKjBvexrykrmtFup4bJWkw8g+SdPrqLmlu5lmnkEcl /Ujofh3tSWcO2VcA5q0ankJenMjp/my7Sh+JIWUqO2G+YKjXAek0G7bZvtX1KFRbgf cyoQhDDkuFBbTuyujujN2EwXJCg49CSs4GVpgQceMwPnzcIKoWzmL2jP9NxEjCF+S2 hraPDG2oYSyLf+PMIEzYGm/0niAkLxbpWOIC0QOfVb6jCyRrnGZKU1XiVrKxJgtujP Gz41tkxQH3GbQ== From: Sasha Levin To: stable@vger.kernel.org Cc: Anshuman Khandual , David Hildenbrand , Dev Jain , Alexander Gordeev , Catalin Marinas , Will Deacon , Ryan Roberts , Paul Walmsley , Palmer Dabbelt , Gerald Schaefer , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Sven Schnelle , Andrew Morton , Sasha Levin Subject: [PATCH 5.10.y] mm/ptdump: take the memory hotplug lock inside ptdump_walk_pgd() Date: Tue, 19 Aug 2025 11:09:21 -0400 Message-ID: <20250819150921.531532-1-sashal@kernel.org> X-Mailer: git-send-email 2.50.1 In-Reply-To: <2025081801-undertake-nuzzle-c4b1@gregkh> References: <2025081801-undertake-nuzzle-c4b1@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Anshuman Khandual [ Upstream commit 59305202c67fea50378dcad0cc199dbc13a0e99a ] Memory hot remove unmaps and tears down various kernel page table regions as required. The ptdump code can race with concurrent modifications of the kernel page tables. When leaf entries are modified concurrently, the dump code may log stale or inconsistent information for a VA range, but this is otherwise not harmful. But when intermediate levels of kernel page table are freed, the dump code will continue to use memory that has been freed and potentially reallocated for another purpose. In such cases, the ptdump code may dereference bogus addresses, leading to a number of potential problems. To avoid the above mentioned race condition, platforms such as arm64, riscv and s390 take memory hotplug lock, while dumping kernel page table via the sysfs interface /sys/kernel/debug/kernel_page_tables. Similar race condition exists while checking for pages that might have been marked W+X via /sys/kernel/debug/kernel_page_tables/check_wx_pages which in turn calls ptdump_check_wx(). Instead of solving this race condition again, let's just move the memory hotplug lock inside generic ptdump_check_wx() which will benefit both the scenarios. Drop get_online_mems() and put_online_mems() combination from all existing platform ptdump code paths. Link: https://lkml.kernel.org/r/20250620052427.2092093-1-anshuman.khandual@arm.com Fixes: bbd6ec605c0f ("arm64/mm: Enable memory hot remove") Signed-off-by: Anshuman Khandual Acked-by: David Hildenbrand Reviewed-by: Dev Jain Acked-by: Alexander Gordeev [s390] Cc: Catalin Marinas Cc: Will Deacon Cc: Ryan Roberts Cc: Paul Walmsley Cc: Palmer Dabbelt Cc: Alexander Gordeev Cc: Gerald Schaefer Cc: Heiko Carstens Cc: Vasily Gorbik Cc: Christian Borntraeger Cc: Sven Schnelle Cc: Signed-off-by: Andrew Morton Signed-off-by: Sasha Levin --- arch/arm64/mm/ptdump_debugfs.c | 3 --- arch/s390/mm/dump_pagetables.c | 2 -- mm/ptdump.c | 2 ++ 3 files changed, 2 insertions(+), 5 deletions(-) diff --git a/arch/arm64/mm/ptdump_debugfs.c b/arch/arm64/mm/ptdump_debugfs.c index d29d722ec3ec..457bf5f03771 100644 --- a/arch/arm64/mm/ptdump_debugfs.c +++ b/arch/arm64/mm/ptdump_debugfs.c @@ -1,6 +1,5 @@ // SPDX-License-Identifier: GPL-2.0 #include -#include #include #include @@ -9,9 +8,7 @@ static int ptdump_show(struct seq_file *m, void *v) { struct ptdump_info *info = m->private; - get_online_mems(); ptdump_walk(m, info); - put_online_mems(); return 0; } DEFINE_SHOW_ATTRIBUTE(ptdump); diff --git a/arch/s390/mm/dump_pagetables.c b/arch/s390/mm/dump_pagetables.c index 8f9ff7e7187d..b83c684ad6bb 100644 --- a/arch/s390/mm/dump_pagetables.c +++ b/arch/s390/mm/dump_pagetables.c @@ -218,11 +218,9 @@ static int ptdump_show(struct seq_file *m, void *v) .marker = address_markers, }; - get_online_mems(); mutex_lock(&cpa_mutex); ptdump_walk_pgd(&st.ptdump, &init_mm, NULL); mutex_unlock(&cpa_mutex); - put_online_mems(); return 0; } DEFINE_SHOW_ATTRIBUTE(ptdump); diff --git a/mm/ptdump.c b/mm/ptdump.c index a917bf55c61e..adbc141083c7 100644 --- a/mm/ptdump.c +++ b/mm/ptdump.c @@ -141,6 +141,7 @@ void ptdump_walk_pgd(struct ptdump_state *st, struct mm_struct *mm, pgd_t *pgd) { const struct ptdump_range *range = st->range; + get_online_mems(); mmap_write_lock(mm); while (range->start != range->end) { walk_page_range_novma(mm, range->start, range->end, @@ -148,6 +149,7 @@ void ptdump_walk_pgd(struct ptdump_state *st, struct mm_struct *mm, pgd_t *pgd) range++; } mmap_write_unlock(mm); + put_online_mems(); /* Flush out the last page */ st->note_page(st, 0, -1, 0); -- 2.50.1