From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B7E01335BAA for ; Thu, 21 Aug 2025 13:27:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755782832; cv=none; b=fTIX/RWgCGE0gbCwiUEB9NvNFLqUpEPcFDiUsZpXr1r9hAVxVUPSy+J3slwn6uebcNG2nX/XoiZeb19bqkjm6ufe8djDcLjC6HbnEa1Rba2K5QRHq3ymppmvknVEcisFZvKdQS5XTGpnrM9NIAJpVoaelKBwO5Nqjxu7AiIa1ow= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755782832; c=relaxed/simple; bh=I6OelE/U1Ti7Wqv8g/t1ysx3MR3lBkbMRYvItA2H/O4=; h=Subject:To:Cc:From:Date:Message-ID:MIME-Version:Content-Type; b=lT1tV+MDQy191aUeM+3Vs9a8LWZcpwEEmBg4OBIWrdEDecLkVarSpWFBuueE13vtUrCvYvL1lrW/K1BuI2sW0dhEvPlFZsGTpc5tt81VGg2/0IRUiORaW2VLnx3O9jWUlhnsYD4eUTiKDpkh49iM79qRrwInhK1T8NuES5m8S1E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=CvpDpldT; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="CvpDpldT" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C5110C4CEED; Thu, 21 Aug 2025 13:27:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1755782832; bh=I6OelE/U1Ti7Wqv8g/t1ysx3MR3lBkbMRYvItA2H/O4=; h=Subject:To:Cc:From:Date:From; b=CvpDpldT/Z//VGGil6ppXnV9Fh+MznB+E9Cs9DC1YVXZeKqDY7FgFwgEIYJ0ZghMY 7TpCtKqh+7cNe4mkmWC2eMFO7OhzJK2B636NVxto3LC+gAernXZ/KAE78+yPj5HRou NHBB0eHcT1OgMnIndeBka2bxMqQ3sw6Kwqe/G9KE= Subject: FAILED: patch "[PATCH] PCI/portdrv: Use is_pciehp instead of is_hotplug_bridge" failed to apply to 5.10-stable tree To: lukas@wunner.de,bhelgaas@google.com Cc: From: Date: Thu, 21 Aug 2025 15:27:01 +0200 Message-ID: <2025082101-cycle-deport-76fa@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit The patch below does not apply to the 5.10-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-5.10.y git checkout FETCH_HEAD git cherry-pick -x 1d60796a62f327cd9e0a6a0865ded7656d2c67f9 # git commit -s git send-email --to '' --in-reply-to '2025082101-cycle-deport-76fa@gregkh' --subject-prefix 'PATCH 5.10.y' HEAD^.. Possible dependencies: thanks, greg k-h ------------------ original commit in Linus's tree ------------------ >From 1d60796a62f327cd9e0a6a0865ded7656d2c67f9 Mon Sep 17 00:00:00 2001 From: Lukas Wunner Date: Sun, 13 Jul 2025 16:31:02 +0200 Subject: [PATCH] PCI/portdrv: Use is_pciehp instead of is_hotplug_bridge The PCIe port driver erroneously creates a subdevice for hotplug on ACPI slots which are handled by the ACPI hotplug driver. Avoid by checking the is_pciehp flag instead of is_hotplug_bridge when deciding whether to create a subdevice. The latter encompasses ACPI slots whereas the former doesn't. The superfluous subdevice has no real negative impact, it occupies memory and interrupt resources but otherwise just sits there waiting for interrupts from the slot that are never signaled. Fixes: f8415222837b ("PCI: Use cached copy of PCI_EXP_SLTCAP_HPC bit") Signed-off-by: Lukas Wunner Signed-off-by: Bjorn Helgaas Cc: stable@vger.kernel.org # v4.7+ Link: https://patch.msgid.link/40d5a5fe8d40595d505949c620a067fa110ee85e.1752390102.git.lukas@wunner.de diff --git a/drivers/pci/pcie/portdrv.c b/drivers/pci/pcie/portdrv.c index e8318fd5f6ed..d1b68c18444f 100644 --- a/drivers/pci/pcie/portdrv.c +++ b/drivers/pci/pcie/portdrv.c @@ -220,7 +220,7 @@ static int get_port_device_capability(struct pci_dev *dev) struct pci_host_bridge *host = pci_find_host_bridge(dev->bus); int services = 0; - if (dev->is_hotplug_bridge && + if (dev->is_pciehp && (pci_pcie_type(dev) == PCI_EXP_TYPE_ROOT_PORT || pci_pcie_type(dev) == PCI_EXP_TYPE_DOWNSTREAM) && (pcie_ports_native || host->native_pcie_hotplug)) {