From: Greg KH <gregkh@linuxfoundation.org>
To: Matthieu Baerts <matttbe@kernel.org>
Cc: Sasha Levin <sashal@kernel.org>,
stable@vger.kernel.org, Geliang Tang <geliang@kernel.org>,
Geliang Tang <tanggeliang@kylinos.cn>,
Jakub Kicinski <kuba@kernel.org>
Subject: Re: [PATCH 6.1.y] mptcp: remove duplicate sk_reset_timer call
Date: Sun, 24 Aug 2025 09:15:18 +0200 [thread overview]
Message-ID: <2025082408-ascent-transfer-2883@gregkh> (raw)
In-Reply-To: <e39b9a56-90c5-4379-bc6a-22a719c67848@kernel.org>
On Sun, Aug 24, 2025 at 09:08:06AM +0200, Matthieu Baerts wrote:
> Hi Greg, Sasha,
>
> 24 Aug 2025 09:02:56 Greg KH <gregkh@linuxfoundation.org>:
>
> > On Sat, Aug 23, 2025 at 10:34:06AM -0400, Sasha Levin wrote:
> >> From: Geliang Tang <geliang@kernel.org>
> >>
> >> [ Upstream commit 5d13349472ac8abcbcb94407969aa0fdc2e1f1be ]
> >>
> >> sk_reset_timer() was called twice in mptcp_pm_alloc_anno_list.
> >>
> >> Simplify the code by using a 'goto' statement to eliminate the
> >> duplication.
> >>
> >> Note that this is not a fix, but it will help backporting the following
> >> patch. The same "Fixes" tag has been added for this reason.
> >>
> >> Fixes: 93f323b9cccc ("mptcp: add a new sysctl add_addr_timeout")
> >> Cc: stable@vger.kernel.org
> >> Signed-off-by: Geliang Tang <tanggeliang@kylinos.cn>
> >> Reviewed-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
> >> Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
> >> Link: https://patch.msgid.link/20250815-net-mptcp-misc-fixes-6-17-rc2-v1-4-521fe9957892@kernel.org
> >> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> >> [ adjusted function location from pm.c to pm_netlink.c ]
> >> Signed-off-by: Sasha Levin <sashal@kernel.org>
> >> ---
> >> net/mptcp/pm_netlink.c | 5 ++---
> >> 1 file changed, 2 insertions(+), 3 deletions(-)
> >
> > Didn't apply cleanly :(
>
> I don't know if it is the reason, but I sent the same patches on Friday:
>
> https://lore.kernel.org/20250822141124.49727-5-matttbe@kernel.org/T
And it didn't apply either?
I'm confused...
next prev parent reply other threads:[~2025-08-24 7:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-22 6:04 FAILED: patch "[PATCH] mptcp: remove duplicate sk_reset_timer call" failed to apply to 6.1-stable tree gregkh
2025-08-23 14:34 ` [PATCH 6.1.y] mptcp: remove duplicate sk_reset_timer call Sasha Levin
2025-08-24 7:02 ` Greg KH
2025-08-24 7:08 ` Matthieu Baerts
2025-08-24 7:15 ` Greg KH [this message]
2025-08-24 7:45 ` Matthieu Baerts
2025-08-24 7:58 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025082408-ascent-transfer-2883@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=geliang@kernel.org \
--cc=kuba@kernel.org \
--cc=matttbe@kernel.org \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
--cc=tanggeliang@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox