From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2469F1DF75A; Tue, 26 Aug 2025 14:15:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756217712; cv=none; b=UjvqyrpafPY1e1XfYjo4YFJishTueVh+D2RZ06+2eefT7+3BEr1cCAidM5ceVFtFnjifuvYhIwOw/jNP8yH2002/ggdIDB0Y9J+0ELzBCoZb2jySO3C4mBL8LbNY6/4rN97sdKUzX/sgXq1YawT+KZdkdsii9+lQXkmKltnRj6g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756217712; c=relaxed/simple; bh=0nuN1pAq0yoExnyZORslmkoSI/a/3sSzsA51GHRM4IM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qF50Z3dzyvBBsAjmCBs32UP1XvTINkFHPpPwusFQmfD0Tnrui1vMe4MfRnMnMYxLUfhlbwEsHpNlX3BCUmmhWfrsxo9iv8fV/9YmTAv8dIruGNyUgN3BzE76EwkF4wN3CC5dfGYafezxnDH7xSAKhF+wXEHjfEEuOGcOwudgiJI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=tytpdjY3; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="tytpdjY3" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A8EDDC4CEF1; Tue, 26 Aug 2025 14:15:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1756217712; bh=0nuN1pAq0yoExnyZORslmkoSI/a/3sSzsA51GHRM4IM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=tytpdjY3wwLUNYYorZ2wUucZghGdcR2GQQFWuJTizuBbgF8wHLHHX3sp85ZAnbAan W88g/PWkKnSYUcUsCuiE5W1ntWK1O9KdYL6jW9GT7MFdFWXTWOd6NK9FY+ZUO+uoiC L6KIvJnRodn436y1XrbcqtBNxf8vyO0u8y5O5ngg= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Peter Ujfalusi , Bard Liao , Ranjani Sridharan , Liam Girdwood , Kai Vehmanen , Mark Brown , Sasha Levin Subject: [PATCH 5.10 247/523] ASoC: core: Check for rtd == NULL in snd_soc_remove_pcm_runtime() Date: Tue, 26 Aug 2025 13:07:37 +0200 Message-ID: <20250826110930.528045221@linuxfoundation.org> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250826110924.562212281@linuxfoundation.org> References: <20250826110924.562212281@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Peter Ujfalusi [ Upstream commit 2d91cb261cac6d885954b8f5da28b5c176c18131 ] snd_soc_remove_pcm_runtime() might be called with rtd == NULL which will leads to null pointer dereference. This was reproduced with topology loading and marking a link as ignore due to missing hardware component on the system. On module removal the soc_tplg_remove_link() would call snd_soc_remove_pcm_runtime() with rtd == NULL since the link was ignored, no runtime was created. Signed-off-by: Peter Ujfalusi Reviewed-by: Bard Liao Reviewed-by: Ranjani Sridharan Reviewed-by: Liam Girdwood Reviewed-by: Kai Vehmanen Link: https://patch.msgid.link/20250619084222.559-3-peter.ujfalusi@linux.intel.com Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- sound/soc/soc-core.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c index e9da95ebccc8..1120d669fe2e 100644 --- a/sound/soc/soc-core.c +++ b/sound/soc/soc-core.c @@ -958,6 +958,9 @@ static int soc_dai_link_sanity_check(struct snd_soc_card *card, void snd_soc_remove_pcm_runtime(struct snd_soc_card *card, struct snd_soc_pcm_runtime *rtd) { + if (!rtd) + return; + lockdep_assert_held(&client_mutex); /* release machine specific resources */ -- 2.39.5