From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 00E2E3570BD; Tue, 26 Aug 2025 14:17:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756217879; cv=none; b=VK2kqusjd46QZVMch7v9t54F5tlHm00t4jF25qAlAYw6J9/m0UgWwhsLIrchyO8kLWcSYgefm9bLItyp2WB7X8gMzPKQI5bduaGKJzFfsIKXDEMjWZ0eJ0JvnJBQ8iJjy5cTYwSHxYLVquKL1e8PZ/mgFcGd0TCFe+s/f86tle0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756217879; c=relaxed/simple; bh=chs/RnlDkaYiPZ7vuBaoo/lunTj+OhJ2J896qnLVOZg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=E5I+sCRG54BMMcAyy0hNWxp6NcqS+nLXhUPgLo2ea94C2jkX752tDKrj+e+bJ033qOg2ayN1I2l6vlWbbmxw6KuEBO74x2INcZ5fvw8lsu5q8cte5Xj5QHw38Esp5+tqU4RmRKyvW+nQGFRyH2xuoLTXdMX2OehYCwbFTxrjzf4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=HkPR0Mjp; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="HkPR0Mjp" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 845DFC116B1; Tue, 26 Aug 2025 14:17:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1756217878; bh=chs/RnlDkaYiPZ7vuBaoo/lunTj+OhJ2J896qnLVOZg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=HkPR0MjplvmQiDVgj6vgyj11Y3SEF732lOttn9HlkqLeoiuXY5C+1rlA/+WGhs6zt mqn8Kho37Zz9RqoLvXeoQ6DA2b3Dl3zj4M93Yxya9nfI46X3bBhkfHGuLPL4CnPGXy 6iIfODwOS60Cdbv3fQ7YS0X2nBOII/utOnn5IPQ8= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Dave Stevenson , Hans Verkuil , Sasha Levin Subject: [PATCH 5.10 310/523] media: tc358743: Increase FIFO trigger level to 374 Date: Tue, 26 Aug 2025 13:08:40 +0200 Message-ID: <20250826110932.107655144@linuxfoundation.org> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250826110924.562212281@linuxfoundation.org> References: <20250826110924.562212281@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Dave Stevenson [ Upstream commit 86addd25314a1e77dbdcfddfeed0bab2f27da0e2 ] The existing fixed value of 16 worked for UYVY 720P60 over 2 lanes at 594MHz, or UYVY 1080P60 over 4 lanes. (RGB888 1080P60 needs 6 lanes at 594MHz). It doesn't allow for lower resolutions to work as the FIFO underflows. 374 is required for 1080P24 or 1080P30 UYVY over 2 lanes @ 972Mbit/s, but >374 means that the FIFO underflows on 1080P50 UYVY over 2 lanes @ 972Mbit/s. Whilst it would be nice to compute it, the required information isn't published by Toshiba. Signed-off-by: Dave Stevenson Signed-off-by: Hans Verkuil Signed-off-by: Sasha Levin --- drivers/media/i2c/tc358743.c | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/drivers/media/i2c/tc358743.c b/drivers/media/i2c/tc358743.c index 3649c02d611e..9cc52beb3b5e 100644 --- a/drivers/media/i2c/tc358743.c +++ b/drivers/media/i2c/tc358743.c @@ -1960,8 +1960,19 @@ static int tc358743_probe_of(struct tc358743_state *state) state->pdata.refclk_hz = clk_get_rate(refclk); state->pdata.ddc5v_delay = DDC5V_DELAY_100_MS; state->pdata.enable_hdcp = false; - /* A FIFO level of 16 should be enough for 2-lane 720p60 at 594 MHz. */ - state->pdata.fifo_level = 16; + /* + * Ideally the FIFO trigger level should be set based on the input and + * output data rates, but the calculations required are buried in + * Toshiba's register settings spreadsheet. + * A value of 16 works with a 594Mbps data rate for 720p60 (using 2 + * lanes) and 1080p60 (using 4 lanes), but fails when the data rate + * is increased, or a lower pixel clock is used that result in CSI + * reading out faster than the data is arriving. + * + * A value of 374 works with both those modes at 594Mbps, and with most + * modes on 972Mbps. + */ + state->pdata.fifo_level = 374; /* * The PLL input clock is obtained by dividing refclk by pll_prd. * It must be between 6 MHz and 40 MHz, lower frequency is better. -- 2.39.5