From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2562F341650; Tue, 26 Aug 2025 14:19:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756217984; cv=none; b=nfiHBYewhdCcGNQAyv2BEVO1501Ps5Cp97UnH/oo8M/wU+EZ4a1lVJXAfleXaxv4CeJbEhVqh4tOJsMEeb7cP/QNXdZTYh51xKd3kWuUZx5EpGyCbAN6sVHcm9VcqELB8eGh1tj7Mj2L9LHGx2Ng+6O+LO3k1u7bKBUBLos/Rcw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756217984; c=relaxed/simple; bh=nHEN4nC1v/VqOY0YWD47ApmovhUvOUeHOZ9ChXqFdqo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ix5wgbRHIBdFSkyyMZFCPCltpo4jwaBttHxVSt9rwe93sOii6XCh6T3wDQoiwKjq1PPZcBRdGoaRqed/K6iP3px0DpQ5FxERU8fJ2VWxCU3j0HB1VbWCC1EZ8fQ0r75yrTjwrUd9t9BxmFuM2E8p4JQIddhByuoKjRlEf5smD3s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=fw+7OArd; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="fw+7OArd" Received: by smtp.kernel.org (Postfix) with ESMTPSA id ACBDEC4CEF1; Tue, 26 Aug 2025 14:19:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1756217984; bh=nHEN4nC1v/VqOY0YWD47ApmovhUvOUeHOZ9ChXqFdqo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fw+7OArdGkKSR6hjLOix+2821Im22iBKgMUIj7tlYgC9mTn1Zf4ZBpgmBgJ1pdhfs g5omPk0Q0AfTeViv5BZFXAHUnbWrqIBub0kbcuiE/Q1cVH/gCuni53mSKoooxDxb48 GxYVJfROwSVu5iHklcGIIIeUc56QMfiXFbfZmsN8= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Youngjun Lee , Laurent Pinchart , Ricardo Ribalda , Hans Verkuil Subject: [PATCH 5.10 350/523] media: uvcvideo: Fix 1-byte out-of-bounds read in uvc_parse_format() Date: Tue, 26 Aug 2025 13:09:20 +0200 Message-ID: <20250826110933.100196915@linuxfoundation.org> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250826110924.562212281@linuxfoundation.org> References: <20250826110924.562212281@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Youngjun Lee commit 782b6a718651eda3478b1824b37a8b3185d2740c upstream. The buffer length check before calling uvc_parse_format() only ensured that the buffer has at least 3 bytes (buflen > 2), buf the function accesses buffer[3], requiring at least 4 bytes. This can lead to an out-of-bounds read if the buffer has exactly 3 bytes. Fix it by checking that the buffer has at least 4 bytes in uvc_parse_format(). Signed-off-by: Youngjun Lee Reviewed-by: Laurent Pinchart Fixes: c0efd232929c ("V4L/DVB (8145a): USB Video Class driver") Cc: stable@vger.kernel.org Reviewed-by: Ricardo Ribalda Link: https://lore.kernel.org/r/20250610124107.37360-1-yjjuny.lee@samsung.com Signed-off-by: Laurent Pinchart Signed-off-by: Hans Verkuil Signed-off-by: Greg Kroah-Hartman --- drivers/media/usb/uvc/uvc_driver.c | 3 +++ 1 file changed, 3 insertions(+) --- a/drivers/media/usb/uvc/uvc_driver.c +++ b/drivers/media/usb/uvc/uvc_driver.c @@ -511,6 +511,9 @@ static int uvc_parse_format(struct uvc_d unsigned int i, n; u8 ftype; + if (buflen < 4) + return -EINVAL; + format->type = buffer[2]; format->index = buffer[3];