From: "Michał Górny" <mgorny@gentoo.org>
To: stable@vger.kernel.org
Cc: "Pierre-Louis Bossart" <pierre-louis.bossart@linux.intel.com>,
"Paul Olaru" <paul.olaru@oss.nxp.com>,
"Guennadi Liakhovetski" <guennadi.liakhovetski@linux.intel.com>,
"Rander Wang" <rander.wang@intel.com>,
"Mark Brown" <broonie@kernel.org>,
"Michał Górny" <mgorny@gentoo.org>
Subject: [PATCH v2 linux-5.10.y 2/5] ASoC: Intel: sof_rt5682: shrink platform_id names below 20 characters
Date: Mon, 1 Sep 2025 16:10:55 +0200 [thread overview]
Message-ID: <20250901141117.96236-2-mgorny@gentoo.org> (raw)
In-Reply-To: <20250901141117.96236-1-mgorny@gentoo.org>
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
commit 590cfb082837cc6c0c595adf1711330197c86a58 upstream.
Some Chromebooks machine driver aliases exceed 20 characters, which
leads to sparse warnings:
sound/soc/intel/boards/sof_rt5682.c:959:25: error: too long
initializer-string for array of char(no space for nul char)
sound/soc/intel/boards/sof_rt5682.c:989:25: error: too long
initializer-string for array of char(no space for nul char)
sound/soc/intel/boards/sof_rt5682.c:1039:25: error: too long
initializer-string for array of char(no space for nul char)
Fix by using the 'mx' shortcut for Maxim platforms (already used in
platform firmware)
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Paul Olaru <paul.olaru@oss.nxp.com>
Reviewed-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Reviewed-by: Rander Wang <rander.wang@intel.com>
Link: https://lore.kernel.org/r/20210621194057.21711-4-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Michał Górny <mgorny@gentoo.org>
---
sound/soc/intel/boards/sof_rt5682.c | 12 ++++++------
sound/soc/intel/common/soc-acpi-intel-jsl-match.c | 2 +-
sound/soc/intel/common/soc-acpi-intel-tgl-match.c | 4 ++--
3 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/sound/soc/intel/boards/sof_rt5682.c b/sound/soc/intel/boards/sof_rt5682.c
index 5883d1fa3b7e..414dc594014d 100644
--- a/sound/soc/intel/boards/sof_rt5682.c
+++ b/sound/soc/intel/boards/sof_rt5682.c
@@ -844,7 +844,7 @@ static const struct platform_device_id board_ids[] = {
.name = "sof_rt5682",
},
{
- .name = "tgl_max98357a_rt5682",
+ .name = "tgl_mx98357a_rt5682",
.driver_data = (kernel_ulong_t)(SOF_RT5682_MCLK_EN |
SOF_RT5682_SSP_CODEC(0) |
SOF_SPEAKER_AMP_PRESENT |
@@ -861,7 +861,7 @@ static const struct platform_device_id board_ids[] = {
SOF_RT5682_SSP_AMP(1)),
},
{
- .name = "tgl_max98373_rt5682",
+ .name = "tgl_mx98373_rt5682",
.driver_data = (kernel_ulong_t)(SOF_RT5682_MCLK_EN |
SOF_RT5682_SSP_CODEC(0) |
SOF_SPEAKER_AMP_PRESENT |
@@ -870,7 +870,7 @@ static const struct platform_device_id board_ids[] = {
SOF_RT5682_NUM_HDMIDEV(4)),
},
{
- .name = "jsl_rt5682_max98360a",
+ .name = "jsl_rt5682_mx98360a",
.driver_data = (kernel_ulong_t)(SOF_RT5682_MCLK_EN |
SOF_RT5682_MCLK_24MHZ |
SOF_RT5682_SSP_CODEC(0) |
@@ -898,7 +898,7 @@ MODULE_AUTHOR("Bard Liao <bard.liao@intel.com>");
MODULE_AUTHOR("Sathya Prakash M R <sathya.prakash.m.r@intel.com>");
MODULE_LICENSE("GPL v2");
MODULE_ALIAS("platform:sof_rt5682");
-MODULE_ALIAS("platform:tgl_max98357a_rt5682");
+MODULE_ALIAS("platform:tgl_mx98357a_rt5682");
MODULE_ALIAS("platform:jsl_rt5682_rt1015");
-MODULE_ALIAS("platform:tgl_max98373_rt5682");
-MODULE_ALIAS("platform:jsl_rt5682_max98360a");
+MODULE_ALIAS("platform:tgl_mx98373_rt5682");
+MODULE_ALIAS("platform:jsl_rt5682_mx98360a");
diff --git a/sound/soc/intel/common/soc-acpi-intel-jsl-match.c b/sound/soc/intel/common/soc-acpi-intel-jsl-match.c
index 34f5fcad5701..a539b65ba254 100644
--- a/sound/soc/intel/common/soc-acpi-intel-jsl-match.c
+++ b/sound/soc/intel/common/soc-acpi-intel-jsl-match.c
@@ -54,7 +54,7 @@ struct snd_soc_acpi_mach snd_soc_acpi_intel_jsl_machines[] = {
},
{
.id = "10EC5682",
- .drv_name = "jsl_rt5682_max98360a",
+ .drv_name = "jsl_rt5682_mx98360a",
.sof_fw_filename = "sof-jsl.ri",
.machine_quirk = snd_soc_acpi_codec_list,
.quirk_data = &mx98360a_spk,
diff --git a/sound/soc/intel/common/soc-acpi-intel-tgl-match.c b/sound/soc/intel/common/soc-acpi-intel-tgl-match.c
index 15d862cdcd2f..f7c491eba1e7 100644
--- a/sound/soc/intel/common/soc-acpi-intel-tgl-match.c
+++ b/sound/soc/intel/common/soc-acpi-intel-tgl-match.c
@@ -321,7 +321,7 @@ struct snd_soc_acpi_mach snd_soc_acpi_intel_tgl_machines[] = {
},
{
.id = "10EC5682",
- .drv_name = "tgl_max98357a_rt5682",
+ .drv_name = "tgl_mx98357a_rt5682",
.machine_quirk = snd_soc_acpi_codec_list,
.quirk_data = &tgl_codecs,
.sof_fw_filename = "sof-tgl.ri",
@@ -329,7 +329,7 @@ struct snd_soc_acpi_mach snd_soc_acpi_intel_tgl_machines[] = {
},
{
.id = "10EC5682",
- .drv_name = "tgl_max98373_rt5682",
+ .drv_name = "tgl_mx98373_rt5682",
.machine_quirk = snd_soc_acpi_codec_list,
.quirk_data = &tgl_max98373_amp,
.sof_fw_filename = "sof-tgl.ri",
next prev parent reply other threads:[~2025-09-01 14:11 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-29 6:03 5.10 backport request: ASoC: Intel: sof_rt5682: shrink platform_id names below 20 characters Michał Górny
2025-08-29 7:09 ` Michał Górny
2025-08-29 13:55 ` Greg KH
2025-08-31 18:25 ` Michał Górny
2025-09-01 5:34 ` Greg KH
2025-09-01 9:54 ` [PATCH linux-5.10.y 1/5] ASoC: Intel: bxt_da7219_max98357a: shrink platform_id " Michał Górny
2025-09-01 9:54 ` [PATCH linux-5.10.y 2/5] ASoC: Intel: sof_rt5682: shrink platform_id names " Michał Górny
2025-09-01 9:54 ` [PATCH linux-5.10.y 3/5] ASoC: Intel: glk_rt5682_max98357a: shrink platform_id " Michał Górny
2025-09-01 9:54 ` [PATCH linux-5.10.y 4/5] ASoC: Intel: sof_da7219_max98373: " Michał Górny
2025-09-01 9:54 ` [PATCH linux-5.10.y 5/5] ASoC: Intel: sof_da7219_mx98360a: fail to initialize soundcard Michał Górny
2025-09-01 13:25 ` [PATCH linux-5.10.y 1/5] ASoC: Intel: bxt_da7219_max98357a: shrink platform_id below 20 characters Greg KH
2025-09-01 13:55 ` Michał Górny
2025-09-01 13:59 ` Greg KH
2025-09-01 14:10 ` [PATCH v2 " Michał Górny
2025-09-01 14:10 ` Michał Górny [this message]
2025-09-01 14:10 ` [PATCH v2 linux-5.10.y 3/5] ASoC: Intel: glk_rt5682_max98357a: " Michał Górny
2025-09-01 14:10 ` [PATCH v2 linux-5.10.y 4/5] ASoC: Intel: sof_da7219_max98373: " Michał Górny
2025-09-01 14:10 ` [PATCH v2 linux-5.10.y 5/5] ASoC: Intel: sof_da7219_mx98360a: fail to initialize soundcard Michał Górny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250901141117.96236-2-mgorny@gentoo.org \
--to=mgorny@gentoo.org \
--cc=broonie@kernel.org \
--cc=guennadi.liakhovetski@linux.intel.com \
--cc=paul.olaru@oss.nxp.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=rander.wang@intel.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).