From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B8BBF261593; Tue, 2 Sep 2025 13:39:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756820353; cv=none; b=TMK8reIIhbdAg+JIO4VCN/jK2bbCwlOViJ6BfmdeCZErqZKn8pSIcnSDUhFiSowCEhOl1QaD+r5384uiFngHYOkEX13QSY3w//4Rf1X84Mpgu+4EQMFQ/+bWwL4bXjPxxwenr3VIrT+CEEREhNDfgPd0ftdY4F5h1j8p1GNqUlI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756820353; c=relaxed/simple; bh=thbMznhkrMYJKlk4qcBKBIzLSnzW1hGsrGiMYMuzRyg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=GcIhKMnebkTezlxOoScH015zPCZJP3RgXlClBKF8w+ZCdpymcKrkvgfbKO3yksuSfwJY4VLx2jNC6fV+vh0GNUB0xNp75rW3M8d+QmdKHLsQqVGJcP5gG4clrgzLwtJDlWkzzw5GTjBdMZJKE8ZIRpK0SRqn9Dv9Teg53TT6uCI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=R784Gmhb; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="R784Gmhb" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 41FABC4CEED; Tue, 2 Sep 2025 13:39:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1756820353; bh=thbMznhkrMYJKlk4qcBKBIzLSnzW1hGsrGiMYMuzRyg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=R784Gmhbt7VOF38Kz2YVDI3N/CaPXQqB9K8HV/aLYUmcchmVKyYG+WHaZFgbG2MYS nZ87Q0GDJXsKYufRZ0D48htgCRuxye5P3u2mCogATGicXKWCRqoaIkeA/8xjqwAxBf MZoO3cx88qxZrFT7YHLhVzJ1vIZ4/DFcxazGtuow= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, syzbot+2eb8d1719f7cfcfa6840@syzkaller.appspotmail.com, Eric Dumazet , Takamitsu Iwai , Kuniyuki Iwashima , Jakub Kicinski Subject: [PATCH 6.6 70/75] net: rose: fix a typo in rose_clear_routes() Date: Tue, 2 Sep 2025 15:21:22 +0200 Message-ID: <20250902131937.858065169@linuxfoundation.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250902131935.107897242@linuxfoundation.org> References: <20250902131935.107897242@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Eric Dumazet commit 1cc8a5b534e5f9b5e129e54ee2e63c9f5da4f39a upstream. syzbot crashed in rose_clear_routes(), after a recent patch typo. KASAN: null-ptr-deref in range [0x0000000000000010-0x0000000000000017] CPU: 0 UID: 0 PID: 10591 Comm: syz.3.1856 Not tainted syzkaller #0 PREEMPT(full) Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 07/12/2025 RIP: 0010:rose_clear_routes net/rose/rose_route.c:565 [inline] RIP: 0010:rose_rt_ioctl+0x162/0x1250 net/rose/rose_route.c:760 rose_ioctl+0x3ce/0x8b0 net/rose/af_rose.c:1381 sock_do_ioctl+0xd9/0x300 net/socket.c:1238 sock_ioctl+0x576/0x790 net/socket.c:1359 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:598 [inline] __se_sys_ioctl+0xfc/0x170 fs/ioctl.c:584 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline] do_syscall_64+0xfa/0x3b0 arch/x86/entry/syscall_64.c:94 entry_SYSCALL_64_after_hwframe+0x77/0x7f Fixes: da9c9c877597 ("net: rose: include node references in rose_neigh refcount") Reported-by: syzbot+2eb8d1719f7cfcfa6840@syzkaller.appspotmail.com Closes: https://lore.kernel.org/netdev/68af3e29.a70a0220.3cafd4.002e.GAE@google.com/T/#u Signed-off-by: Eric Dumazet Cc: Takamitsu Iwai Reviewed-by: Kuniyuki Iwashima Link: https://patch.msgid.link/20250827172149.5359-1-edumazet@google.com Signed-off-by: Jakub Kicinski Signed-off-by: Greg Kroah-Hartman --- net/rose/rose_route.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/net/rose/rose_route.c +++ b/net/rose/rose_route.c @@ -562,7 +562,7 @@ static int rose_clear_routes(void) rose_node = rose_node->next; if (!t->loopback) { - for (i = 0; i < rose_node->count; i++) + for (i = 0; i < t->count; i++) rose_neigh_put(t->neighbour[i]); rose_remove_node(t); }