From: Suraj Jitindar Singh <surajjs@amazon.com>
To: <stable@vger.kernel.org>
Cc: Pawan Gupta <pawan.kumar.gupta@linux.intel.com>,
Josh Poimboeuf <jpoimboe@kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Peter Zijlstra <peterz@infradead.org>,
"Suraj Jitindar Singh" <surajjs@amazon.com>
Subject: [PATCH 5.10 3/4] x86/speculation: Add a conditional CS prefix to CALL_NOSPEC
Date: Wed, 3 Sep 2025 15:50:02 -0700 [thread overview]
Message-ID: <20250903225003.50346-4-surajjs@amazon.com> (raw)
In-Reply-To: <20250903225003.50346-1-surajjs@amazon.com>
From: Pawan Gupta <pawan.kumar.gupta@linux.intel.com>
commit 052040e34c08428a5a388b85787e8531970c0c67 upstream.
Retpoline mitigation for spectre-v2 uses thunks for indirect branches. To
support this mitigation compilers add a CS prefix with
-mindirect-branch-cs-prefix. For an indirect branch in asm, this needs to
be added manually.
CS prefix is already being added to indirect branches in asm files, but not
in inline asm. Add CS prefix to CALL_NOSPEC for inline asm as well. There
is no JMP_NOSPEC for inline asm.
Reported-by: Josh Poimboeuf <jpoimboe@kernel.org>
Signed-off-by: Pawan Gupta <pawan.kumar.gupta@linux.intel.com>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: https://lore.kernel.org/r/20250228-call-nospec-v3-2-96599fed0f33@linux.intel.com
Signed-off-by: Suraj Jitindar Singh <surajjs@amazon.com>
Cc: <stable@vger.kernel.org> # 5.10.x
---
arch/x86/include/asm/nospec-branch.h | 19 +++++++++++++++----
1 file changed, 15 insertions(+), 4 deletions(-)
diff --git a/arch/x86/include/asm/nospec-branch.h b/arch/x86/include/asm/nospec-branch.h
index bb7dd09dc295..2cade6749322 100644
--- a/arch/x86/include/asm/nospec-branch.h
+++ b/arch/x86/include/asm/nospec-branch.h
@@ -119,9 +119,8 @@
.endm
/*
- * Equivalent to -mindirect-branch-cs-prefix; emit the 5 byte jmp/call
- * to the retpoline thunk with a CS prefix when the register requires
- * a RAX prefix byte to encode. Also see apply_retpolines().
+ * Emits a conditional CS prefix that is compatible with
+ * -mindirect-branch-cs-prefix.
*/
.macro __CS_PREFIX reg:req
.irp rs,r8,r9,r10,r11,r12,r13,r14,r15
@@ -281,12 +280,24 @@ extern retpoline_thunk_t __x86_indirect_thunk_array[];
#ifdef CONFIG_X86_64
+/*
+ * Emits a conditional CS prefix that is compatible with
+ * -mindirect-branch-cs-prefix.
+ */
+#define __CS_PREFIX(reg) \
+ ".irp rs,r8,r9,r10,r11,r12,r13,r14,r15\n" \
+ ".ifc \\rs," reg "\n" \
+ ".byte 0x2e\n" \
+ ".endif\n" \
+ ".endr\n"
+
/*
* Inline asm uses the %V modifier which is only in newer GCC
* which is ensured when CONFIG_RETPOLINE is defined.
*/
#ifdef CONFIG_RETPOLINE
-#define CALL_NOSPEC "call __x86_indirect_thunk_%V[thunk_target]\n"
+#define CALL_NOSPEC __CS_PREFIX("%V[thunk_target]") \
+ "call __x86_indirect_thunk_%V[thunk_target]\n"
#else
#define CALL_NOSPEC "call *%[thunk_target]\n"
#endif
--
2.34.1
next prev parent reply other threads:[~2025-09-03 22:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-03 22:49 [PATCH 5.10 0/4] x86/speculation: Make {JMP,CALL}_NOSPEC Consistent Suraj Jitindar Singh
2025-09-03 22:50 ` [PATCH 5.10 1/4] x86,nospec: Simplify {JMP,CALL}_NOSPEC Suraj Jitindar Singh
2025-09-03 22:50 ` [PATCH 5.10 2/4] x86/speculation: Simplify and make CALL_NOSPEC consistent Suraj Jitindar Singh
2025-09-03 22:50 ` Suraj Jitindar Singh [this message]
2025-09-03 22:50 ` [PATCH 5.10 4/4] x86/speculation: Remove the extra #ifdef around CALL_NOSPEC Suraj Jitindar Singh
2025-09-04 12:00 ` [PATCH 5.10 0/4] x86/speculation: Make {JMP,CALL}_NOSPEC Consistent Greg KH
2025-09-16 20:41 ` [PATCH 5.10 0/4] x86/speculation: Make {JMP, CALL}_NOSPEC Consistent Jitindar Singh, Suraj
2025-09-17 7:40 ` gregkh
2025-09-04 12:01 ` [PATCH 5.10 0/4] x86/speculation: Make {JMP,CALL}_NOSPEC Consistent Greg KH
2025-09-16 20:44 ` [PATCH 5.10 0/4] x86/speculation: Make {JMP, CALL}_NOSPEC Consistent Jitindar Singh, Suraj
2025-09-17 7:52 ` gregkh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250903225003.50346-4-surajjs@amazon.com \
--to=surajjs@amazon.com \
--cc=jpoimboe@kernel.org \
--cc=mingo@kernel.org \
--cc=pawan.kumar.gupta@linux.intel.com \
--cc=peterz@infradead.org \
--cc=stable@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox