From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Emanuele Ghidoli <ghidoliemanuele@gmail.com>
Cc: stable@vger.kernel.org, Jonathan Bell <jonathan@raspberrypi.com>,
Keita Aihara <keita.aihara@sony.com>,
Dragan Simic <dsimic@manjaro.org>,
Avri Altman <avri.altman@wdc.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Emanuele Ghidoli <emanuele.ghidoli@toradex.com>
Subject: Re: [PATCH v1 1/1] mmc: core: apply SD quirks earlier during probe
Date: Sun, 7 Sep 2025 10:02:18 +0200 [thread overview]
Message-ID: <2025090705-rumbling-twirl-81e2@gregkh> (raw)
In-Reply-To: <20250905111431.1914549-2-ghidoliemanuele@gmail.com>
On Fri, Sep 05, 2025 at 01:14:29PM +0200, Emanuele Ghidoli wrote:
> From: Jonathan Bell <jonathan@raspberrypi.com>
>
> Applying MMC_QUIRK_BROKEN_SD_CACHE is broken, as the card's SD quirks are
> referenced in sd_parse_ext_reg_perf() prior to the quirks being initialized
> in mmc_blk_probe().
>
> To fix this problem, let's split out an SD-specific list of quirks and
> apply in mmc_sd_init_card() instead. In this way, sd_read_ext_regs() to has
> the available information for not assigning the SD_EXT_PERF_CACHE as one of
> the (un)supported features, which in turn allows mmc_sd_init_card() to
> properly skip execution of sd_enable_cache().
>
> Fixes: 1728e17762b9 ("mmc: core: sd: Apply BROKEN_SD_DISCARD quirk earlier")
> Signed-off-by: Jonathan Bell <jonathan@raspberrypi.com>
> Co-developed-by: Keita Aihara <keita.aihara@sony.com>
> Signed-off-by: Keita Aihara <keita.aihara@sony.com>
> Reviewed-by: Dragan Simic <dsimic@manjaro.org>
> Reviewed-by: Avri Altman <avri.altman@wdc.com>
> Cc: stable@vger.kernel.org
> Link: https://lore.kernel.org/r/20240820230631.GA436523@sony.com
> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
> Signed-off-by: Emanuele Ghidoli <emanuele.ghidoli@toradex.com>
> ---
> drivers/mmc/core/sd.c | 4 ++++
> 1 file changed, 4 insertions(+)
What is the git id of this commit in Linus's tree?
thanks,
greg k-h
next prev parent reply other threads:[~2025-09-07 8:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-05 11:14 [PATCH v1 0/1] mmc: core: apply SD quirks earlier during probe on 5.15 stable kernel Emanuele Ghidoli
2025-09-05 11:14 ` [PATCH v1 1/1] mmc: core: apply SD quirks earlier during probe Emanuele Ghidoli
2025-09-06 5:31 ` Avri Altman
2025-09-07 8:02 ` Greg Kroah-Hartman [this message]
2025-09-07 10:04 ` Avri Altman
2025-09-06 5:28 ` [PATCH v1 0/1] mmc: core: apply SD quirks earlier during probe on 5.15 stable kernel Avri Altman
2025-09-07 8:12 ` Greg Kroah-Hartman
2025-09-07 10:10 ` Avri Altman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025090705-rumbling-twirl-81e2@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=avri.altman@wdc.com \
--cc=dsimic@manjaro.org \
--cc=emanuele.ghidoli@toradex.com \
--cc=ghidoliemanuele@gmail.com \
--cc=jonathan@raspberrypi.com \
--cc=keita.aihara@sony.com \
--cc=stable@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox