From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 63BFD20E00B; Sun, 7 Sep 2025 20:40:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757277641; cv=none; b=WhelBhUDtLFS08sDVcGcEsftSCSFdKDtXSV0ocBS2O4CJUTkPlT+CcDDPijP78LsWpaXl3tZkxNWuvLBuuhuWIAZY9X0rAcDmsERnLPl3+1z5kX647Udh9yx1K/4o09KyJOonrGu0TQHdZipXvgLZ8F4xYlLgwGdMHREEiz9E48= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757277641; c=relaxed/simple; bh=4R+8gBJWuqaO48vcZXShH9r1EFZy12rZRxgqppP0fcs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=THM/Q6FgOx8B3R91rljNukP0zkUZ1Qo+SFWIdLaMe2QXEvqAfH6O+Z6eR6pj6Mr55dTeogk+hywdlHeq9I7n2/iDBGHTtTjW5bJQYKTnKxssntAFC6Mk6O8fCDiSerPfjANtDy3QmKkzlU1mGJcGLDejZ78Bt2YfTtdu3k8uLZY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=nsRzKn7P; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="nsRzKn7P" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E1749C4CEF0; Sun, 7 Sep 2025 20:40:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1757277641; bh=4R+8gBJWuqaO48vcZXShH9r1EFZy12rZRxgqppP0fcs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=nsRzKn7PMX8uBJOrUMrdffagH2iJVBVcvbk13ruGsjLn1iAT+tb2jzBXwEO+RQKxE AdpkDvMJTkOWyWIOnEBmcJSkL/FAgoVXduGc5+kIKXselFMFxiyqSZ7ImTWp/INWd7 ChRHI0yO4dKFhTVYvS7y1tNluSQJvG29MRTaZ/kE= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Dan Carpenter , Johannes Berg , Sasha Levin Subject: [PATCH 6.16 079/183] wifi: cfg80211: sme: cap SSID length in __cfg80211_connect_result() Date: Sun, 7 Sep 2025 21:58:26 +0200 Message-ID: <20250907195617.672690056@linuxfoundation.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250907195615.802693401@linuxfoundation.org> References: <20250907195615.802693401@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.16-stable review patch. If anyone has any objections, please let me know. ------------------ From: Dan Carpenter [ Upstream commit 62b635dcd69c4fde7ce1de4992d71420a37e51e3 ] If the ssid->datalen is more than IEEE80211_MAX_SSID_LEN (32) it would lead to memory corruption so add some bounds checking. Fixes: c38c70185101 ("wifi: cfg80211: Set SSID if it is not already set") Signed-off-by: Dan Carpenter Link: https://patch.msgid.link/0aaaae4a3ed37c6252363c34ae4904b1604e8e32.1756456951.git.dan.carpenter@linaro.org Signed-off-by: Johannes Berg Signed-off-by: Sasha Levin --- net/wireless/sme.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/net/wireless/sme.c b/net/wireless/sme.c index cf998500a9654..05d06512983c2 100644 --- a/net/wireless/sme.c +++ b/net/wireless/sme.c @@ -901,13 +901,16 @@ void __cfg80211_connect_result(struct net_device *dev, if (!wdev->u.client.ssid_len) { rcu_read_lock(); for_each_valid_link(cr, link) { + u32 ssid_len; + ssid = ieee80211_bss_get_elem(cr->links[link].bss, WLAN_EID_SSID); if (!ssid || !ssid->datalen) continue; - memcpy(wdev->u.client.ssid, ssid->data, ssid->datalen); + ssid_len = min(ssid->datalen, IEEE80211_MAX_SSID_LEN); + memcpy(wdev->u.client.ssid, ssid->data, ssid_len); wdev->u.client.ssid_len = ssid->datalen; break; } -- 2.50.1