[PATCH] arm64: dts: qcom: sdm845-shift-axolotl: Fix typo of compatible

[PATCH] arm64: dts: qcom: sdm845-shift-axolotl: Fix typo of compatible

[Tamura Dai]

Merge a hibernation regression fix and an fix related to energy model

The bug is a typo in the compatible string for the touchscreen node.
According to Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml,
the correct compatible is "focaltech,ft8719", but the device tree used
"focaltech,fts8719".

Fixes: 45882459159de (arm64: dts: qcom: sdm845: add device tree for SHIFT6mq)
Cc: stable@vger.kernel.org
Signed-off-by: Tamura Dai <kirinode0@gmail.com>
---
 arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts b/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts
index 2cf7b5e1243c..a0b288d6162f 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts
+++ b/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts
@@ -432,7 +432,7 @@ &i2c5 {
 	status = "okay";
 
 	touchscreen@38 {
-		compatible = "focaltech,fts8719";
+		compatible = "focaltech,ft8719";
 		reg = <0x38>;
 		wakeup-source;
 		interrupt-parent = <&tlmm>;
-- 
2.34.1

[PATCH v2] arm64: dts: qcom: sdm845-shift-axolotl: Fix typo of compatible

[Tamura Dai]

The bug is a typo in the compatible string for the touchscreen node.
According to Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml,
the correct compatible is "focaltech,ft8719", but the device tree used
"focaltech,fts8719".

Fixes: 45882459159de (arm64: dts: qcom: sdm845: add device tree for SHIFT6mq)
Cc: stable@vger.kernel.org
Signed-off-by: Tamura Dai <kirinode0@gmail.com>
---
 arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts b/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts
index 2cf7b5e1243c..a0b288d6162f 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts
+++ b/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts
@@ -432,7 +432,7 @@ &i2c5 {
 	status = "okay";
 
 	touchscreen@38 {
-		compatible = "focaltech,fts8719";
+		compatible = "focaltech,ft8719";
 		reg = <0x38>;
 		wakeup-source;
 		interrupt-parent = <&tlmm>;
-- 
2.34.1

Re: [PATCH v2] arm64: dts: qcom: sdm845-shift-axolotl: Fix typo of compatible

[Luca Weiss]

Hi Tamura,

On Fri Sep 12, 2025 at 9:01 AM CEST, Tamura Dai wrote:
> The bug is a typo in the compatible string for the touchscreen node.
> According to Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml,
> the correct compatible is "focaltech,ft8719", but the device tree used
> "focaltech,fts8719".

+Joel

I don't think this patch is really correct, in the sdm845-mainline fork
there's a different commit which has some more changes to make the
touchscreen work:

https://gitlab.com/sdm845-mainline/linux/-/commit/2ca76ac2e046158814b043fd4e37949014930d70

Regards
Luca


>
> Fixes: 45882459159de (arm64: dts: qcom: sdm845: add device tree for SHIFT6mq)
> Cc: stable@vger.kernel.org
> Signed-off-by: Tamura Dai <kirinode0@gmail.com>
> ---
>  arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts b/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts
> index 2cf7b5e1243c..a0b288d6162f 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts
> @@ -432,7 +432,7 @@ &i2c5 {
>  	status = "okay";
>  
>  	touchscreen@38 {
> -		compatible = "focaltech,fts8719";
> +		compatible = "focaltech,ft8719";
>  		reg = <0x38>;
>  		wakeup-source;
>  		interrupt-parent = <&tlmm>;

Re: [PATCH v2] arm64: dts: qcom: sdm845-shift-axolotl: Fix typo of compatible

[Krzysztof Kozlowski]

On 12/09/2025 09:01, Tamura Dai wrote:
> The bug is a typo in the compatible string for the touchscreen node.
> According to Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml,
> the correct compatible is "focaltech,ft8719", but the device tree used
> "focaltech,fts8719".
> 
> Fixes: 45882459159de (arm64: dts: qcom: sdm845: add device tree for SHIFT6mq)


Missing quotes.
[alias]
	sf = show --pretty='Fixes: %h (\"%s\")'

and then just `git sf commit`

Please run scripts/checkpatch.pl on the patches and fix reported
warnings. After that, run also 'scripts/checkpatch.pl --strict' on the
patches and (probably) fix more warnings. Some warnings can be ignored,
especially from --strict run, but the code here looks like it needs a
fix. Feel free to get in touch if the warning is not clear.

Do not attach (thread) your patchsets to some other threads (unrelated
or older versions). This buries them deep in the mailbox and might
interfere with applying entire sets. See also:
https://elixir.bootlin.com/linux/v6.16-rc2/source/Documentation/process/submitting-patches.rst#L830

> Cc: stable@vger.kernel.org
> Signed-off-by: Tamura Dai <kirinode0@gmail.com>

With quotes fixed:

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

Re: [PATCH v2] arm64: dts: qcom: sdm845-shift-axolotl: Fix typo of compatible

[Joel Selvaraj]

Hi Luca Weiss and Tamura Dai,

On 9/12/25 02:24, Luca Weiss wrote:
> Hi Tamura,
> 
> On Fri Sep 12, 2025 at 9:01 AM CEST, Tamura Dai wrote:
>> The bug is a typo in the compatible string for the touchscreen node.
>> According to Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml,
>> the correct compatible is "focaltech,ft8719", but the device tree used
>> "focaltech,fts8719".
> 
> +Joel
> 
> I don't think this patch is really correct, in the sdm845-mainline fork
> there's a different commit which has some more changes to make the
> touchscreen work:
> 
> https://gitlab.com/sdm845-mainline/linux/-/commit/2ca76ac2e046158814b043fd4e37949014930d70

Yes, this patch is not correct. My commit from the gitlab repo is the 
correct one. But I personally don't have the shiftmq6 device to smoke 
test before sending the patch. That's why I was hesitant to send it 
upstream. I have now requested someone to confirm if the touchscreen 
works with my gitlab commit. If if its all good, I will send the correct 
patch later.

Regards,
Joel

Re: [PATCH v2] arm64: dts: qcom: sdm845-shift-axolotl: Fix typo of compatible

[Luca Weiss]

On Fri Sep 19, 2025 at 8:23 AM CEST, Joel Selvaraj wrote:
> Hi Luca Weiss and Tamura Dai,
>
> On 9/12/25 02:24, Luca Weiss wrote:
>> Hi Tamura,
>> 
>> On Fri Sep 12, 2025 at 9:01 AM CEST, Tamura Dai wrote:
>>> The bug is a typo in the compatible string for the touchscreen node.
>>> According to Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml,
>>> the correct compatible is "focaltech,ft8719", but the device tree used
>>> "focaltech,fts8719".
>> 
>> +Joel
>> 
>> I don't think this patch is really correct, in the sdm845-mainline fork
>> there's a different commit which has some more changes to make the
>> touchscreen work:
>> 
>> https://gitlab.com/sdm845-mainline/linux/-/commit/2ca76ac2e046158814b043fd4e37949014930d70
>
> Yes, this patch is not correct. My commit from the gitlab repo is the 
> correct one. But I personally don't have the shiftmq6 device to smoke 
> test before sending the patch. That's why I was hesitant to send it 
> upstream. I have now requested someone to confirm if the touchscreen 
> works with my gitlab commit. If if its all good, I will send the correct 
> patch later.

Hi,

As written on Matrix I've confirmed the patch you linked works on v6.16.

Regards
Luca

>
> Regards,
> Joel